Received: by 2002:ac0:a582:0:0:0:0:0 with SMTP id m2-v6csp4642038imm; Mon, 15 Oct 2018 19:43:05 -0700 (PDT) X-Google-Smtp-Source: ACcGV6004AIgo9WCVU1keDRuYDsTghOZ2glRa2PPgbiTrr4xv38IovvNLiVGnF/ZoISdxSgyCHRA X-Received: by 2002:a63:4cb:: with SMTP id 194-v6mr18535445pge.183.1539657785425; Mon, 15 Oct 2018 19:43:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1539657785; cv=none; d=google.com; s=arc-20160816; b=nt2MLjpqMbxhyqolzuyS47kW6bTR0frxEApu2XCMwF0RX1Qa5y5AtB/tAaknyCg5KX 0TrHADU/CLnQz53UE9JAS6oFSeWjDAhFpjkL1rCxV0k7neIrQqSTE+t1nPXnk71Bv4Jm KGMxFl9wBSUwQDj+hEcoptMPgeSHsmjvZOiQQ4sNZybIh/NVxFxdlzP9KSD6jOQ2hbUo jinlzxG+X/GpxwHe5KvM5Kvv8whyKTGxD7dsQvNx7p7Pc+6LM3F2GMZStaHRv8fVuXoU VS4uEi1ORlNesfWcfCEwTYI7p+jAlGrn6lqbsIwZgGpnHZkVKanC4SxqxfSlt7GQhqp5 xWJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature; bh=CCjwtqQtCAOwIXfabE6A59py+g67jCSp+upDI4OtmXg=; b=FBV1JaHEeIoAIlWb0CZLyG8RKXIYpiqQKXDcIyHSXxQPW8nW46LLsZp+RMGnCdvPd+ wwmMUzgWLETVXD6+kjK01QL6SRcRHNqPh5c4ZkBwvYp68B/xULKRBfQpKq51JHC9RL4H E6SHpij+7RUIOvmtFp1YTiAcqIInjp1Xe15Zjd004F40OWt/aomHzZ2aZ25Can+80scs ohSzpe8RzjJcdnNEymPxuC0XhP0kA+Z0v2JCG5duQ2dMKtD5wjKI397jSCE11j/rnEVC wMgl9hXMo0XqDxt+x07E+NxOWBseBE2S6Rkf6NdjO9E/I2BDTXLD+tyFpySFseuTmGoU CN9g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=QSe2uh2l; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l21-v6si12543615pgo.269.2018.10.15.19.42.49; Mon, 15 Oct 2018 19:43:05 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=QSe2uh2l; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727094AbeJPK1V (ORCPT + 99 others); Tue, 16 Oct 2018 06:27:21 -0400 Received: from mail-pf1-f195.google.com ([209.85.210.195]:44185 "EHLO mail-pf1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727016AbeJPK1U (ORCPT ); Tue, 16 Oct 2018 06:27:20 -0400 Received: by mail-pf1-f195.google.com with SMTP id r9-v6so10641791pff.11; Mon, 15 Oct 2018 19:39:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=CCjwtqQtCAOwIXfabE6A59py+g67jCSp+upDI4OtmXg=; b=QSe2uh2lmEBWzGocx1091GFtso1i+7JvcwBNHmFcLCaOD9XT58ge0nRjLWnEsf5qKW Q7rYPC+wn+HYN+ZQBLHSd7Jv+IT2SMyzU5ZRp3qLwxv9ZgEAD4Z6K+WVbEgXOudkKqSz B6qXTLLyzrEaFLq8Dv0KVfuanrf5EEk85M5YHq1EZEnXNnK19YBs56l4homFQOa+4v7Q PgjlMiyAafVC4bQUTijplazml94eUr68CoRd2HQb/OZm3dsktc6DA7LKol6V0jDoitAq n5txE/0Ol0tzKfWlBU4dLXytbimzSU1jspWGAcAFvy+XTZAOVPZutwGQjST6M6ArYaV+ lJiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=CCjwtqQtCAOwIXfabE6A59py+g67jCSp+upDI4OtmXg=; b=n4qYedft+VA6X4EVIiP8K0zC6cNMjCA5tX4kSFbkXPrEIomjgrRQANmVLWvDboCwPQ 6tezNpilCmALtJHzIV2XO1rf7d/Bt0rxOgXy1CzrMJTOooSuoBFLsfB80NgF/o/XMHjX I19fJJ/KMBkXZMAwohEuhrZ9Dd4S+ZfjxWDI4Lqe2mnQwyuAk+WJAoeeDJ+jCqgyahBe oc/etJ0PXNeBW8D+Z8cR15cY9YuuSqbpPKsDIcPXHvEMs18QyEtS9T/qZjaOj+ZkNbE9 q0p8RFMuzaq6eCToQhMqyRCu+d9Ny82bq7s+v5/HWrckG47mpWOvo4QjFWEHo8zsrAfn cFMw== X-Gm-Message-State: ABuFfoiVeTFpAP+GAOjqYGTseWYtYYuE8o19Zs179PmuQeB8VPcR1Uwt 5Sv6pypmgUpF1zlYHPpAAf+Yyok3 X-Received: by 2002:a63:9612:: with SMTP id c18-v6mr17827455pge.21.1539657556344; Mon, 15 Oct 2018 19:39:16 -0700 (PDT) Received: from localhost.localdomain (c-24-6-192-50.hsd1.ca.comcast.net. [24.6.192.50]) by smtp.gmail.com with ESMTPSA id u79-v6sm18620287pfd.117.2018.10.15.19.39.15 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 15 Oct 2018 19:39:15 -0700 (PDT) From: frowand.list@gmail.com To: Rob Herring , Pantelis Antoniou , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Alan Tull , Moritz Fischer Cc: linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, devicetree@vger.kernel.org, linux-fpga@vger.kernel.org Subject: [PATCH v4 04/18] powerpc/pseries: add of_node_put() in dlpar_detach_node() Date: Mon, 15 Oct 2018 19:37:24 -0700 Message-Id: <1539657458-24401-5-git-send-email-frowand.list@gmail.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1539657458-24401-1-git-send-email-frowand.list@gmail.com> References: <1539657458-24401-1-git-send-email-frowand.list@gmail.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Frank Rowand "of: overlay: add missing of_node_get() in __of_attach_node_sysfs" added a missing of_node_get() to __of_attach_node_sysfs(). This results in a refcount imbalance for nodes attached with dlpar_attach_node(). The calling sequence from dlpar_attach_node() to __of_attach_node_sysfs() is: dlpar_attach_node() of_attach_node() __of_attach_node_sysfs() Signed-off-by: Frank Rowand --- ***** UNTESTED. I need people with the affected PowerPC systems ***** (systems that dynamically allocate and deallocate ***** devicetree nodes) to test this patch. arch/powerpc/platforms/pseries/dlpar.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/powerpc/platforms/pseries/dlpar.c b/arch/powerpc/platforms/pseries/dlpar.c index a0b20c03f078..e3010b14aea5 100644 --- a/arch/powerpc/platforms/pseries/dlpar.c +++ b/arch/powerpc/platforms/pseries/dlpar.c @@ -272,6 +272,8 @@ int dlpar_detach_node(struct device_node *dn) if (rc) return rc; + of_node_put(dn); + return 0; } -- Frank Rowand