Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 16 Oct 2018 08:30:28 +0200
From:   Greg KH <gregkh@linuxfoundation.org>
To:     Roman Kiryanov <rkir@google.com>
Cc:     linux-kernel@vger.kernel.org, Todd Kjos <tkjos@google.com>
Subject: Re: [PATCH v3 07/15] platform: goldfish: pipe: Return status from
 "deinit" since "remove" does not do much
Message-ID: <20181016063028.GC882@kroah.com>
References: <20181003171720.169953-1-rkir@google.com>
 <20181003171720.169953-7-rkir@google.com>
 <20181015183605.GB28454@kroah.com>
 <CAOGAQeqiWMseXPi6n2gkBHAWhsRdwDyMXpCFB1h2mEuQLJz-mw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAOGAQeqiWMseXPi6n2gkBHAWhsRdwDyMXpCFB1h2mEuQLJz-mw@mail.gmail.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Oct 15, 2018 at 03:04:47PM -0700, Roman Kiryanov wrote:
> > This function can not fail, why are you returning 0 always?  That
> > doesn't make sense.
> 
> remove in struct platform_driver requires returning something, we have
> to have "return" somewhere.

But this code always returns 0, you are changing the function return
value to int, but it can not fail.  I do not understand the need for
this change at all, sorry.

> I think we want to return closer to the place where we do something useful.

I do not understand this.

greg k-h