Received: by 2002:ac0:a582:0:0:0:0:0 with SMTP id m2-v6csp4930434imm; Tue, 16 Oct 2018 02:20:48 -0700 (PDT) X-Google-Smtp-Source: ACcGV60rd8fWZdQCzTdEEvYlKRQZpCKzAuH192PHeTe9TIItY4wif3p0JAk7rwLPq8XUL3e9raVF X-Received: by 2002:a63:3203:: with SMTP id y3-v6mr19588132pgy.101.1539681648658; Tue, 16 Oct 2018 02:20:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1539681648; cv=none; d=google.com; s=arc-20160816; b=0D5LCZdcB5Nw3A9A6KKL6idRI58OYNwF5Gw2nHs7ZBmQDOapwHxf4Dkw9pv5EsWRJi BRaTnUVchRQB7rrXZTZMs3pDuJwF0EIMsLPrbhEQpdxYptu474WvxCxOFYFZHxyS7iog DrvxNFssWilNXuN8NBD4bLSP7f+qRKULQqJmtVmtw0LKozgc85ALCQTWd9QImYkeQiMo 4loqf/uUihGYuNEKuxSoepQukMVPmyLLkHO6SlJKrWP0vsM3T7jvfmJ3vBuFx1ZvS5tu f/KCJ4iv61tsKKyvVIhrFiCmLhtXfdWTnjzRh164mMylfS0inEfQDxjH+IJFN9vOfbsD uIOQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from; bh=sOGhL8krhe+/Au46L4KC22f6W12s4eLC9uOaGMAeo5U=; b=WUM8/PWQ6fkjNO75qZOwnydMrCX3OQnvqeGEfdkFzMtsxFwXkAHh4/jdIlYYN6Qwpi qf95V28vaJG7NgG8BPMmSm8Kap3QRdefiuuPTMMV3eGeXh8Y26Vaad5q7R+iDa4OegW1 LqNgIqVec1+d5jSt3nAJd5HGcQILfVseGG45XOufzrXmabCK9vz49MxfOvZEU6NHul+H 8Ax0CfhLshmd+4PrCgb7LFc2m02QCalj+qG0ROKCeIkl5vUggoXxocxv+1m0JAcg2xZC QWrL5TZ7gqKK1C+CDC1VFk1QUEBqD1odgkwxxGiaZjsgCKP01S1vej3KiX7YyjXlEV4V gNWA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v124-v6si13796245pfv.1.2018.10.16.02.20.33; Tue, 16 Oct 2018 02:20:48 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727237AbeJPRJY (ORCPT + 99 others); Tue, 16 Oct 2018 13:09:24 -0400 Received: from mga14.intel.com ([192.55.52.115]:9417 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727128AbeJPRJY (ORCPT ); Tue, 16 Oct 2018 13:09:24 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 Oct 2018 02:19:54 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,388,1534834800"; d="scan'208";a="78377338" Received: from sgsxdev001.isng.intel.com (HELO localhost) ([10.226.88.11]) by fmsmga007.fm.intel.com with ESMTP; 16 Oct 2018 02:19:52 -0700 From: Songjun Wu To: yixin.zhu@linux.intel.com, chuanhua.lei@linux.intel.com, hauke.mehrtens@intel.com Cc: gregkh@linuxfoundation.org, paul.burton@mips.com, jslaby@suse.com, Songjun Wu , linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org Subject: [RESEND PATCH 03/14] serial: lantiq: Get serial id from dts Date: Tue, 16 Oct 2018 17:19:04 +0800 Message-Id: <20181016091915.19909-4-songjun.wu@linux.intel.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20181016091915.19909-1-songjun.wu@linux.intel.com> References: <20181016091915.19909-1-songjun.wu@linux.intel.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Get serial id from dts, also keep backward compatible when dts is not updated. Signed-off-by: Songjun Wu --- drivers/tty/serial/lantiq.c | 19 +++++++++++++++---- 1 file changed, 15 insertions(+), 4 deletions(-) diff --git a/drivers/tty/serial/lantiq.c b/drivers/tty/serial/lantiq.c index 044128277248..66c671677761 100644 --- a/drivers/tty/serial/lantiq.c +++ b/drivers/tty/serial/lantiq.c @@ -688,7 +688,7 @@ lqasc_probe(struct platform_device *pdev) struct ltq_uart_port *ltq_port; struct uart_port *port; struct resource *mmres, irqres[3]; - int line = 0; + int line; int ret; mmres = platform_get_resource(pdev, IORESOURCE_MEM, 0); @@ -699,9 +699,20 @@ lqasc_probe(struct platform_device *pdev) return -ENODEV; } - /* check if this is the console port */ - if (mmres->start != CPHYSADDR(LTQ_EARLY_ASC)) - line = 1; + /* get serial id */ + line = of_alias_get_id(node, "serial"); + if (line < 0) { + if (IS_ENABLED(CONFIG_LANTIQ)) { + if (mmres->start == CPHYSADDR(LTQ_EARLY_ASC)) + line = 0; + else + line = 1; + } else { + dev_err(&pdev->dev, "failed to get alias id, errno %d\n", + line); + return line; + } + } if (lqasc_port[line]) { dev_err(&pdev->dev, "port %d already allocated\n", line); -- 2.11.0