Received: by 2002:ac0:a582:0:0:0:0:0 with SMTP id m2-v6csp4989382imm; Tue, 16 Oct 2018 03:29:48 -0700 (PDT) X-Google-Smtp-Source: ACcGV60pgpBqcVTZsRFe4TLzTiUdnUg4el71WTvFP7ah3FBuHSeK0MQBAUCi7aX7mZPV23xw3P1e X-Received: by 2002:a17:902:6f16:: with SMTP id w22-v6mr21365339plk.309.1539685787895; Tue, 16 Oct 2018 03:29:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1539685787; cv=none; d=google.com; s=arc-20160816; b=qVSiRhE0n4o0UVIlclWFg3+gmGh0GDdbRo/5B9vHkjpSRLEOx00rzRYMabKvJq1rmv 8fe9KL5uJJ/nZOoVTmnZfAkQfH8mDOUVA2+XEiMgFhAONWy0X5SGgN8UQQrWmGzNSAnX NOhBUIa3EbX+zB92+4p9FxyX/bk1wPmo0iJ9LJ0P35zVZsY9ZxUyQJ8FggqE6EYoEddg mmFNpju0ZKKEwyRknMTCNfz/JuVP24Kk7EBt4XTOR35ScaFlH+MVCWmW10/lZcsRWL7F ztlqBh0fctwPUuDlnL5exXgmKCaNeuuwFKwlre60chsJ0bxj1OSDS4awczp4Cm7dWhp2 9JdA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=gST3x3iapzQiJQPsp1Bg+v21mCKt4kAcIujj/47YLw0=; b=AfmdXfeZNkNK3z6Z7+FrFuaO3xyyCKMrHkCHSDSLw02It/ueu7rQE+PQJ5/oovBDOO R5eb7a6Dc6JCvXjwJM1xwglNkJ3ZTf5cZiQeQqqC+0UO5FRFXCA2uLl8VPoHcMFHHPEp aPxmz5bbBMqjWv6T9XS5K4DbuVRHNwAnbiJcD4GfuUPHZ3YXAxBvNuU+K/BWoXUzXoyJ oKi8fyEd4S3IkRsl1txDdJ9kEiap9cP0JRTVCGkxBeC35z5d8hBxGUs5t9yFx1uvJWWM yaW/UlcGhN5orimGisvstHtZp2/UByNDRMaObfH6pCto3wgWOh3ppXjbb5RoeyCMBObp UtFQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=lDp3KE41; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w11-v6si13250505pgf.587.2018.10.16.03.29.32; Tue, 16 Oct 2018 03:29:47 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=lDp3KE41; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727076AbeJPSRP (ORCPT + 99 others); Tue, 16 Oct 2018 14:17:15 -0400 Received: from heliosphere.sirena.org.uk ([172.104.155.198]:48206 "EHLO heliosphere.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726165AbeJPSRP (ORCPT ); Tue, 16 Oct 2018 14:17:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=gST3x3iapzQiJQPsp1Bg+v21mCKt4kAcIujj/47YLw0=; b=lDp3KE41/ViW1/dt7i6kaknLu kPBo58NaBOC58fVmJfjYvtzFKqB8iI3K5KvVkP8Hwrku+XWC2WQSY5UE3VbPVmMTJPy1TL/wC2LIn zBpzZOu0fF+/lnBHKrGDsqLRXF+hYwVsz/jXfR+zCRiqRz4Jo4aQVB9YjvWo3ToRZQ3V4=; Received: from cpc102320-sgyl38-2-0-cust46.18-2.cable.virginm.net ([82.37.168.47] helo=debutante.sirena.org.uk) by heliosphere.sirena.org.uk with esmtpa (Exim 4.89) (envelope-from ) id 1gCMZI-0004oP-2k; Tue, 16 Oct 2018 10:27:16 +0000 Received: by debutante.sirena.org.uk (Postfix, from userid 1000) id AD1CC11223AA; Tue, 16 Oct 2018 11:27:15 +0100 (BST) Date: Tue, 16 Oct 2018 11:27:15 +0100 From: Mark Brown To: Andrzej Hajda Cc: Greg Kroah-Hartman , Bartlomiej Zolnierkiewicz , Marek Szyprowski , "Rafael J. Wysocki" , linux-kernel@vger.kernel.org, Javier Martinez Canillas , linux-arm-kernel@lists.infradead.org, andy.shevchenko@gmail.com Subject: Re: [PATCH 1/3] driver core: add probe_err log helper Message-ID: <20181016102715.GD7449@sirena.org.uk> References: <20181016072244.1216-1-a.hajda@samsung.com> <20181016072244.1216-2-a.hajda@samsung.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="LKTjZJSUETSlgu2t" Content-Disposition: inline In-Reply-To: <20181016072244.1216-2-a.hajda@samsung.com> X-Cookie: Huh? User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --LKTjZJSUETSlgu2t Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Oct 16, 2018 at 09:22:42AM +0200, Andrzej Hajda wrote: > +int probe_err(const struct device *dev, int err, const char *fmt, ...) > +{ > + struct va_format vaf; > + va_list args; ... > + return err; > +} > + This will need an EXPORT_SYMBOL for modules won't it? --LKTjZJSUETSlgu2t Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAlvFvQAACgkQJNaLcl1U h9CinAf/TrDYBAP2p7l6s02TaGVagy5SrYDDXZoa+tlwnAxkQnbOBif/mtOyhFzL uQf9am3fX2kIMiYkFxcreLeTVImmox0BI3G+JgtQXd2CiXxOWeIsonFye11TYXbg EWpjHSWUDe5oPIRLK41U5gjUcZf3DwCheZs+sOc3AifXp6bScWHNc3OdQvzC3zlw il+fMS9PKV6qyxL5ubque2N3tI6nrUA442MLzNG+am5gO3oP68JXK54ZyICmAW6S wnJi6z49WV59/xzPUMnEEufxVNpqyrBUMQx4l3zgC+2sACawiSDOWAw+AcUruCRW mUFxD5X24EQoW6STRjKpEAafQlXs9A== =C834 -----END PGP SIGNATURE----- --LKTjZJSUETSlgu2t--