Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 16 Oct 2018 12:51:03 +0200
From:   Thierry Reding <thierry.reding@gmail.com>
To:     Atish Patra <atish.patra@wdc.com>
Cc:     Wesley Terpstra <wesley@sifive.com>, palmer@sifive.com,
        linux-riscv@lists.infradead.org, linux-pwm@vger.kernel.org,
        linux-gpio@vger.kernel.org, linus.walleij@linaro.org,
        robh+dt@kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, mark.rutland@arm.com,
        hch@infradead.org
Subject: Re: [RFC 1/4] pwm: sifive: Add DT documentation for SiFive PWM
 Controller.
Message-ID: <20181016105103.GB8852@ulmo>
References: <1539111085-25502-1-git-send-email-atish.patra@wdc.com>
 <1539111085-25502-2-git-send-email-atish.patra@wdc.com>
 <20181010135109.GE21134@ulmo>
 <ef19e79a-d975-bde4-1692-65389ead7c15@wdc.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="XF85m9dhOBO43t/C"
Content-Disposition: inline
In-Reply-To: <ef19e79a-d975-bde4-1692-65389ead7c15@wdc.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--XF85m9dhOBO43t/C
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Oct 15, 2018 at 03:45:46PM -0700, Atish Patra wrote:
> On 10/10/18 6:51 AM, Thierry Reding wrote:
> > On Tue, Oct 09, 2018 at 11:51:22AM -0700, Atish Patra wrote:
> > [...]
> > > +- interrupts: one interrupt per PWM channel (currently unused in the=
 driver)
> >=20
> > This should probably say what the interrupt is used for. And once you
> > have that, remove the comment about it being unused in the driver. DT
> > is OS agnostic, so "driver" is very unspecific and your claim may
> > actually be false.
> >=20
> > Thierry
> >=20
> As per my understanding, they are generated by hardware but no usage of p=
wm
> interrupts as of now.

It might be useful to say when they are generated. Are they generated
once per period? At the beginning or the end of the period? That kind
of thing.

> I am not sure if removing the entire entry is a good idea.
> What would be the best way to represent that information ?
>=20
> May be this ?
>=20
> +-interrupts: one interrupt per PWM channel. No usage in HiFive Unleashed
> SoC.

Why do you think you need to say that they are unused? If the hardware
generates these interrupts, then they are "used". If no driver currently
has a use for them, that's driver specific and doesn't belong in the DT
bindings.

Thierry

--XF85m9dhOBO43t/C
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAlvFwpcACgkQ3SOs138+
s6GQiQ//cUGJvtTzXfrt/nIdB6bUI2UeshHcJ0hyljO7U2HxZlpf8Du+EPvio9qJ
8Y5SiGyZ1McNwiKhIzk1cw4riC8ezQdCpjlvx9EKumzHSsrBm1IFrg8nm9yb8W1a
T918g96hSfN3uiSPJuVqg/uK41kO0ZHuY12Az+a5U0LAdoN5fx9H9eoWOjRzIOG/
lfZ+afy6GIC94imlKbUjYKhYihTRw7+Xvg1XIVcmNVKSCp8Peyrz6/Pvt34796gj
z4Us9bKUw3P2Z7Iqfn4b9LDKj5ap/pxMdwCd77hFx2UXKJlukVJjQbRsVAAxUi3/
2iSNTvT73JT6E6xoOcqKS8tJs91nWtbkHY44sFar9iy/fiqH59JcdV+r7f2EzH5g
2T8bkSGFw1IBW16QrJbWEqPNW45adFFZTju7kAjYdM9NcMGaoNZ1fxLxw0g+aD8Z
tC7zFStY1MOWNFsOHnUckDTaQp5twZvz5+MvQECU+XbKswcovGstIkNgXe+p+tNP
dL2Tl1UlH8LIjzopB/LwQ1Re+fjMlq+L+uuWCdKkzl4OkY6RgXtdm5kfbqIsGh6m
7XPU8OmUkUlMelHt372Tx/cjEaqLaYyBxtyunydIGaTGGdF8W+WMAw729IUMCQAH
9mBkVv4I+N1XvvZwN1d9RNbQmZoTWa/IBHxuAxVQ5VE/UEGUoBQ=
=f7GF
-----END PGP SIGNATURE-----

--XF85m9dhOBO43t/C--