Received: by 2002:ac0:a582:0:0:0:0:0 with SMTP id m2-v6csp5059029imm; Tue, 16 Oct 2018 04:40:45 -0700 (PDT) X-Google-Smtp-Source: ACcGV61NZxtNzZn9J8jZrOjRhiYrN8tcEYANKFZ5ozllkKoWSKgse2QJGEpiEoMM8YFpu/hhp9XB X-Received: by 2002:a17:902:650f:: with SMTP id b15-v6mr18748257plk.2.1539690045516; Tue, 16 Oct 2018 04:40:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1539690045; cv=none; d=google.com; s=arc-20160816; b=uqMwRcEcV4H9OnUEg1c1IryH6fP2vEsnp3NBPY8HxfawpuRwI461NLfnqDnhF029J7 wmo/jwXuPo0oIH0fx06iUis0KphZjnWf1NAJsXD+JaQ/WbKT9ULcGPsEIWQe5sXn4CEh NzYj7rH/4PSgckNTM6upa6iCxo60TYZqhIiPqr/o2gaZJBoMi3GT4GZfC8cXhIxja8mB k3mvrc/xd9FFbgvvAuHFMArNWrMRuhKOqLDp6NrOphjjQo3Hhhz7oIE0WxD50kkEMbVS cC2SpBjj4BpH8vN6LPS3ryRCOoEUQxD5rBTjLXllXrGTc6rfyVpdJ45i/9CzCsW8oVgI ytYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=QY6/77tGmeoO7EWU/YBGghkEkV3ka33BhhxnII+8mqY=; b=DFoeNog2+DC5p5s+VU19sejiFBARMpV9M7MJSSw01XWVdvA0aFyLIotvs6Fz66Sj8A QtrUDfqr69AZZvCKtVv9zWSuI+ZS65E7LcaoWwiNNtwHAqBsGdGrdZXOLntjWW+PuH7K z690apSttzOTakUJdSYYjqbgNtQcOIaSkRe8GzIGVnOnqJkfS/9wr/AkeowxNEVAmhuz OYrfK3kT9VKY2vLavmxB9oW0SJP5jkyA/Gk3lHvcIutU0EkLMkT32U4Jgo1AiESypTFc AmvuPG3Gqy9U9yFJXqY2V93pp6zFn2xx/ucuq6JTozW/3lbg36K17GFcOfNmjkdMRmON EMbA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d4-v6si13418974pgj.341.2018.10.16.04.40.29; Tue, 16 Oct 2018 04:40:45 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727093AbeJPTaD (ORCPT + 99 others); Tue, 16 Oct 2018 15:30:03 -0400 Received: from mx2.suse.de ([195.135.220.15]:39748 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726711AbeJPTaC (ORCPT ); Tue, 16 Oct 2018 15:30:02 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 70AA1ACB7; Tue, 16 Oct 2018 11:39:58 +0000 (UTC) From: Thomas Renninger To: Konstantin Khlebnikov Cc: Shuah Khan , linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, rafael@kernel.org Subject: Re: [PATCH] tools/power/cpupower: fix compilation with STATIC=true Date: Tue, 16 Oct 2018 13:39:57 +0200 Message-ID: <2028892.8FmI4CMcI5@house> In-Reply-To: <153968018626.397151.17942194042449956995.stgit@buzz> References: <153968018626.397151.17942194042449956995.stgit@buzz> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday, October 16, 2018 10:56:26 AM CEST Konstantin Khlebnikov wrote: > Rename duplicate sysfs_read_file into cpupower_read_sysfs and fix linking. > > Signed-off-by: Konstantin Khlebnikov Acked-by: Thomas Renninger Thanks! > - $(OUTPUT)../lib/cpufreq.o $(OUTPUT)../lib/sysfs.o > + $(OUTPUT)../lib/cpufreq.o $(OUTPUT)../lib/cpupower.o I also looked at this and would only have fixed half of it (overseeing above old leftover from cpupower lib introduction). I guess, this patch from Konstantin is better and the correct solution.