Received: by 2002:ac0:a582:0:0:0:0:0 with SMTP id m2-v6csp5085420imm; Tue, 16 Oct 2018 05:05:52 -0700 (PDT) X-Google-Smtp-Source: ACcGV60ik3gf/zHUGh8CVtqf9ue/4ag+SaCtbAsn2UGeQd0qb+qygNNXyw/O1CAsba1GVdy4NLDC X-Received: by 2002:a63:9f0a:: with SMTP id g10-v6mr19121657pge.232.1539691552609; Tue, 16 Oct 2018 05:05:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1539691552; cv=none; d=google.com; s=arc-20160816; b=Vf4deIrQglK+2qX18OMEiVZg5L9bKCdebZ9DhEC/broswE/hcPKd7jX1L+KTWc9cEm +wjGUshdgAuXaVk4iP7WEgWnVDrP7BZeynI+DX6L/VrOxUahlu7GmKsB0dTvRn38W78t l38ZW6Jtql3EpR1HbYKdjipB7x/U287vNKAD8OR2Os1hkwhekOSj5pCpf9+rdxycVIXb IT2nxgVR7n8aKlUFN0+v3h1/Laj961kMRwehORWF4ffK+bLifl4hvmpPHiKdnPi9uysd p6QDQbYPn5A0lNg/RfAJTA4OyqVG+ggV/IGr4hKzEA4K2SArJb8ZEsSaQwSaUX47CY5Z eZDQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date; bh=ng0Xf1la+Xi8yvLgg+NZcpXZLhLgoFBay4VyX0Y/6IA=; b=lch41/ARTWyiNh/jfiS4pL5fDnk8mnd1s/4WKcoxGhEACsLrnuksv+jrm2OfsSE0gE tye6d+ST6Rus6IfwvMuL9eljDUQWjKz3w7LFjFxyZ19MNehgcz7T6lTGkKiHBfcjL3XW cCm8eLlee0yxVzczZ/xu/10hmy1Abx6qyD9vN9lA2+qcyNabcBCMtZbnY2VDZVeQuD1X gpVGTQj3jLnuag9acExY1ncPfCKJ6PCHmwT3ZBwYDNrUXTZMiXPzFnM0oOrfEdmNofde 40a631GxNjalVV0/valUTxK6G2nqn0y8vwWD9gWe28HUSMmHD6BJRrEOIHdPnu8CZu+o Nbrg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d8-v6si13528666pfn.99.2018.10.16.05.05.36; Tue, 16 Oct 2018 05:05:52 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727266AbeJPTym (ORCPT + 99 others); Tue, 16 Oct 2018 15:54:42 -0400 Received: from mail.bootlin.com ([62.4.15.54]:44404 "EHLO mail.bootlin.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727084AbeJPTym (ORCPT ); Tue, 16 Oct 2018 15:54:42 -0400 Received: by mail.bootlin.com (Postfix, from userid 110) id 4B3832079D; Tue, 16 Oct 2018 14:04:30 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mail.bootlin.com X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT, URIBL_BLOCKED shortcircuit=ham autolearn=disabled version=3.4.0 Received: from bbrezillon (AAubervilliers-681-1-7-245.w90-88.abo.wanadoo.fr [90.88.129.245]) by mail.bootlin.com (Postfix) with ESMTPSA id AF60E20DCD; Tue, 16 Oct 2018 14:04:10 +0200 (CEST) Date: Tue, 16 Oct 2018 14:04:11 +0200 From: Boris Brezillon To: Yogesh Narayan Gaur Cc: Tudor Ambarus , "marek.vasut@gmail.com" , "dwmw2@infradead.org" , "computersforpeace@gmail.com" , "richard@nod.at" , "linux-kernel@vger.kernel.org" , "nicolas.ferre@microchip.com" , "cyrille.pitchen@microchip.com" , "linux-mtd@lists.infradead.org" , "linux-arm-kernel@lists.infradead.org" , "Cristian.Birsan@microchip.com" Subject: Re: [PATCH v3 1/2] mtd: spi-nor: add support to non-uniform SFDP SPI NOR flash memories Message-ID: <20181016140411.3f06e449@bbrezillon> In-Reply-To: References: <20180911154007.17195-1-tudor.ambarus@microchip.com> <20180911154007.17195-2-tudor.ambarus@microchip.com> X-Mailer: Claws Mail 3.15.0-dirty (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 16 Oct 2018 09:51:47 +0000 Yogesh Narayan Gaur wrote: > Hi Tudor, > > This patch is breaking the 1-4-4 Read protocol for the spansion flash "s25fl512s". > > Without this patch read request command for Quad mode, 4-byte enable, is coming as 0xEC i.e. SPINOR_OP_READ_1_4_4_4B. > But after applying this patch, read request command for Quad mode is coming as 0x6C i.e. SPINOR_OP_READ_1_1_4_4B. > > This flash also supports non-uniform erase. > Can you please check and provide some suggestion? Are you sure the regression comes from this patch? I suspect your bug comes from 41fe242979e4 ("mtd: spi-nor: fsl-quadspi: fix read error for flash size larger than 16MB").