Received: by 2002:ac0:a582:0:0:0:0:0 with SMTP id m2-v6csp5250610imm; Tue, 16 Oct 2018 07:29:59 -0700 (PDT) X-Google-Smtp-Source: ACcGV62CwB20zb4kCNWKVD/NRDFXO3ITVkTvZBMlqYj/uaxTjX1CQsEoRn9C/lqBnwdrYgOTbxBW X-Received: by 2002:a63:69c9:: with SMTP id e192-v6mr20690456pgc.143.1539700199248; Tue, 16 Oct 2018 07:29:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1539700199; cv=none; d=google.com; s=arc-20160816; b=nL7pR7SmDlslxrrhOFjyIvutnQWSr/xGI6H8zfAP4D/3ULNrmqN38njKSvIpRCuDZT RqUdxyeU9IKLcpszofIQRvV4GDB3sLvCVxslNPcgdeqYyV12CeIeT+XcjGGgOyWCM8jF JuBlaNVULzcC+XJ+E0WWI/UdFCi3Z7t+9aHk7T2UhiW3R5Kr6T/caHT6/7BU8+VcH1RP ZIizl6Pseqe0kY9UybDYaiAgwLr6xfj43oLv5qT4XqlfvPeTYjaCae0UW7xaIL5iI5yx gx/A6xzqM3c3UTpFZLuGlIJTEc4mNxrclPuP7Ungnvs8cmeBK1+INY7X5rhwLkApOOGd xjNw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=XUqt1iyOhjl9RAzm/nCZhpxWDCL3f2vuV5wSg7/jpO4=; b=pBDCZPGZ0fzpW9voZQauXwSRk8bvRYPBXTDYAxtoB0x+dz8cU4r61gMyYIxGXZevgL YAATx5yvaRVrBzjnDmCX7SMWjW0A4zZt5tmJGSnncOUuzH2eWr9Ge5odO4vjI9DYJiUP tRWlh8rYffOFEn8CuQ9FbM89S4Dt4i/1u4zTH3BUMzd1ph46I0/eSTrpTI2B8KG7F0cy IGGM/UnHknx02cdYXs4wvZN6cXoNHI8QgTzpx71S19uP52F84nldv0N6HZFbh4tpnG8/ KJv/1iPu76nyNJYi6QiOXLio/dYSsw84hAAfRG6M0HzG51iIJu4MPgJMAHLze6TLy5BZ 9U9A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t10-v6si14490251pfc.129.2018.10.16.07.29.42; Tue, 16 Oct 2018 07:29:59 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727076AbeJPWTp (ORCPT + 99 others); Tue, 16 Oct 2018 18:19:45 -0400 Received: from mailout.easymail.ca ([64.68.200.34]:59344 "EHLO mailout.easymail.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726760AbeJPWTp (ORCPT ); Tue, 16 Oct 2018 18:19:45 -0400 Received: from localhost (localhost [127.0.0.1]) by mailout.easymail.ca (Postfix) with ESMTP id 623A440CB0; Tue, 16 Oct 2018 14:29:01 +0000 (UTC) Received: from mailout.easymail.ca ([127.0.0.1]) by localhost (emo03-pco.easydns.vpn [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Olq4BHJR8aFl; Tue, 16 Oct 2018 14:29:01 +0000 (UTC) Received: from [192.168.1.87] (c-24-9-64-241.hsd1.co.comcast.net [24.9.64.241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mailout.easymail.ca (Postfix) with ESMTPSA id EA73E40C38; Tue, 16 Oct 2018 14:28:53 +0000 (UTC) Subject: Re: [PATCH] tools/power/cpupower: fix compilation with STATIC=true To: Thomas Renninger , Konstantin Khlebnikov Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, rafael@kernel.org, Shuah Khan References: <153968018626.397151.17942194042449956995.stgit@buzz> <2028892.8FmI4CMcI5@house> From: Shuah Khan Message-ID: <4a4cb4dc-16d7-7f71-eb99-d4b1e7788862@kernel.org> Date: Tue, 16 Oct 2018 08:28:47 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <2028892.8FmI4CMcI5@house> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/16/2018 05:39 AM, Thomas Renninger wrote: > On Tuesday, October 16, 2018 10:56:26 AM CEST Konstantin Khlebnikov wrote: >> Rename duplicate sysfs_read_file into cpupower_read_sysfs and fix linking. >> >> Signed-off-by: Konstantin Khlebnikov > > Acked-by: Thomas Renninger > > Thanks! > >> - $(OUTPUT)../lib/cpufreq.o $(OUTPUT)../lib/sysfs.o >> + $(OUTPUT)../lib/cpufreq.o $(OUTPUT)../lib/cpupower.o > > I also looked at this and would only have fixed half of it (overseeing above > old leftover from cpupower lib introduction). > I guess, this patch from Konstantin is better and the correct solution. > Thank you both. I will get this into 4.20-rc1 or rc2 depending on how timing works. I think this applies to stable as well. thanks, -- Shuah