Received: by 2002:ac0:a582:0:0:0:0:0 with SMTP id m2-v6csp5270300imm; Tue, 16 Oct 2018 07:47:47 -0700 (PDT) X-Google-Smtp-Source: ACcGV63KStVWECon96WJCHfkj39alT7zp5+xSAYUC1eLbaxWWnSlSYf7+bW+/CbNbava7W2+zpo1 X-Received: by 2002:a63:3cc:: with SMTP id 195-v6mr20567508pgd.262.1539701267054; Tue, 16 Oct 2018 07:47:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1539701267; cv=none; d=google.com; s=arc-20160816; b=OVP1EZVcr38hqmJ+k/YDuKEYdR2vq92Eg1/LUDOJtkkydYSiL/gqRxRat7nFb2jn0n qOTScCTaYkBTSEQLD0hn1aiWEhlu2yvEdUd/fOqkRnkot8SfcrPw16jHsQGIJwEBvZDO jd8QukPmenscsk1YXGk4HnOeKuopnlw6eFUQJ0b6olFBwDWs6SC13cjtjvte5yoMd3p3 exAERMhJlehDTWxw3yh09LY0mY3jzAR9uep9/s1KtYnSdc8Qk2Yu65k6jhC90nyFumat HVLoAS1XYyOziL5N/Xq4dOCi4wqkk31O42onpRROXs3IOwCi7iCwLIu4rrZ4s4/hzGR5 kS1w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:to:subject:dkim-signature; bh=EjXo5QGpKawGStlNQE4itapExiS6VjB4JIjFjFQnM7s=; b=hOVnFqzvMjm8hC4Ij6M1MNjp4WjjvQQVxFpTv4MoG0mbLFcg3NZAUEwgG+wGlFFkgL Uwp6bAWOQR6DjbMgVwOmQpEpY3h1q5Dx1+WPVIMI5kWDkiYZQxAbdKuOCsfUxCZnS9p1 VWQhJjYYInwOx+FKXMhFrDXaoJnChT9pu/KLD+4mYQ9+2vNND/hPCDhG66D5WyLoSKXG 8g60jlYyjcPO619qrRikq4u7tK+vhUnX9tBd7EG3hysTqt3amn9g1muBUrZKXq5Fow42 t4jAlA16aAhXgjaDmDVtHqbl8m4lx7fMNbU53VwNDBC+L8Z+Q3Dt5JGAUk5YvcVsuesJ 00qw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=C8UUzVHt; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t62-v6si15031939pfj.53.2018.10.16.07.47.30; Tue, 16 Oct 2018 07:47:47 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=C8UUzVHt; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727180AbeJPWfw (ORCPT + 99 others); Tue, 16 Oct 2018 18:35:52 -0400 Received: from mail-it1-f181.google.com ([209.85.166.181]:50921 "EHLO mail-it1-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726778AbeJPWfw (ORCPT ); Tue, 16 Oct 2018 18:35:52 -0400 Received: by mail-it1-f181.google.com with SMTP id k206-v6so27356543ite.0 for ; Tue, 16 Oct 2018 07:45:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=EjXo5QGpKawGStlNQE4itapExiS6VjB4JIjFjFQnM7s=; b=C8UUzVHtr2GYiEkrdTHcO1rAGNeB3ezVeAbgxmfCPVKYlcO/uuAuUzNuS1qAxoRbmr VnpilIHuDY6UQ1s6BLJmhz52W4gyDmrQfy7wEx86Zx/daff1cwRsJnKF1s18xzmIQZBn EyKucu3FDJOHPPY73WfAxllMRxvoSNQ4aSqnb61Qge0by4+q1pWr9wDD03ce7LeuL3c+ yE0tZCCGmN4CY1tgxsS4bRkScK2OECMZ2k7qyEqTIRLSkwMgvvB2BihFWtS/IzbQnz2f 0F632j+QZIVXInP44AQzISUyErg6nxSHJG3zHHG0qZT1Twh3YK29dAd9odno6zGClr9q heHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=EjXo5QGpKawGStlNQE4itapExiS6VjB4JIjFjFQnM7s=; b=NOGAI5oTrAHblKvYsGZm8AFIWC+tNs5+wwqwJuMdBucKx+EkHZpH/fWb5x4+FzKUMB MPyfm2AISHqSd7C3JkRBTx3Vo3VxU5AtC+n+hhw+G4K3LYinHm+iL0rgAoj7QOh2EvW7 qsphwuFoQslIZLTNptKlRa0zJHZ/oVmwk9egCkiFoMRiK4xp8fs1k6NA9rz1w2pgg9RF SRkkYOeGGjeAyI02rjTCcAOwPqevqSUdQdH4t8/2QCw4WfnDCMR7HKs6G7R+Xeq2V3Bo R5NToAPAP1212Czt+To99UWgzYKZKIFClJoSIgU3nf4L52EqvEIfU+pjhvc+k8lBzN75 p6zw== X-Gm-Message-State: ABuFfohRKfNLpn+5N15OTnWRmNPT81XQdPPEYAp57z9CE/POKzTerfpi Jv6oY5CTCZ/kyy5joTXyJlaC+M+Asd0= X-Received: by 2002:a24:1cc7:: with SMTP id c190-v6mr17624522itc.30.1539701104407; Tue, 16 Oct 2018 07:45:04 -0700 (PDT) Received: from [192.168.1.56] ([216.160.245.98]) by smtp.gmail.com with ESMTPSA id k6-v6sm3124766iom.45.2018.10.16.07.45.02 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 16 Oct 2018 07:45:02 -0700 (PDT) Subject: Re: [PATCH] block: fix comments about choosing request list To: Konstantin Khlebnikov , linux-kernel@vger.kernel.org References: <153968002141.396220.12979757828960821275.stgit@buzz> From: Jens Axboe Message-ID: <5f5b7f16-b4cd-7c8f-519f-7ddbbea1ba41@kernel.dk> Date: Tue, 16 Oct 2018 08:45:01 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <153968002141.396220.12979757828960821275.stgit@buzz> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/16/18 2:53 AM, Konstantin Khlebnikov wrote: > Request list is determined by blk_get_rl() and without queue_lock. This code is going away shortly, so let's just leave the comment alone. -- Jens Axboe