Received: by 2002:ac0:a582:0:0:0:0:0 with SMTP id m2-v6csp5283342imm; Tue, 16 Oct 2018 08:00:07 -0700 (PDT) X-Google-Smtp-Source: ACcGV61Itt6zUiitUdsa5/NOxNBFyhD48fzXtyqQWrIWjs/euFiTp2N2DIXXwyvvG+NSQbGVecqM X-Received: by 2002:a63:9c01:: with SMTP id f1-v6mr20028644pge.156.1539702007430; Tue, 16 Oct 2018 08:00:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1539702007; cv=none; d=google.com; s=arc-20160816; b=gq9+s75e+zV3ihsiP7714RAC3HeVPINcV7hAbXGV9GUf5IoiJ4+UA2abjzMGuXC+z8 mm6FqhDjFhEMxGGtjexOMpfQR2DO2k80qA7tn9wZyZrGrNyZ6wudw4UV4IlxEfQ0j0io XjaoqIBPGRXq1iI2QpKhPWJkpKHo7gPy9V0ax0m9SSKiYotR0FkLlvehWE7a45QOO6a3 umgrURTL8DVVFR3NMK6AY3aCDWkILtL1/iM/LTAFHHktkgw+0ybuUWSZhS5oMyDk8jGl iQOxm6kaJveFLG5fciMYfMTrr4pyYZ8nzbtAvV7r5HF51W5vyfRe7ozu4ApALK/DK7gb nE4g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:to:subject:dkim-signature:dkim-signature; bh=hlnFOxPwoDqJsWeipAEabaxemXSxlGGeraQyhuJY9c8=; b=NK1pyN+Jp13fCmAIzKI+rigYLXgAgr40y5HzCW2TA+q8JXcDQTIoQaNvQxLlTvV6p8 I67ZuANORolBqEAMhpO8uiyXNHcst0X4GRTrNiH8eYsNy97GtgcJmRY/xbHrl4JzYgDq k4yhxHu4OBGdvCOy7gqQilDqbp8KaplAXo//h9Ue/KnyyANkQ1pxSIe2NxBKar5H2weR 2lU9pakdByORtsoQLh0XLPNBvTiBXZdEQVYJ+0oHdloR+UrzM/Eq/kUCYr9McH1ycCkP yfYwZWD7K50KBnWcz+pbygNeC1/j31HsiKq02fq3b9vI9PY8+l0jPyhnVYhgadLiTu9A M/fA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@yandex-team.ru header.s=default header.b=w1KEz+jt; dkim=pass header.i=@yandex-team.ru header.s=default header.b=zTd8RzEy; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=yandex-team.ru Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 32-v6si5328870plg.241.2018.10.16.07.59.50; Tue, 16 Oct 2018 08:00:07 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@yandex-team.ru header.s=default header.b=w1KEz+jt; dkim=pass header.i=@yandex-team.ru header.s=default header.b=zTd8RzEy; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=yandex-team.ru Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727474AbeJPWuD (ORCPT + 99 others); Tue, 16 Oct 2018 18:50:03 -0400 Received: from forwardcorp1g.cmail.yandex.net ([87.250.241.190]:60281 "EHLO forwardcorp1g.cmail.yandex.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727026AbeJPWuC (ORCPT ); Tue, 16 Oct 2018 18:50:02 -0400 Received: from mxbackcorp1g.mail.yandex.net (mxbackcorp1g.mail.yandex.net [IPv6:2a02:6b8:0:1402::301]) by forwardcorp1g.cmail.yandex.net (Yandex) with ESMTP id 0B27F21AFA; Tue, 16 Oct 2018 17:59:10 +0300 (MSK) Received: from smtpcorp1p.mail.yandex.net (smtpcorp1p.mail.yandex.net [2a02:6b8:0:1472:2741:0:8b6:10]) by mxbackcorp1g.mail.yandex.net (nwsmtp/Yandex) with ESMTP id SUd5SlX1iD-x9lGAeRb; Tue, 16 Oct 2018 17:59:10 +0300 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex-team.ru; s=default; t=1539701950; bh=hlnFOxPwoDqJsWeipAEabaxemXSxlGGeraQyhuJY9c8=; h=Subject:To:References:From:Message-ID:Date:In-Reply-To; b=w1KEz+jtwCjzYADGQVSANPA5Wbn4zpyQ9us4H9cAml5MnKD35mWPhzxOP3DfYjqtk 7AB/rnCHpjmp/D5xRj1hZ8bjLkMYuHEsuw9zAtWzhQ5MaHdIk9QLw+lIUcg1rL9bZ7 C2qZleg+Kwdtr77eFzdrkwT5MZpVXi27aOOyO2hk= Received: from dynamic-vpn.dhcp.yndx.net (dynamic-vpn.dhcp.yndx.net [2a02:6b8:b010:d007::1:95]) by smtpcorp1p.mail.yandex.net (nwsmtp/Yandex) with ESMTPSA id SQvn0sggDJ-x9WauGYH; Tue, 16 Oct 2018 17:59:09 +0300 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client certificate not present) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex-team.ru; s=default; t=1539701949; bh=hlnFOxPwoDqJsWeipAEabaxemXSxlGGeraQyhuJY9c8=; h=Subject:To:References:From:Message-ID:Date:In-Reply-To; b=zTd8RzEyjPYZNXPyDoh6MKcr3yJYRQhvl5iVTMVOrJn0aF93dVqdjqY2YC/K7Oj/h Su42yjUZDZ146hSPBOdbyxwUtcOIqJ5f6y61bRAafZsSLSaemmw6vCpqK3fLli+oNG 53xBN/9JGwHk9c9cPNzRt8SmE4mqnE8cZGla4rnI= Authentication-Results: smtpcorp1p.mail.yandex.net; dkim=pass header.i=@yandex-team.ru Subject: Re: [PATCH] block: fix comments about choosing request list To: Jens Axboe , linux-kernel@vger.kernel.org References: <153968002141.396220.12979757828960821275.stgit@buzz> <5f5b7f16-b4cd-7c8f-519f-7ddbbea1ba41@kernel.dk> From: Konstantin Khlebnikov Message-ID: Date: Tue, 16 Oct 2018 17:59:06 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <5f5b7f16-b4cd-7c8f-519f-7ddbbea1ba41@kernel.dk> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-CA Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 16.10.2018 17:45, Jens Axboe wrote: > On 10/16/18 2:53 AM, Konstantin Khlebnikov wrote: >> Request list is determined by blk_get_rl() and without queue_lock. > > This code is going away shortly, so let's just leave the comment > alone. > Ok, I see some patches in flight for 420 Probably they also fixes linking non-bio based request with cgroups? I've found that old stack calls blk_rq_set_rl() for all request while MQ do this only in blk_mq_bio_to_request, in blk_mq_get_request() request gets only io-context.