Received: by 2002:ac0:a582:0:0:0:0:0 with SMTP id m2-v6csp5292769imm; Tue, 16 Oct 2018 08:06:57 -0700 (PDT) X-Google-Smtp-Source: ACcGV61AZAzfgZn5st/Dwoi9D+j1Zy5/5Z/HGIApNB0R/QE838YS4SqgmE+sm8NNcWpxCQIYBcGZ X-Received: by 2002:a17:902:8690:: with SMTP id g16-v6mr21099212plo.302.1539702417258; Tue, 16 Oct 2018 08:06:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1539702417; cv=none; d=google.com; s=arc-20160816; b=qDKiSXxbWFUghf3UVRv4P1/qioLeiV8bdJMpAMN0XVBitiWO/CU4uaE4OiDqHGH84N Gbm7epxqVuM53qxO/qLbZ+3QrsSi41Z9kD1GKAFSgdN9ERSt0KMrUQSTOJMvlgttZf/F hApo5LF+ZqYT2heODNFCMpmyLIEpQzh9U302zJsG7GVnLzqvPnC6hnJ3Knx9hWus9CFC jHnNHuwcdd2cuF7sLfSxxJo1jX2i5YSR9/HFwSoNIm287FbxJDQpuY/Q+ypCHfhNXSwP 9WfeSkYjY0Rq9eCOtTviaDX6bVTgaEzCUtBTDrs0ojtwJRBgvHGFI8t9dPfEarW5CJXK iOiQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=GYn+y9mzfjXVxEDoWxcIRHW23hnPLSGwUJzS9lm6fmo=; b=bl5oYXosFzffnys1H2in2F4IyebbAeRUCRPjZ3D2If78W3k+zMptBG/DanE8TYA67Z y2VjHtpSUxviZCxvTmGhbP6FZTrLrsXHnQDwgb/ZoWUiHaOafT0qERporNFaTNTEZeWn so4Ioqs8ioPhnclvjC0MFYFargRp+s8g0G/Zm1YqvEwCmsqZwUmmazcTNNwqKowVQ1rN Btd4C/di4SJSAJcHDHvz04BenxuxczHupeF4PCc3L9PrySaNKrlDTSSUOFQpAmalx60G UuGlg6kz2eXs6fhZnW839hC5T76es1lRqTKW+cNTrBKenoTQaolaHTm7mEZUo88SdHvg b3Cg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o9-v6si9820535pll.325.2018.10.16.08.06.37; Tue, 16 Oct 2018 08:06:57 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727178AbeJPWys (ORCPT + 99 others); Tue, 16 Oct 2018 18:54:48 -0400 Received: from mx2.suse.de ([195.135.220.15]:55620 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726760AbeJPWys (ORCPT ); Tue, 16 Oct 2018 18:54:48 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 25C46AF68; Tue, 16 Oct 2018 15:03:55 +0000 (UTC) From: Nicolas Saenz Julienne To: gregkh@linuxfoundation.org Cc: eric@anholt.net, stefan.wahren@i2se.com, linux-rpi-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, robh+dt@kernel.org, tiwai@suse.de, nsaenzjulienne@suse.de Subject: [PATCH 0/9] staging: bcm2835-audio: Cleanups and upgrades Date: Tue, 16 Oct 2018 17:02:19 +0200 Message-Id: <20181016150228.16994-1-nsaenzjulienne@suse.de> X-Mailer: git-send-email 2.19.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, I just received a RPi3B+ and decided to have a go at fixing stuff in the audio driver: The first half of the patchset are just random fixes found while reading the code. The second half provides devicetree bindings for bcm2835-audio and fixes the probe sequence so it fails gracefully if VCHIQ isn't there (as per TODO). The series was developed on top of linux-next and tested on a RPi2B and RPi3B+. Sadly I don't have an HDMI monitor with sound so I only tested the mini jack output. Thanks, Nicolas === Nicolas Saenz Julienne (9): staging: bcm2835-audio: unify FOURCC command definitions staging: bcm2835-audio: don't initialize memory twice staging: bcm2835-audio: reorder variable declarations & remove trivial comments staging: bcm2835-audio: use anonymous union in struct vc_audio_msg staging: bcm2835-audio: more generic probe function name ASoC: dt-bindings: bcm2835-rpi: add onboard audio bindings ARM: dts: bcm2835-rpi: add onboard audio device staging: vchiq_arm: add function to check if probe was successful staging: bcm2835-audio: check for VCHIQ during probe .../bindings/sound/brcm,bcm2835-audio.txt | 15 +++++++ arch/arm/boot/dts/bcm2835-rpi.dtsi | 5 +++ .../vc04_services/bcm2835-audio/bcm2835-pcm.c | 10 +---- .../bcm2835-audio/bcm2835-vchiq.c | 39 ++++++++----------- .../vc04_services/bcm2835-audio/bcm2835.c | 30 ++++++++------ .../bcm2835-audio/vc_vchi_audioserv_defs.h | 6 ++- .../vc04_services/interface/vchi/vchi.h | 3 ++ .../interface/vchiq_arm/vchiq_2835_arm.c | 2 + .../interface/vchiq_arm/vchiq_arm.c | 16 ++++++++ .../interface/vchiq_arm/vchiq_arm.h | 1 + .../interface/vchiq_arm/vchiq_if.h | 4 ++ .../interface/vchiq_arm/vchiq_shim.c | 7 ++++ 12 files changed, 95 insertions(+), 43 deletions(-) create mode 100644 Documentation/devicetree/bindings/sound/brcm,bcm2835-audio.txt -- 2.19.1