Received: by 2002:ac0:a582:0:0:0:0:0 with SMTP id m2-v6csp5445047imm; Tue, 16 Oct 2018 10:19:23 -0700 (PDT) X-Google-Smtp-Source: ACcGV61XycDNlGljY30I6TUhVuKqFDf6p4rE1jaMd0HV3/bJli9H3+WlCelpX3PzPBdn6dY/AY0r X-Received: by 2002:a63:cc:: with SMTP id 195-v6mr20666616pga.44.1539710363850; Tue, 16 Oct 2018 10:19:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1539710363; cv=none; d=google.com; s=arc-20160816; b=WJryu/jmiGLW8jCdzO/lmPQI2Y5JcPiffWJAcP0Z/UfJddvxUDCy5Bdb6vSz3Wb+Mi CHpH6os8UizHuOkkb5HsBMBjza2Ox6tWCoMpUvbdnvWgPPWDoNQdFTO8Qo6eSy9i5DoE Tn3Ciq1DofTPVd7A4Ks/3xBQkDIBF9BTBRH97n3QOC22dmYGZ2JTxw3pt/xV6Ya2cGIr FDF6ciBVria/551VxEoTUf+FoqznFD49EKxl1g1EtVyP0yHd2ChAEbH3gXEw4odMTfAX LPKB2BNnyDMYKHoeVYlJotVMKnBHTMmCoz4io30M/4xFsDCsDLCeAoc4TLLWIqijnBsm 4pDA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=o0n4eo/JBVu3YrwHRnsffFHe2vqQPcoe0znAVobZzZA=; b=qm/eFD8tYPf8htU51gLZe2WLhK+IXdtGOZHxrlRHm7MuligYU+wbsZOXPSSo9MQZYa XC8qzyJPPEOZEr08grF4RLpal5KnZDoyfBhGdd8/OCh9d7xhdYqG3YwKTprlrMvc+6Ux LUQ5tl9JdlMcRM2/H7Wj6pLD//Plt60qBd/xfbsymKXutVaC21v3Sl9iKro2MpInIAbY UTL+tNbBOU81JWlghYUNg55sBgCjlmBb0kdhKglScCd3Mx+c989JGOADBrNyrgiCDsrU y/HBWm9/NXrXd/QmkWOi3KbU/z/7Jy3ewyn1pFC0n/Vl4YGNsHM06//2IbEi13ezWECG zHAg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=kq+AnzSg; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g187-v6si14341409pgc.151.2018.10.16.10.19.07; Tue, 16 Oct 2018 10:19:23 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=kq+AnzSg; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730032AbeJQBJW (ORCPT + 99 others); Tue, 16 Oct 2018 21:09:22 -0400 Received: from mail.kernel.org ([198.145.29.99]:54172 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728441AbeJQBJV (ORCPT ); Tue, 16 Oct 2018 21:09:21 -0400 Received: from localhost (ip-213-127-77-176.ip.prioritytelecom.net [213.127.77.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 21AF420866; Tue, 16 Oct 2018 17:17:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1539710277; bh=kSt0fbNW2nH5z+C51wP6vaR4JtoCKfse3ybALJI27pU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=kq+AnzSgVfGTewZPmZ02jxlGIkJHZZN1nQ1ySO2lvCuLb1dqrBGc/pJzMTN2srcvc I+8kcuWgl4Bt2q/gTTt+DNk+bPaSklaI0iX+Eddz/xa0NWwUI3mI6BXvS8rvicpNSy vVIBVwnwD7iVotOhcEPZbbGwLuV4bwEHaZoyC6kA= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Paolo Abeni , Eric Dumazet , Jiri Kosina , "David S. Miller" Subject: [PATCH 4.14 025/109] udp: Unbreak modules that rely on external __skb_recv_udp() availability Date: Tue, 16 Oct 2018 19:04:53 +0200 Message-Id: <20181016170526.469778328@linuxfoundation.org> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20181016170524.530541524@linuxfoundation.org> References: <20181016170524.530541524@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.14-stable review patch. If anyone has any objections, please let me know. ------------------ From: Jiri Kosina [ Upstream commit 7e823644b60555f70f241274b8d0120dd919269a ] Commit 2276f58ac589 ("udp: use a separate rx queue for packet reception") turned static inline __skb_recv_udp() from being a trivial helper around __skb_recv_datagram() into a UDP specific implementaion, making it EXPORT_SYMBOL_GPL() at the same time. There are external modules that got broken by __skb_recv_udp() not being visible to them. Let's unbreak them by making __skb_recv_udp EXPORT_SYMBOL(). Rationale (one of those) why this is actually "technically correct" thing to do: __skb_recv_udp() used to be an inline wrapper around __skb_recv_datagram(), which itself (still, and correctly so, I believe) is EXPORT_SYMBOL(). Cc: Paolo Abeni Cc: Eric Dumazet Fixes: 2276f58ac589 ("udp: use a separate rx queue for packet reception") Signed-off-by: Jiri Kosina Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- net/ipv4/udp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/net/ipv4/udp.c +++ b/net/ipv4/udp.c @@ -1565,7 +1565,7 @@ busy_check: *err = error; return NULL; } -EXPORT_SYMBOL_GPL(__skb_recv_udp); +EXPORT_SYMBOL(__skb_recv_udp); /* * This should be easy, if there is something there we