Received: by 2002:ac0:a582:0:0:0:0:0 with SMTP id m2-v6csp5471307imm; Tue, 16 Oct 2018 10:44:18 -0700 (PDT) X-Google-Smtp-Source: ACcGV61aRQQ+zBdVB8aKS0djNlyMh3QZV7MvZ5+SQO5S1KWLi9gAAWs5iWL4US/Auc2bOzeXwTAm X-Received: by 2002:a65:45c9:: with SMTP id m9-v6mr20689094pgr.212.1539711858414; Tue, 16 Oct 2018 10:44:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1539711858; cv=none; d=google.com; s=arc-20160816; b=WgBO39BUbM/Tk0CWSMNh7hncbzFy/Vm7fPzCn1804ENmQBu1Ydn45I4U7RIW///oGJ qgb9oz5wbN/0WW15MQQFD7CZrdec/8NfYIjWFwrpvuhURRdeuZrwg4kY/V52OXVyKBYF Drkyv2HfQAHEtjKk9t5h514cRy9nfU1Pa7XyHvVrZetZWD9Hkc01sXGzlzEQ6dSq51c8 DzlchF+Y+QZnjhxrPviGrhdYOHm/2SqZUOXQHJmLqYoqZWSY2EO+Lvx15VffSGqSNwqn KMEh5aIMzdJvxctSv0B9trHRKIZkwI+MN1jmhZTFcUzEzoQNGM0geje0NcrFlZRiDFy5 LYyg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=LAQsioovQ4OwGYmZsv5sW5jXQLLBpZOKAPj3tyPv2pA=; b=rXKoOGYppQ1eO4iYKxoJCHVdketrqv+pbFHvq3k3JgnAh40LmNi1BOj2UkKyYYqBrS yVvWf5YNmlXHfoMh/1QAVCsSPc5xl7cVb7w6fq54PqSuNS1tLT66wCWjaJrbz+hlgowR WEKxz2JA3jnc7ryU8qy7GpEN8VrqurrCEqIadONxdALVDfBnklgUQpD+nEWdqzscxCKO VXxYRcAMjAD3imR6VWzTjifOtOFODoKF+d2XC/S4YPG1IPFFFX8FfDNimYLJtAs608Au aYusrgha96LLEUdRgQptdZepKOT1Tl96V/lEwjqyyEX4eQ5NhuQStG2C2KKJMSBabFkq k7sw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j189-v6si14051300pgd.476.2018.10.16.10.44.02; Tue, 16 Oct 2018 10:44:18 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727233AbeJQBfN (ORCPT + 99 others); Tue, 16 Oct 2018 21:35:13 -0400 Received: from mailout.easymail.ca ([64.68.200.34]:60395 "EHLO mailout.easymail.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727097AbeJQBfN (ORCPT ); Tue, 16 Oct 2018 21:35:13 -0400 Received: from localhost (localhost [127.0.0.1]) by mailout.easymail.ca (Postfix) with ESMTP id C5F16C1489; Tue, 16 Oct 2018 17:43:40 +0000 (UTC) Received: from mailout.easymail.ca ([127.0.0.1]) by localhost (emo01-pco.easydns.vpn [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id EGizF1UDnLc2; Tue, 16 Oct 2018 17:43:40 +0000 (UTC) Received: from [192.168.1.87] (c-24-9-64-241.hsd1.co.comcast.net [24.9.64.241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mailout.easymail.ca (Postfix) with ESMTPSA id 0C1DDC0781; Tue, 16 Oct 2018 17:43:30 +0000 (UTC) Subject: Re: [PATCH] selftests/ftrace: Use colored output when available To: =?UTF-8?Q?Daniel_D=c3=adaz?= , linux-kselftest@vger.kernel.org, Steven Rostedt Cc: Ingo Molnar , open list , Shuah Khan References: <20181016170220.31156-1-daniel.diaz@linaro.org> From: Shuah Khan Message-ID: <037e072a-5695-1343-35d1-37b9450581d4@kernel.org> Date: Tue, 16 Oct 2018 11:43:29 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20181016170220.31156-1-daniel.diaz@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/16/2018 11:02 AM, Daniel Díaz wrote: > If test is being directly executed (with stdout opened on the > terminal) and the terminal capabilities indicate enough > colors, then use the existing scheme of green, red, and blue > to show when tests pass, fail or end in a different way. > > When running the tests redirecting the stdout, for instance, > to a file, then colors are not shown, thus producing a more > readable output. > > Signed-off-by: Daniel Díaz > --- Hi Daniel, Thanks for the patch. Steve is working on adding this functionality. Please see the latest linux-kselftest next for the patch. Steve just sent an update to the patch to fix an issue. Please test and see if that solves the problem you are trying address with this patch. thanks, -- Shuah