Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <1539696848-21988-1-git-send-email-msavaliy@codeaurora.org>
In-Reply-To: <1539696848-21988-1-git-send-email-msavaliy@codeaurora.org>
From:   Doug Anderson <dianders@google.com>
Date:   Tue, 16 Oct 2018 13:14:00 -0700
Message-ID: <CAD=FV=UZhVni2S1utd=-aAJ3V8+-+TV57-FjrwVJB=jc6Ka8QA@mail.gmail.com>
Subject: Re: [PATCH] tty: serial: qcom_geni_serial: Add suspend support to non
 console UART
To:     msavaliy@codeaurora.org
Cc:     alokc@codeaurora.org,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Jiri Slaby <jslaby@suse.com>, linux-serial@vger.kernel.org,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi,

On Tue, Oct 16, 2018 at 6:34 AM Mukesh, Savaliya
<msavaliy@codeaurora.org> wrote:
>
> From: Mukesh Kumar Savaliya <msavaliy@codeaurora.org>
>
> UART driver checks for the PM state and denies suspend if state is ACTIVE.
> This makes UART to deny suspend when client keeps port open which is not
> correct. Instead follow framework and obey suspend-resume callbacks.
>
> Signed-off-by: Mukesh Kumar Savaliya <msavaliy@codeaurora.org>
> ---
>  drivers/tty/serial/qcom_geni_serial.c | 36 ++++++-----------------------------
>  1 file changed, 6 insertions(+), 30 deletions(-)

Looks like this patch was re-sent about an hour later with a different
subject of ("tty: serial: qcom_geni_serial: Rectify UART suspend
mechanism") at <https://lkml.kernel.org/r/1539699060-3055-1-git-send-email-msavaliy@codeaurora.org>.
The subject of the later patch seems better.  I'll do my review there.

-Doug