Received: by 2002:ac0:a582:0:0:0:0:0 with SMTP id m2-v6csp5623644imm; Tue, 16 Oct 2018 13:16:21 -0700 (PDT) X-Google-Smtp-Source: ACcGV63As5h/EeDHunSSfRoQeHrzXbhknyDcZ+nVPxUKZGPfGNayKM75mm/leaqfMf3YcVks2ZuM X-Received: by 2002:a62:5fc5:: with SMTP id t188-v6mr14360301pfb.84.1539720981127; Tue, 16 Oct 2018 13:16:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1539720981; cv=none; d=google.com; s=arc-20160816; b=E/fXYt/5V4XmfomTM3q1VnRKsEryMn0iEwYPRNyK8OZZBakjjrDtfw+pjjAXdFzU4R 6PJfhQLDGVkWSmyCq3PERNnOBAbevAqcuU9N8C8+ENn5AbKPo2Jr5ViW5sf3sb6nWYrd 1xLZrWh4OpCW5cakBRoJpA4cZH+OZ54BYsszNUPVbEuoJfDDBLcZSzdogDSFtJzqDqEB zSJnm85AvY+cixE1BBNFk3AHsHd+b+v1rXmdsKdbnUd1OMYdEHZMv+ghoEziEWu5jKun BHk63e1+a7Fz0oGfOwrQAE2o2W3kSzpX1a+qUtM8EURP0ACRPgi6RmR1KGfrfoHU5u2j sPSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=lZo8NTSNRBEOiRewbWUSsLRdUPpMm5QHZ7wX794Ulb8=; b=krciqGFHYfYNcoAwDSFncFv136z/cQuqWIrFnjZlM6TFPIMGH+8zJuIY7tLOTXU1g0 wdQ482XwNCB8WVdrA1EdP02RbIqMSpS9dyeruOPQ4Ur+HMht+FOIQWJ8Qznpx+4yc/JI gF8JJ5/cfD0qHI/H//QWwrH83EYT20OGTWa8qs2+Dhleb8aa/xc5AlGn1pmd1UHMOW29 b2dmlJ8pPruPwsqyf4Ro7DMOugEDV2daBGWzR6X/BOmHOrGhdKPQdbCPy/s4clkQseBu +fdwflNupHfyJ6EtDcUKHOg9qNqPJir2KfUC57Y61+XFAkoFNuFCpHQ9dTw8wtqFpwCh tL3g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u9-v6si14721260pgh.580.2018.10.16.13.16.05; Tue, 16 Oct 2018 13:16:21 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726974AbeJQEHq (ORCPT + 99 others); Wed, 17 Oct 2018 00:07:46 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:56966 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725960AbeJQEHq (ORCPT ); Wed, 17 Oct 2018 00:07:46 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::cf9]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 615C812DE5810; Tue, 16 Oct 2018 13:15:41 -0700 (PDT) Date: Tue, 16 Oct 2018 13:15:38 -0700 (PDT) Message-Id: <20181016.131538.1460013299973717680.davem@davemloft.net> To: grygorii.strashko@ti.com Cc: ivan.khoronzhuk@linaro.org, linux-omap@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, alexander.h.duyck@intel.com Subject: Re: [RFC PATCH net-next 2/4] net: 8021q: vlan_core: allow use list of vlans for real device From: David Miller In-Reply-To: <2242102f-bfc8-e334-e9ae-93edd26587eb@ti.com> References: <20181016182035.18234-1-ivan.khoronzhuk@linaro.org> <20181016182035.18234-3-ivan.khoronzhuk@linaro.org> <2242102f-bfc8-e334-e9ae-93edd26587eb@ti.com> X-Mailer: Mew version 6.7 on Emacs 26 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 16 Oct 2018 13:15:41 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Grygorii Strashko Date: Tue, 16 Oct 2018 14:39:43 -0500 > > > On 10/16/2018 01:20 PM, Ivan Khoronzhuk wrote: >> It's redundancy for the drivers to hold the list of vlans when >> absolutely the same list exists in vlan core. In most cases it's >> needed only to traverse the vlan devices, their vids and sync some >> settings with h/w, so add API to simplify this. >> > > below has to be under ---. I think it is good to docuement this in the commit message. More information in the repository can never hurt.