Received: by 2002:ac0:a582:0:0:0:0:0 with SMTP id m2-v6csp5709976imm; Tue, 16 Oct 2018 14:57:49 -0700 (PDT) X-Google-Smtp-Source: ACcGV62zf0Q9U8u9YSWY4O94p9Gmh3Z8aHUtXyIHRidIhdlHe8EqIiXpdN7bQ4hH4UB4yyONNAPq X-Received: by 2002:a63:ed09:: with SMTP id d9-v6mr21721595pgi.305.1539727069846; Tue, 16 Oct 2018 14:57:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1539727069; cv=none; d=google.com; s=arc-20160816; b=F2fYSgowU7PDUyiovOe985y6tCYjzFXqqkfkda/8gRijOkaIbVwXUnoDHHvqnH1vdo nUp0B4UQRqUPuPUobNOHGEgj2pi6qfCd4QGeDGS5/5gA8yHppTqLcBv9rqLXKeKs35Py FLOJhysBV2Xtv2+iKRRzs1MJSAa9mFpgcXsDAq+gTpfsJFuphCbcd1a1sOnE38PY2W0R dBO37KhYJMoMc9rgPvEIeg5ehqzjlgCdLJ5XV2farcAKbG/G7mGzKgqtiakeuf8MBRtI rNTBNtMDC5p01RqS1b+0JfCo5qBHEiSAr04S3CymPBU/b6VXGoipD9CQ04sP5ieyucn/ sliw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:message-id :in-reply-to:date:references:organization:from:subject:cc:to :dkim-signature; bh=yxpOZfS9iBDFzO3nBZaj5DjsvZ+RdeVXenbvkCbpfZk=; b=xkjCajDna9lPyLZ8mAgAP36gLBjHwhZUvdN7+N0zD8Dc52wq6R5ojxkicq0yeMl/50 wGEBOKFiekblIGHcRhw1FVUZej0x/oeYsUM1YBxIY5PZtqgcSbNlRYnI8lDbwzKroogm ngjoFuJrq4lXPJZ5oKp2D4UfmiFniwxkWOE8lF1KAZzJFzhbSiyWHquc9/4cvfjmgHCV 8flWKVRAkKWVWA/wae1N94Bow+Y4lKWN0PVL3zZ4e4nQa41xQAH1BqcRFz6j45RLFadQ UoJe7NgogK2AXs/wzSY+4+wqvTb69Vwbs89Zxtfa+M54llXuSniu4h2jqEOriBXblth5 ymaQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2018-07-02 header.b=jW1oGrQe; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a7-v6si15344497pgb.301.2018.10.16.14.57.33; Tue, 16 Oct 2018 14:57:49 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2018-07-02 header.b=jW1oGrQe; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727127AbeJQFtH (ORCPT + 99 others); Wed, 17 Oct 2018 01:49:07 -0400 Received: from userp2120.oracle.com ([156.151.31.85]:33474 "EHLO userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726967AbeJQFtG (ORCPT ); Wed, 17 Oct 2018 01:49:06 -0400 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.22/8.16.0.22) with SMTP id w9GLuGwh176231; Tue, 16 Oct 2018 21:56:38 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=to : cc : subject : from : references : date : in-reply-to : message-id : mime-version : content-type; s=corp-2018-07-02; bh=yxpOZfS9iBDFzO3nBZaj5DjsvZ+RdeVXenbvkCbpfZk=; b=jW1oGrQeG3aGYfVNMEomwKTPSOthGiN4yzUVrT3cOY1Xw/B52noEZk+7JKnIUFvDIFyR GO3GyjDDQPDENQQKbF2lJustyZw7VgO1MGOwzR26DnOIDOBwwYFaRMfr8U/exIZPtoBB Zqo7cEkgpy2t7LoKKryiGr73fYxJ/4KiJydPRFQhEpIfAUW0C61y1HUtjFmyC+OF2gHX CJgAGZzzyog934T+BHAqCZAl40yYqIaXmszaMp/6qsEekehqfGhhij83lRwneVBMj5+q +IIZmyGP8TnfMiyvTkO3vrHDtsNRoMSjjunBG7V8NGNf4Cq06d5kTxaNv3IbqWxEE4Be sw== Received: from userv0021.oracle.com (userv0021.oracle.com [156.151.31.71]) by userp2120.oracle.com with ESMTP id 2n39brbd4n-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 16 Oct 2018 21:56:38 +0000 Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by userv0021.oracle.com (8.14.4/8.14.4) with ESMTP id w9GLubV5001997 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 16 Oct 2018 21:56:37 GMT Received: from abhmp0018.oracle.com (abhmp0018.oracle.com [141.146.116.24]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id w9GLubhF004324; Tue, 16 Oct 2018 21:56:37 GMT Received: from ca-mkp.ca.oracle.com (/10.159.214.123) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 16 Oct 2018 14:56:36 -0700 To: Wenwen Wang Cc: Kangjie Lu , Kashyap Desai , Sumit Saxena , Shivasharan S , "James E.J. Bottomley" , "Martin K. Petersen" , megaraidlinux.pdl@broadcom.com (open list:MEGARAID SCSI/SAS DRIVERS), linux-scsi@vger.kernel.org (open list:MEGARAID SCSI/SAS DRIVERS), linux-kernel@vger.kernel.org (open list) Subject: Re: [PATCH] scsi: megaraid_sas: fix a missing-check bug From: "Martin K. Petersen" Organization: Oracle Corporation References: <1538850861-26882-1-git-send-email-wang6495@umn.edu> Date: Tue, 16 Oct 2018 17:56:33 -0400 In-Reply-To: <1538850861-26882-1-git-send-email-wang6495@umn.edu> (Wenwen Wang's message of "Sat, 6 Oct 2018 13:34:21 -0500") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9048 signatures=668706 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=627 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1807170000 definitions=main-1810160183 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Wenwen, > This patch enforces a check on the two kernel variables 'local_sense_off' > and 'user_sense_off' to make sure they are the same after the copy. In case > they are not, an error code EINVAL will be returned. Applied to 4.20/scsi-queue, thank you! -- Martin K. Petersen Oracle Linux Engineering