Received: by 2002:ac0:a582:0:0:0:0:0 with SMTP id m2-v6csp150420imm; Tue, 16 Oct 2018 20:09:35 -0700 (PDT) X-Google-Smtp-Source: ACcGV61pyhgtFNGVEDWbml0W/x47Eny3sUToS1aUFlwC0iCcq1mFimH8gXd0GxZnA2SRQlXVCg7P X-Received: by 2002:a62:8490:: with SMTP id k138-v6mr24766892pfd.177.1539745775896; Tue, 16 Oct 2018 20:09:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1539745775; cv=none; d=google.com; s=arc-20160816; b=XcNteE/29rvFpHsu59WVhqsg8ixjFlPMZ7Lo+fmW+ItGUHjEjTc2b0f/4wigNPO83p C8LgvdzDdXpTagvRLb5KKDDCulKSVgcXZci83ghWMtV7q8cAJaaR+9f1nZGcr1JVlDOh j/071mvZOgVpABWTBf7yvzBuljGF8lHWD3hBNgpoLWmYFv8yZYQIa3N1T/OciYmmhjp7 C8p1cD+tDY6H+0pn1/PUqXGigGNoomp8RGhCPFhW6OwVmVHMqM7h2T+yH3eCEjWiBSU0 I2J70HrGu2vLW21HazxI3RC2Dte4L/6HTXvvc2V1nqnuRWD0r/iN+gUzcNjWkr8rVuly b+qg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=M8dsvmIzTHKKVGxULcihjzEM6chTWJouSjLpkb54LPM=; b=XqkNMfCfDGZ8Zjn4KzsIB0hZGFmIbeYcP9aZKSEGnWJVO+HEG0znvxrOoQZluXdDO7 oOJFImtOAf9QE+uXq45p6rihF0RnZTWZZcW7DmR/aSZRtRzstSoNnyENtLh9aGcLrcl5 erRsPIwE1SDWpT66Aqmjxh9+DJrx5qjBvz8FfMYhbf2cprGWAMfWgV3Qe2fOoHOfMkgL ehSe+5TwGSQuqmD3iGhTu6g77Jb2tqkqjlG0OUktGxmZS6tO4gU5/NRp5z6G7iFOakCY lULP/nCQOrDNs8aLK3IZHcspCfJ4euPyKDIcMj5P1ffHB3YWnRjKAueIBqx02ybCogz5 lndw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=ifGLbXmc; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m20-v6si15721920pgk.579.2018.10.16.20.09.19; Tue, 16 Oct 2018 20:09:35 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=ifGLbXmc; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727390AbeJQLC2 (ORCPT + 99 others); Wed, 17 Oct 2018 07:02:28 -0400 Received: from mail-pg1-f193.google.com ([209.85.215.193]:41723 "EHLO mail-pg1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727097AbeJQLC2 (ORCPT ); Wed, 17 Oct 2018 07:02:28 -0400 Received: by mail-pg1-f193.google.com with SMTP id 23-v6so11794458pgc.8; Tue, 16 Oct 2018 20:08:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=M8dsvmIzTHKKVGxULcihjzEM6chTWJouSjLpkb54LPM=; b=ifGLbXmcpizvBdesXdgVMr3YZTGTF/CtB0PZe7ML9KFJBzRwhDmiJyMgx7mG+ZW2p8 9lVfxt/FkFbj6KD6Xnr/DScxUbxk4MH6jpBI/w9sqr5dIgQGWrdoAFF1mslp+/A6fT+n EDvtfxfu514wq6RTVMwmLXFRLDQki4cxwhx0Gl2Nz7LpCGJOIW62uaMyohLO3FwrKJu4 4Ft7izkRpIAarqu2l9MsjiVXuM8OfjkAZx5vfgNena+Vh3/vqsBRe79nQAjiIMDlwvAg ynsxhnlqDkpoaWpQtOfOzpNRSOV3i4pyAyXP3mx2UbAOX6YAHUAhWbOZMWL4A2C9BkyK Wyhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=M8dsvmIzTHKKVGxULcihjzEM6chTWJouSjLpkb54LPM=; b=rp4+xJwxfZJGmRUNN9pg3Eta7gQCto4FDJEOgiqD/lYdB8g4gnanPuB67NyXqRU+O4 iNVnSUomBxVdXHSrbnPBMwnap3O+gBZOOxX0ELHryonc3mPcDyn2mjBl69xrKBcxKXFV +GCubMTYWTXzdCJDxHKKdPrO4I4VCgELY38SiGa9P0RJ3cykq1QY5CgC7k/1GBM7Osjo +M3wHM/tPAblnKpBDc32Hfjj6GATkzIoZrKeMDDXL1bvgXYHx8Yvr7XAef6sby/4VMmv 72YsfSuDR85fouhcnJa0p8VG5NtbpQBtDgbarMvQM9a3v6DsiGXfDLIraYuDXW7MSU0H Yb1A== X-Gm-Message-State: ABuFfogpUdc8i1rvpZnTNdtxGAII1aNXUtROixpu6FKSlLoZ03nAcMrO uGUaNZlHHXLieZJDD+Vx0IEWcrtv X-Received: by 2002:a65:5347:: with SMTP id w7-v6mr23278154pgr.17.1539745738177; Tue, 16 Oct 2018 20:08:58 -0700 (PDT) Received: from [192.168.1.70] (c-24-6-192-50.hsd1.ca.comcast.net. [24.6.192.50]) by smtp.gmail.com with ESMTPSA id r23-v6sm17618979pfh.79.2018.10.16.20.08.56 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 16 Oct 2018 20:08:57 -0700 (PDT) Subject: Re: [PATCH v4 00/18] of: overlay: validation checks, subsequent fixes To: Michael Ellerman , Rob Herring , Pantelis Antoniou , Benjamin Herrenschmidt , Paul Mackerras , Alan Tull , Moritz Fischer Cc: linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, devicetree@vger.kernel.org, linux-fpga@vger.kernel.org References: <1539657458-24401-1-git-send-email-frowand.list@gmail.com> <87murekyts.fsf@concordia.ellerman.id.au> From: Frank Rowand Message-ID: Date: Tue, 16 Oct 2018 20:08:56 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <87murekyts.fsf@concordia.ellerman.id.au> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/16/18 02:47, Michael Ellerman wrote: > frowand.list@gmail.com writes: > >> From: Frank Rowand >> >> Add checks to (1) overlay apply process and (2) memory freeing >> triggered by overlay release. The checks are intended to detect >> possible memory leaks and invalid overlays. >> >> The checks revealed bugs in existing code. Fixed the bugs. >> >> While fixing bugs, noted other issues, which are fixed in >> separate patches. >> >> ***** Powerpc folks: I was not able to test the patches that >> ***** directly impact Powerpc systems that use dynamic >> ***** devicetree. Please review that code carefully and >> ***** test. The specific patches are: 03/16, 04/16, 07/16 > > Hi Frank, > > Do you have this series in a git tree somewhere? > > I tried applying it on top of linux-next but hit some conflicts which I > couldn't easily resolve. > > cheers > git://git.kernel.org/pub/scm/linux/kernel/git/frowand/linux.git $ git checkout v4.19-rc1--kfree_validate--v4 $ git log --oneline v4.19-rc1.. 2ba1b7d353dd of: unittest: initialize args before calling of_*parse_*() 4f9108209f79 of: unittest: find overlays[] entry by name instead of index 353403c76ff8 of: unittest: allow base devicetree to have symbol metadata 8fc37e04a01b of: overlay: set node fields from properties when add new overlay n 05d5df0e5151 of: unittest: remove unused of_unittest_apply_overlay() argument 8c021cba757a of: overlay: check prevents multiple fragments touching same proper 797a6f66e039 of: overlay: check prevents multiple fragments add or delete same n c385e25a040d of: overlay: test case of two fragments adding same node c88fd240f0e0 of: overlay: make all pr_debug() and pr_err() messages unique 1028a215d32a of: overlay: validate overlay properties #address-cells and #size-c f1a97ef74ce4 of: overlay: reorder fields in struct fragment ffe78cf7a1fb of: dynamic: change type of of_{at,de}tach_node() to void 5f5ff8ec0c0c of: overlay: do not duplicate properties from overlay for new nodes 06e72dcb2bb0 of: overlay: use prop add changeset entry for property in new nodes a02f8d326a08 powerpc/pseries: add of_node_put() in dlpar_detach_node() e203be664330 of: overlay: add missing of_node_get() in __of_attach_node_sysfs 8eb46208e7c8 of: overlay: add missing of_node_put() after add new node to change b22067db7cf9 of: overlay: add tests to validate kfrees from overlay removal