Received: by 2002:ac0:a582:0:0:0:0:0 with SMTP id m2-v6csp434394imm; Wed, 17 Oct 2018 02:36:56 -0700 (PDT) X-Google-Smtp-Source: ACcGV62EwsAvJy6Kc/LDOTyySnuOvn18+p1SNTm3dZcz67rBAtXenBNdKmlgNx3UP5DAsQcJTGb/ X-Received: by 2002:a63:1c1b:: with SMTP id c27-v6mr23926116pgc.351.1539769016901; Wed, 17 Oct 2018 02:36:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1539769016; cv=none; d=google.com; s=arc-20160816; b=WGmCAeqImYShYTm7Qkk/HS4VkVsEy643wMvRMtizhjIdmB8kEzdCYmbBe7eFbK8HoN W2LngIbFcD+ihfEFJOVXBn6IxWILIabNiX50UxQibW5vCfaF0JRiacaCeej6u52JzMwd rOVrNhlUNhmJg2dDS/0zEPmhVIu7WrNOL+Q0jJmSQ8kh96rBjnrNeyoI8rxWxp8LDsYR A51rA5gYA8tt220VvYeLx8ZGfnTog1Iz4+VxjVWWZRkKfUTF4tGvWg3o7K9JQBCDkok6 2ErCEQ9qKPnIj4KtzbZKwoKtncn+ezPYOfn/e49Y4vYaprX1tliukh3fDu9Z2NFFK+w1 gkGA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=BFEOqh2qxP7CG8OudH2+qG6V/JYQWh95e1viQUt10VQ=; b=aS/KG5N3uHEPk6xh8GHgK6pfxCsuUtjZ7n+NjIbQ7yib5PM5CHqX/RZ27jADhclHns UrZ3u39u9yF2rU8jmna8HKR0wv9UUUCtWOQtKYHEB4taE0xo9nLMvpNH+0HX8hqpBDIe f/wkZPZlKB4E0Lk6L7xOabbbKUF5N/Yee46V8c+Dt7YsCkHi3VntDIvgeeFAeWDUqnzB RKUFJkX/2xoQdSuJ9FN/i5JEgYf/omoULxnuoLHd0F94A7N3ihugdJRJ+E03WbIWQYqJ Ru0QWV220Fy5fYzKPhViyQV5jf+nwg+x7UM8YUwgteM2WfaeEqz06fAXIuPQf+Orl6ta KE1w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z11-v6si16872794pgo.470.2018.10.17.02.36.41; Wed, 17 Oct 2018 02:36:56 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727068AbeJQRaf (ORCPT + 99 others); Wed, 17 Oct 2018 13:30:35 -0400 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:48732 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726861AbeJQRaf (ORCPT ); Wed, 17 Oct 2018 13:30:35 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 4364A341; Wed, 17 Oct 2018 02:35:44 -0700 (PDT) Received: from e107155-lin (unknown [10.1.196.42]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C75CB3F59C; Wed, 17 Oct 2018 02:35:42 -0700 (PDT) Date: Wed, 17 Oct 2018 10:35:40 +0100 From: Sudeep Holla To: Huacai Chen Cc: Greg Kroah-Hartman , "Rafael J . Wysocki" , linux-kernel@vger.kernel.org, Fuxin Zhang , Zhangjin Wu , Huacai Chen , Sudeep Holla Subject: Re: [PATCH] cacheinfo: Keep the old value if of_property_read_u32 fails Message-ID: <20181017093540.GB16320@e107155-lin> References: <1539739563-1886-1-git-send-email-chenhc@lemote.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1539739563-1886-1-git-send-email-chenhc@lemote.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 17, 2018 at 09:26:03AM +0800, Huacai Chen wrote: > Commit 448a5a552f336bd7b847b1951 ("drivers: base: cacheinfo: use OF > property_read_u32 instead of get_property,read_number") makes cache > size and number_of_sets be 0 if DT doesn't provide there values. I > think this is unreasonable so make them keep the old values, which is > the same as old kernels. > What old values does the kernel have ? Which architecture are you referring ? If DT doesn't have entry then we can't expose sysfs, hence 0. Please provide more details on the issue you are seeing. -- Regards, Sudeep