Received: by 2002:ac0:a582:0:0:0:0:0 with SMTP id m2-v6csp450855imm; Wed, 17 Oct 2018 02:57:49 -0700 (PDT) X-Google-Smtp-Source: ACcGV63xt2M0FlcF+SXze1mHkJGRj0qDA2n2VB0BDmzTdXQqUf7btxZ5f+ONZ9I6e3tdQ4BnLjqM X-Received: by 2002:a62:ac15:: with SMTP id v21-v6mr25801217pfe.126.1539770269738; Wed, 17 Oct 2018 02:57:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1539770269; cv=none; d=google.com; s=arc-20160816; b=CFdiiNFJj20qoWWgZiOISBOwG/oTapq/kCOCezBsgc8aeggpDvhAL0JlOdU79LYje9 FgzJllRhg5G4+sHMQB3bs0ABHtPG9fGSNKhEu0xRtnbT7laIFpQK7sOdAn7ZjE4yAkjv 0LuUtLgQkGGVOmnGFfLURACI3YDcvfmLGol+ZeHnvOWjw/NsvyySndz8P08zwAQhtGf6 /ak1YwD+Q2JOB5WUH0UesYfELc4W2vQSExW9TLmwpDfJMiado/xTaYD/BNplIa1HvaUe 43Vj0EDoe40RYAqoEDXX5Sviga3DlQz+yE+QQcvw2RI170vXGy+sAK1KMO6eYDJvG7wE 9YmA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=a6WND7pWdvr5Qf+0xCeKno9SMzNngxlEIImzXrPgw5A=; b=LtgF5Rr+DDm4JVrXVIvIlYLhyHBAwwhX235Cfwg7r7Lsz6s9K1PFyqQkn0Z2wniC+9 rPLIncQszOKn09X4+JGUi84nJoaBpGLnvHSSEWE1ohMQ7ZsGR7PPgSvFGsVGL4ZwarD6 WavEdo3fxhDeP5ZE1CEI5vacAezI4cmlgUIckyHmlMrSLR3PrYGeOTiVFJMhuigvEnkU VmVn1yL6IEetpVecApMIivprfenMEocYbycErOctcvGzlUJSijcO7BGog+FAkq2FJ54T 8L3lmGqOkhVU86TZNuGlTWfxxMxtqo6diVCbVrLzLqnHi9lE4ahIADBRATLHktbYNfna o0zg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=RLMmL0gC; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j9-v6si1075894pgs.289.2018.10.17.02.57.34; Wed, 17 Oct 2018 02:57:49 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=RLMmL0gC; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727040AbeJQRwG (ORCPT + 99 others); Wed, 17 Oct 2018 13:52:06 -0400 Received: from heliosphere.sirena.org.uk ([172.104.155.198]:41688 "EHLO heliosphere.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726958AbeJQRwG (ORCPT ); Wed, 17 Oct 2018 13:52:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=a6WND7pWdvr5Qf+0xCeKno9SMzNngxlEIImzXrPgw5A=; b=RLMmL0gCudEt3AaNk6HX+71hJ ZRExTD1un5560yepmaSL21IZa0Vjp9KYywrb/oGMbqY6IMgRTAP6igGlV9S1FqQ3aE1UPeJZf/8Bs SN1r+lrLFRNtaXnxkpMTXqJdSQb0tpoG+mju06Xa0CsUTugwB6DY0xjgI9E8xpHPAckqA=; Received: from cpc102320-sgyl38-2-0-cust46.18-2.cable.virginm.net ([82.37.168.47] helo=debutante.sirena.org.uk) by heliosphere.sirena.org.uk with esmtpa (Exim 4.89) (envelope-from ) id 1gCiZV-0000oy-6a; Wed, 17 Oct 2018 09:56:57 +0000 Received: by debutante.sirena.org.uk (Postfix, from userid 1000) id EE66411224C3; Wed, 17 Oct 2018 10:56:56 +0100 (BST) Date: Wed, 17 Oct 2018 10:56:56 +0100 From: Mark Brown To: Andrzej Hajda Cc: Greg Kroah-Hartman , Bartlomiej Zolnierkiewicz , Marek Szyprowski , "Rafael J. Wysocki" , linux-kernel@vger.kernel.org, Javier Martinez Canillas , linux-arm-kernel@lists.infradead.org, andy.shevchenko@gmail.com Subject: Re: [PATCH v2 1/3] driver core: add probe_err log helper Message-ID: <20181017095656.GC24097@sirena.org.uk> References: <20181017085824.30806-1-a.hajda@samsung.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="4jXrM3lyYWu4nBt5" Content-Disposition: inline In-Reply-To: <20181017085824.30806-1-a.hajda@samsung.com> X-Cookie: No passing zone. User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --4jXrM3lyYWu4nBt5 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Oct 17, 2018 at 10:58:24AM +0200, Andrzej Hajda wrote: > During probe every time driver gets resource it should usually check for error > printk some message if it is not -EPROBE_DEFER and return the error. This > pattern is simple but requires adding few lines after any resource acquisition > code, as a result it is often omited or implemented only partially. > probe_err helps to replace such code sequences with simple call, so code: Reviwed-by: Mark Brown --4jXrM3lyYWu4nBt5 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAlvHB2gACgkQJNaLcl1U h9DyCgf8Czf0Nr9kCIDHXbVxidcWJ6S2Ss07BSl6Gmsjc9bB5Vj66F+J2HuI9wRl y28f2ZsRbDd8r674DyryGuUe5Ct+iqKkzpqVrFd7Fye5/5UA0GxW7pSjFAaR9H1W f79u0wSaBmt+Iw0XipQE0ScLUGMGo3SjsrbfGTitixs1X34SUFitkgqnht9N33jR V4U90pxT2L2MpR0gLEgLr+wlNTkeCMTh0y1ugAY6Ewu4ysK9Lvphkp5krCcCiEoX c52eO9qDY3A3lDkLvbyN2e2fbocifuhV2ogktKTEFAfhC5GMuLpHR0r24PrEnsKB WUmN6VfO95f4q/En+3+7O0Qy8Spz8Q== =CDkY -----END PGP SIGNATURE----- --4jXrM3lyYWu4nBt5--