Received: by 2002:ac0:a582:0:0:0:0:0 with SMTP id m2-v6csp517802imm; Wed, 17 Oct 2018 04:10:33 -0700 (PDT) X-Google-Smtp-Source: ACcGV63tupxDBlLZx6QKdKZXbZelBF4MKP3r0+4Yddp9ZjlgFglofgdsnpJ/NPN18iHkGNcvG2Js X-Received: by 2002:a63:d256:: with SMTP id t22-v6mr23749120pgi.335.1539774633635; Wed, 17 Oct 2018 04:10:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1539774633; cv=none; d=google.com; s=arc-20160816; b=DrYkXONl+3DjVk6uuTj5urkyCtU+DdQXPF7/5yp6MphRZoKRb5oAAUFsVPHb8PCc9G lkQjeUxauFHXHp2dfCklMrdZvzhbm7mF6P+0lszpjE6jDG4ZVDutk//q3ykAkOxROwRF VYn7dGcX37RQsEtknfWQZeGLcc9UAeXXweV3i17nzpJ2FSXjRlR1qFFmyBWG50sORtvf pV1SbXkEMp4PH4GFiA9ZI5ivfn7FDzDLFp6sDt6rxMaRyifNFAon5xJHopC/sv4+JVMb CAijQq0tRwEfIb0NMc5nb3jKlrLy4FCJgAgQtCjaLyxwg9mdiBWIaknxCopKvvTXb4Bn ASsg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=sde3QjNzaAtSazEybwZjVv6l6AgMlYF+shKWPyAgiX8=; b=mxCy4yXmpTizWNWMkrsfaXfUZr5jEYIsp1MlKDFKIMO6VlGGHEcsldn5tC4Q5AvjCC CsnJ9Ak3I+/ovY68FVFj1qew0w6Rup3dLtOMO455I7rr5XhSaPVV79Z7Tmr8vLpLenCG 6bj2l0Xj3z5oziNfw/CaXboPJbwZ7NkiaF1UHn3oKWTn0OoNbKmNvBBIXe7YR4Zygc08 FZEUIs39tv/XBc0vHb7um1G4XFXbniZGzLtrSQCfQQGCygTCtb87SeEn4ThW2CUQKcJe xA7Qq+YtQ9lcxqy/SAr3wU72M7NdMOo3h6BG/QMmZ5zw+xzgvNvpcMNZPFr16g+sUV4T 3Hsg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j10-v6si17397216plg.272.2018.10.17.04.10.17; Wed, 17 Oct 2018 04:10:33 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727132AbeJQTFI (ORCPT + 99 others); Wed, 17 Oct 2018 15:05:08 -0400 Received: from mx2.suse.de ([195.135.220.15]:44190 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727000AbeJQTFH (ORCPT ); Wed, 17 Oct 2018 15:05:07 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay1.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 08813ACC8; Wed, 17 Oct 2018 11:09:53 +0000 (UTC) Date: Wed, 17 Oct 2018 13:09:52 +0200 From: Michal Hocko To: John Hubbard Cc: Jan Kara , Dave Chinner , Matthew Wilcox , Christopher Lameter , Jason Gunthorpe , Dan Williams , linux-mm@kvack.org, Andrew Morton , LKML , linux-rdma , linux-fsdevel@vger.kernel.org Subject: Re: [PATCH 4/6] mm: introduce page->dma_pinned_flags, _count Message-ID: <20181017110952.GN18839@dhcp22.suse.cz> References: <20181012060014.10242-1-jhubbard@nvidia.com> <20181012060014.10242-5-jhubbard@nvidia.com> <20181013035516.GA18822@dastard> <7c2e3b54-0b1d-6726-a508-804ef8620cfd@nvidia.com> <20181013230124.GB18822@dastard> <20181016085102.GB18918@quack2.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue 16-10-18 18:48:23, John Hubbard wrote: [...] > It's hard to say exactly what the active/inactive/unevictable list should > be when DMA is done and put_user_page*() is called, because we don't know > if some device read, wrote, or ignored any of those pages. Although if > put_user_pages_dirty() is called, that's an argument for "active", at least. Any reason to not use putback_lru_page? Please note I haven't really got through your patches to have a wider picture of the change so this is just hint for the LRU part of the issue. -- Michal Hocko SUSE Labs