Received: by 2002:ac0:a582:0:0:0:0:0 with SMTP id m2-v6csp619878imm; Wed, 17 Oct 2018 05:50:39 -0700 (PDT) X-Google-Smtp-Source: ACcGV60x/7W66OYOU1btPNjC+kO9g1GFfoN1iZiOSwwNCJzL056Cbjm+yAkZJMW2Q0ZstuBn3Bzn X-Received: by 2002:a62:571b:: with SMTP id l27-v6mr26510780pfb.209.1539780639251; Wed, 17 Oct 2018 05:50:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1539780639; cv=none; d=google.com; s=arc-20160816; b=f6/j6TEh6nhcLsPjGXC08O1aeEUZc41WpBxWUfZHXB4CvSQ2iiQ4bmUjRVBeMkerCx sB8riQooAUy9WQSSxhqgKCS5fbz1U1vs6tFXhT/fMWiVtiuQrC2S0itNDCs5vy4Enu/s LqH3xzrMRa+Mdrg2skhCOFpCHR1QYdRWwZDhGQLl6jHPzI6RhNfjGtMql/CB2MexS8rn ty9naJXeFc8/JoDyROn3qLO/REn8mcApGaD0iCrm0PSHKoE1BjZavfEy1eumeBFgAWyP F7WDC8Z9FlZ4mT/D74kc+rhTKJlMXZaBAl4fcjdhmQbRL3Echko4Vjn21Y8WtmBHIEm1 Ma4g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=pvRYfb46IXm32Ar1M/v81kW+E9qZHmpb94hGCPvPZxg=; b=jlpFKl/sjS5L8K9a96sJPlVe5HKu/8weYrMzPJUwdfUoyFUOGigFsGmhrlvgf+GWgG oFvLI1KAEs3iDiExAq230/uOaGNt0ybiAxgJt1OK+Bz4OdxE3ezkzoLuEOCwXQhjz8so x8SgORBGz1vTkizCRhBACPYSZhxpBMzaddsotgUciSk3xOITIUlaNO6OhROhQmDDYxFp W5ju0/hurzSlKfSwgyqvjXhaiowT+8fxvY+ygWZPZaMFvdOFguvaQ5IsAK9zDShNOiZL 3MobxWMEaQztEmro5lefO5vBK51DGlgrtYyV/z5JSBz+0A/aNdMM3/ClQh4Q9ELs4dF7 roIg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s13-v6si19328954pfc.149.2018.10.17.05.50.23; Wed, 17 Oct 2018 05:50:39 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727142AbeJQUp1 (ORCPT + 99 others); Wed, 17 Oct 2018 16:45:27 -0400 Received: from mx2.suse.de ([195.135.220.15]:34078 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726936AbeJQUp0 (ORCPT ); Wed, 17 Oct 2018 16:45:26 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 872D9ACBC; Wed, 17 Oct 2018 12:49:51 +0000 (UTC) Subject: Re: [PATCH -next] advansys: remove set but not used variable 'srb_tag' in adv_isr_callback To: YueHaibing , willy@infradead.org, hare@suse.com, jejb@linux.vnet.ibm.com, martin.petersen@oracle.com Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org References: <20181017123432.18304-1-yuehaibing@huawei.com> From: Johannes Thumshirn Message-ID: <4950b4fe-61b5-e1c3-9d16-7643107857a5@suse.de> Date: Wed, 17 Oct 2018 14:49:50 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20181017123432.18304-1-yuehaibing@huawei.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 17/10/18 14:34, YueHaibing wrote: > drivers/scsi/advansys.c: In function 'adv_isr_callback': > drivers/scsi/advansys.c:5952:6: warning: > variable 'srb_tag' set but not used [-Wunused-but-set-variable] > > It never used since introduction in > commit 9c17c62aedb0 ("advansys: use shared host tag map for command lookup") > > Signed-off-by: YueHaibing > --- > drivers/scsi/advansys.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/scsi/advansys.c b/drivers/scsi/advansys.c > index 44c9619..223ef6f 100644 > --- a/drivers/scsi/advansys.c > +++ b/drivers/scsi/advansys.c > @@ -5949,7 +5949,6 @@ static void adv_async_callback(ADV_DVC_VAR *adv_dvc_varp, uchar code) > static void adv_isr_callback(ADV_DVC_VAR *adv_dvc_varp, ADV_SCSI_REQ_Q *scsiqp) > { > struct asc_board *boardp = adv_dvc_varp->drv_ptr; > - u32 srb_tag; > adv_req_t *reqp; > adv_sgblk_t *sgblkp; > struct scsi_cmnd *scp; > @@ -5965,7 +5964,6 @@ static void adv_isr_callback(ADV_DVC_VAR *adv_dvc_varp, ADV_SCSI_REQ_Q *scsiqp) > * completed. The adv_req_t structure actually contains the > * completed ADV_SCSI_REQ_Q structure. > */ > - srb_tag = le32_to_cpu(scsiqp->srb_tag); > scp = scsi_host_find_tag(boardp->shost, scsiqp->srb_tag); Shouldn't this be: scp = scsi_host_find_tag(boardp->shost, le32_to_cpu(scsiqp->srb_tag)); -- Johannes Thumshirn SUSE Labs jthumshirn@suse.de +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850