Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20181017023652.6867-1-changbin.du@gmail.com> <62b6aff8-8ca2-7d6c-d810-64d10a25f2d4@siemens.com>
In-Reply-To: <62b6aff8-8ca2-7d6c-d810-64d10a25f2d4@siemens.com>
From:   Changbin Du <changbin.du@gmail.com>
Date:   Wed, 17 Oct 2018 21:39:52 +0800
Message-ID: <CABgQ-Tgfa-dX2v0LF95wTef36bKGwTkdB9AQrzCozOx_7kgMBQ@mail.gmail.com>
Subject: Re: [PATCH] scripts/gdb: fix lx-version for gdb 7.3-
To:     "J. Kiszka" <jan.kiszka@siemens.com>
Cc:     Du Changbin <changbin.du@gmail.com>, kbingham@kernel.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Oct 17, 2018 at 08:56:44AM +0200, Jan Kiszka wrote:
> On 17.10.18 04:36, Du Changbin wrote:
> > For gdb version less than 7.3, lx-version only one character.
>
>                                           ^^^ prints?
>
I will update it, thanks!

> > (gdb) lx-version
> > L(gdb)
> >
> > This can be fixed by casting 'linux_banner' as (char *).
> > (gdb) lx-version
> > Linux version 4.19.0-rc1+ (changbin@acer) (gcc version 7.3.0 (Ubuntu 7.3.0-16ubuntu3)) #21 SMP Sat Sep 1 21:43:30 CST 2018
> >
> > gdb 7.4 seems to be no such issue.
> >
> > Signed-off-by: Du Changbin <changbin.du@gmail.com>
> > ---
> >   scripts/gdb/linux/proc.py | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/scripts/gdb/linux/proc.py b/scripts/gdb/linux/proc.py
> > index 086d27223c0c..0aebd7565b03 100644
> > --- a/scripts/gdb/linux/proc.py
> > +++ b/scripts/gdb/linux/proc.py
> > @@ -41,7 +41,7 @@ class LxVersion(gdb.Command):
> >       def invoke(self, arg, from_tty):
> >           # linux_banner should contain a newline
> > -        gdb.write(gdb.parse_and_eval("linux_banner").string())
> > +        gdb.write(gdb.parse_and_eval("(char *)linux_banner").string())
> >   LxVersion()
> >
>
> Looks good to me otherwise.
>
> Jan
>
> --
> Siemens AG, Corporate Technology, CT RDA IOT SES-DE
> Corporate Competence Center Embedded Linux

--
Thanks,
Du Changbin