Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] selftests/ftrace: Use colored output when available
To:     Steven Rostedt <rostedt@goodmis.org>
Cc:     =?UTF-8?Q?Daniel_D=c3=adaz?= <daniel.diaz@linaro.org>,
        linux-kselftest@vger.kernel.org, Ingo Molnar <mingo@redhat.com>,
        open list <linux-kernel@vger.kernel.org>,
        Shuah Khan <shuah.kh@samsung.com>
References: <20181016170220.31156-1-daniel.diaz@linaro.org>
 <037e072a-5695-1343-35d1-37b9450581d4@kernel.org>
 <20181016143404.6847beb4@gandalf.local.home>
From:   Shuah Khan <shuah@kernel.org>
Message-ID: <b5b4a38f-d81d-2702-67f7-4fc9cc262776@kernel.org>
Date:   Wed, 17 Oct 2018 09:19:39 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <20181016143404.6847beb4@gandalf.local.home>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 10/16/2018 12:34 PM, Steven Rostedt wrote:
> On Tue, 16 Oct 2018 11:43:29 -0600
> Shuah Khan <shuah@kernel.org> wrote:
> 
>> On 10/16/2018 11:02 AM, Daniel Díaz wrote:
>>> If test is being directly executed (with stdout opened on the
>>> terminal) and the terminal capabilities indicate enough
>>> colors, then use the existing scheme of green, red, and blue
>>> to show when tests pass, fail or end in a different way.
>>>
>>> When running the tests redirecting the stdout, for instance,
>>> to a file, then colors are not shown, thus producing a more
>>> readable output.
>>>
>>> Signed-off-by: Daniel Díaz <daniel.diaz@linaro.org>
>>> ---  
>>
>> Hi Daniel,
>>
>> Thanks for the patch. Steve is working on adding this functionality. Please
>> see the latest linux-kselftest next for the patch.
>>
>> Steve just sent an update to the patch to fix an issue. Please test and see
>> if that solves the problem you are trying address with this patch.
>>
> 
> Hi Shuah,
> 
> I think this patch actually addresses the issue of my last patch, and I
> haven't sent another one.
> 
> I'm waiting to hear from Masami if it fixes the issues he saw.
> 
> -- Steve
> 

Steve,

Do you want me to apply this patch from Daniel or do you plan to send
one. If you want to me take this one, just Ack it.

thanks,
-- Shuah