Received: by 2002:ac0:a582:0:0:0:0:0 with SMTP id m2-v6csp986528imm; Wed, 17 Oct 2018 11:23:08 -0700 (PDT) X-Google-Smtp-Source: ACcGV61MUUKgs5t2MaJ0y6laUWdgC1zCUAlcYuxEPfXOafQkJ3cM6cdQAFgkI6PcCcHWDvrQFy5+ X-Received: by 2002:a63:4b44:: with SMTP id k4-v6mr25358334pgl.51.1539800588687; Wed, 17 Oct 2018 11:23:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1539800588; cv=none; d=google.com; s=arc-20160816; b=G+QXUE1bghG5VNR8oApOSAVmUN3t8C67NA5MNP4l/0bRhWXUfuukY1ZLFkfbXbL3zi lJqad30g0S2CPmLC5M+PwziIaCCyXvepffl8dsjhVODNNOT6LcTGDXexAu1cUFjYuMOj 1ct/81l6UVNM+XoGCHb3YSO9ZMX/mN7bXG6XV2YyGR7VXXAjtUxt1cQm2bvxidIR7sme ieC1X+Uu26bBmZ0s/79e2mSATIxVTv92Ybc9xCDCED3rggTXbLQ80XyGxnpmqsyRfj49 aCQS+cUMO1lQI758gRVcxfIbyKGlPM/PQeQMFV9cW/SbNoHXdVK3i5SELwwXc4S24Ahv y4Uw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :message-id:in-reply-to:subject:cc:to:from:date; bh=O7xgOeGOlE8huwKhUijL/7H7azb4Xe5kb7v5L5amMlg=; b=VuumA21vKAAFiQo3Zr3Wv7NGZCjxLjRgi8cbOQmaY8Tz08Okq9TEwViQ94UHpKFWbj Y+f7UNlgRIjWZLixGZKBPRk9pCZxQMxhHoltfeTOTvVM7LFKwTVKyq21I8BAzBJVhII/ IsGhx6YHxCazlDmJ3nL6a+p8MMiRINOPYSfITzJnhiue4Y4DqL66YesRDYZcU35179fW 6TQtWCaRo0QT4YITHAWDlkf3vH+DQ4UQMZ70uoBqe3oM4ybigs5U96mGl4EH1yIe6ry9 jnrGG9IW0gtJBkBXf9Zs4yPUS/dvMpC19FnjtTM/27hIWkz0tTQVE3SLKMiPgbcmvuFD Yg9g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q2-v6si18382059plh.63.2018.10.17.11.22.52; Wed, 17 Oct 2018 11:23:08 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728140AbeJRCTR (ORCPT + 99 others); Wed, 17 Oct 2018 22:19:17 -0400 Received: from Galois.linutronix.de ([146.0.238.70]:60869 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727672AbeJRCTR (ORCPT ); Wed, 17 Oct 2018 22:19:17 -0400 Received: from p5492fe24.dip0.t-ipconnect.de ([84.146.254.36] helo=nanos) by Galois.linutronix.de with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1gCqSY-0004WC-Uy; Wed, 17 Oct 2018 20:22:19 +0200 Date: Wed, 17 Oct 2018 20:22:18 +0200 (CEST) From: Thomas Gleixner To: Borislav Petkov cc: Sebastian Andrzej Siewior , linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org, Tony Luck , linux-edac , x86@kernel.org Subject: Re: [PATCH 2/3] x86/mcelog: Remove one mce_helper definition In-Reply-To: <20181017171034.GO22571@zn.tnic> Message-ID: References: <20181017170554.18841-1-bigeasy@linutronix.de> <20181017170554.18841-3-bigeasy@linutronix.de> <20181017171034.GO22571@zn.tnic> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 17 Oct 2018, Borislav Petkov wrote: > On Wed, Oct 17, 2018 at 07:05:53PM +0200, Sebastian Andrzej Siewior wrote: > > Commit 5de97c9f6d85f ("x86/mce: Factor out and deprecate the /dev/mcelog > > driver") moved the old interface into one file including mce_helper > > definition as static and "extern". > > > > Cc: Tony Luck > > Cc: Borislav Petkov > > Cc: linux-edac > > Cc: x86@kernel.org > > Fixes: 5de97c9f6d85f ("x86/mce: Factor out and deprecate the /dev/mcelog driver") > > I'm not sure about the Fixes: tag - it'll trigger a flood of backporting > for no reason AFAICT. Not when there is no Cc: stable. If the stable folks pick up stuff nevertheless, shrug. The fixes tag is interesting even for stuff which does not go into stable because you can extract it properly and look at relations between original commit and fix. Thanks, tglx