Received: by 2002:ac0:a582:0:0:0:0:0 with SMTP id m2-v6csp987091imm; Wed, 17 Oct 2018 11:23:43 -0700 (PDT) X-Google-Smtp-Source: ACcGV614F7PzunssanrMtzg1Z/fENfm2ryz1fvdRIPNgnVnbWfQ942lKg2ty6M3WChsuKN7iwUoW X-Received: by 2002:a62:302:: with SMTP id 2-v6mr26892616pfd.145.1539800623023; Wed, 17 Oct 2018 11:23:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1539800622; cv=none; d=google.com; s=arc-20160816; b=HsUtQgdmr5JyBYQco0L4jJtadpqW2SAqpxBYi2T2e7lsn7rEXGI5yo+uwTmKTEmLfU YGdNfCUdK7rY25uMxDPyclj++tXHx2R8ttHAYkJnXwdB6dXouhkyOkXKbni4e/aXSHtf v8Ut1htsngRK7z6DuxGnDXm9TYmE8ZAMfwcd15pEbL/tQN1reZoLD3JTCXpLbvhSVc+4 VCT0+FqmbJ8mfA5lkAGvda+Cs/3mPTFCteL6Ura3jM16PpbtoAyHwbuDysjexWCaBX5l h1lLrgOYhaeW4N0d6Wle4N46aZ3kUQCT3JtVPbsFaqj+Oxf38ZCnJkxylYY5Ouxf71/o mIyw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=St5YcBu/Wt+szmj5yxOykH7cmb6yplNOTniBrc8FhR0=; b=KdqtfNvg0FAq2nEGm0nq0H/tiZdaR8ObNPscKH7AIQwg8+/WQGDsxoGPk7xzcrdeBQ HYaGX6EyrVPR/xRDQqDJK6X2F0F+zhLk/phCeTa4g9BU5V9DVND3KXCObI4eVFsKsZg9 bOBowdzv501QhK3jYU8Z70y7c6/kQW8SpoCvr+t3OiQpCKpe92bNC8PDUQK6n/C4DCC/ 5hkVKlJ+4lO5BUdNsSjlIJXfFb857fXoehhaBdQyllMFNut9Qw7DsYaiypzkxPFT9THp MsdoinQEV74Rd7VKmG8FFkWTspm/Y42v4XIcvrwGo6OxDoN7MAcFRaN49cfOtu3czkAf f7xg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w19-v6si11611706pgf.197.2018.10.17.11.23.27; Wed, 17 Oct 2018 11:23:42 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728192AbeJRCTx (ORCPT + 99 others); Wed, 17 Oct 2018 22:19:53 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47478 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727672AbeJRCTx (ORCPT ); Wed, 17 Oct 2018 22:19:53 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 1424988312; Wed, 17 Oct 2018 18:23:00 +0000 (UTC) Received: from treble (ovpn-122-46.rdu2.redhat.com [10.10.122.46]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0C0B42C7B7; Wed, 17 Oct 2018 18:22:55 +0000 (UTC) Date: Wed, 17 Oct 2018 13:22:54 -0500 From: Josh Poimboeuf To: Petr Mladek Cc: Jiri Kosina , Miroslav Benes , Jason Baron , Joe Lawrence , Evgenii Shatokhin , live-patching@vger.kernel.org, linux-kernel@vger.kernel.org, Jessica Yu Subject: Re: [PATCH v13 04/12] livepatch: Consolidate klp_free functions Message-ID: <20181017182254.3s3fzb72u2uazdfa@treble> References: <20181015123713.25868-1-pmladek@suse.com> <20181015123713.25868-5-pmladek@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20181015123713.25868-5-pmladek@suse.com> User-Agent: NeoMutt/20180716 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Wed, 17 Oct 2018 18:23:00 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 15, 2018 at 02:37:05PM +0200, Petr Mladek wrote: > @@ -637,6 +647,7 @@ static int klp_init_patch(struct klp_patch *patch) > mutex_lock(&klp_mutex); > > patch->enabled = false; > + INIT_LIST_HEAD(&patch->list); Is this a bug fix? If so, it should go in a separate patch. I'm wondering how this worked before. -- Josh