Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 17 Oct 2018 13:35:19 -0500
From:   Josh Poimboeuf <jpoimboe@redhat.com>
To:     Petr Mladek <pmladek@suse.com>
Cc:     Jiri Kosina <jikos@kernel.org>, Miroslav Benes <mbenes@suse.cz>,
        Jason Baron <jbaron@akamai.com>,
        Joe Lawrence <joe.lawrence@redhat.com>,
        Evgenii Shatokhin <eshatokhin@virtuozzo.com>,
        live-patching@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v13 05/12] livepatch: Refuse to unload only livepatches
 available during a forced transition
Message-ID: <20181017183519.wfc2n54ga6cyjhfi@treble>
References: <20181015123713.25868-1-pmladek@suse.com>
 <20181015123713.25868-6-pmladek@suse.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20181015123713.25868-6-pmladek@suse.com>
User-Agent: NeoMutt/20180716
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

I'm having trouble parsing the subject.  How about:

  Allow unloading of patches added after using 'force'

?

> --- a/kernel/livepatch/core.c
> +++ b/kernel/livepatch/core.c
> @@ -45,7 +45,8 @@
>   */
>  DEFINE_MUTEX(klp_mutex);
>  
> -static LIST_HEAD(klp_patches);
> +/* Registered patches */
> +LIST_HEAD(klp_patches);

Instead of making this non-static, can we just move
klp_force_transition() to core.c?  It's nice to have all the list
management code encapsulated in the same file.

-- 
Josh