Received: by 2002:ac0:a582:0:0:0:0:0 with SMTP id m2-v6csp1201778imm; Wed, 17 Oct 2018 15:23:00 -0700 (PDT) X-Google-Smtp-Source: ACcGV62+w3XKPow6VNj4xcI8Ozs9xKKNH6nsf+te3BFU0rM95WkhB34veHW8Ug28M0M3hTUEIyI3 X-Received: by 2002:a63:2643:: with SMTP id m64-v6mr25808288pgm.435.1539814980776; Wed, 17 Oct 2018 15:23:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1539814980; cv=none; d=google.com; s=arc-20160816; b=L1zCoeSxFoxNne64y3/i9pGy+UoHCpMiH6TqzKLxAK9t+unXlZ0YHi2bSOS5wOP6QI Xwm3GCX2o2peoGPf7AzvUDZSxBk9WBjw683qnc8Dqqngf9pyZLSl+NzRIC2MzKiILIG6 lwzihlYZOfPsNZMMqqLWb6YVcBSGF5qZ/1bqAEdgnitX6Oa4+h5/iUEwfguqvQ3u7cO5 aNIV8II8p67O4bwhd2KyzIBTITC1YbKnfW7g5vVbDfa6Le8WjY/8HG2WlQPrE1ohdImQ SZmhbepyqLmy7mKx8B/GVoBGAB/MijUBEntSfhowBgMusVsw21Omsg9DKB3SmVKNhimF duvw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:in-reply-to:date :references:subject:cc:to:from; bh=AKxl8VEMN8tv//4TpCC0u3WIY3HmMdnJ0xUG8WzY5ZE=; b=ihWKzIqgCtF5dW1QHe4Qnb+ctqJ8wSi6TN8m0pKa/rx2BDtnjlR9j283ZTkhzKlMvj VopSscRYfBTVca3pNjTjDvYJ1bfwHjNqBXCho4WFxPUysBo56ZpCwEmw81tjXp1TT4od H1wddbGSoYg1eEwSNOTMXRnIj8wGWTjaBSoYVvxXDtry50vBAvr178KCTm7me5fo69Xw Ty/2AJN7voDbPERKiVrZlWX/zsvZAbvWxQ58A/alOgeSdydOOaSIF/W+uQtuIDRXVe/E TjNPWeSVuaEqKBNVI0VBA97wqdNq6ol1NvMWL22mFqk1vBAPkOTB24PnHvq8Klo5Lbfq vN6g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b4-v6si19481151pfg.90.2018.10.17.15.22.45; Wed, 17 Oct 2018 15:23:00 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727397AbeJRGT5 (ORCPT + 99 others); Thu, 18 Oct 2018 02:19:57 -0400 Received: from albireo.enyo.de ([5.158.152.32]:49252 "EHLO albireo.enyo.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727014AbeJRGT5 (ORCPT ); Thu, 18 Oct 2018 02:19:57 -0400 Received: from [172.17.203.2] (helo=deneb.enyo.de) by albireo.enyo.de with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) id 1gCuCf-00067s-1H; Wed, 17 Oct 2018 22:22:09 +0000 Received: from fw by deneb.enyo.de with local (Exim 4.89) (envelope-from ) id 1gCuCe-0002Pg-Rh; Thu, 18 Oct 2018 00:22:08 +0200 From: Florian Weimer To: Andreas Dilger Cc: Miklos Szeredi , Michael Kerrisk , David Howells , Linux FS-devel Mailing List , Linux Kernel Mailing List , Linux API Subject: Re: statx(2) API and documentation References: <006890C4-64D4-4DE2-A1F0-335FFFD585BB@dilger.ca> Date: Thu, 18 Oct 2018 00:22:08 +0200 In-Reply-To: (Andreas Dilger's message of "Wed, 17 Oct 2018 14:22:57 -0600") Message-ID: <878t2wb4dr.fsf@mid.deneb.enyo.de> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Andreas Dilger: >> So what's the point exactly? > > Ah, I see your point... STATX_ALL seems to be mostly useful for the kernel > to mask off flags that it doesn't currently understand. It doesn't make > much sense for applications to specify STATX_ALL, since they don't have any > way to know what each flag means unless they are hard-coded to check each of > the STATX_* flags individually. They should build up a mask of STATX_* flags > based on what they care about (e.g. "find" should only request attributes > based on the command-line options given). Could you remove it from the UAPI header? I didn't want to put it into the glibc header, but was overruled.