Received: by 2002:ac0:a582:0:0:0:0:0 with SMTP id m2-v6csp1231741imm; Wed, 17 Oct 2018 16:02:11 -0700 (PDT) X-Google-Smtp-Source: ACcGV62/sZpdFAevKp4XrJttFnPeq+Ra8cg69uvLlkRVhD1opmz7pW4gHo8+TvllcZF8H3vmyg0R X-Received: by 2002:a63:1411:: with SMTP id u17-v6mr25681609pgl.247.1539817331150; Wed, 17 Oct 2018 16:02:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1539817331; cv=none; d=google.com; s=arc-20160816; b=WSEjRb4PROyiyc5RCriKrwq/CI9IMMZlr3RxQWWcn5Hym3ijQ6d4bQ3ufXJJ/HKspd X6cwFnPaOij5h8jAAb1DXTyPndBZJpkpOUwvW2m5ZTBFlEb7VxfCGOhn7iYTWHwWQy33 F0QjXoVdqMmR0tVsfXH+I0/iFqU2f2zyWxI9PssKmSArNPFuS8+EzebcCoqzHLilEtMT 46xyyXpfMH/NlMQVovsP2sg1lBFofEikiuXVBuOKfeRnw+LI4LnWzBtSCNWIH5kYSkWa Ls6Z9IwwYPL/pbS5twyEhK/1UsyXVMM82bSDnoWIJoXnX8amjn8YYGrWomLbIpngltEE F8gg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:references:message-id :in-reply-to:subject:cc:to:from:date; bh=woYu5FeOljfaIG4twB4Rfhta8901YvU01vxaN6LUnu0=; b=IigtZTSd0E+7qigjdHu63zEMchXMclS/m8c4jv/k4BsnwGLdBMPAOU8aYVV6jEu2Ye 0qsM6mfemHIJTBhdCmPvC7AP1eSw65u1HG7AyxQLh8/VGCl4vQz5/DmaQBFGLFsvaONE rcslgGztPTkEd8WriOTsuvh5ncr5e7zZtbZAgn/aID84ZgDl9AE1oVaQY11PyPW3SaVl XivvbFioCmUbR+RuPmvX5Jn/1TMTYfUdhhcBy8rNB3wUEoe3yxbM2MJHaymitnpCwim1 d1Zqsh69vV3jdnnHZ2V3EXwAG6L/pe1bCyXv3P+5uNIdKjSO4i9325wlFTJtODtsgvGx YioQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t62-v6si19937919pfj.53.2018.10.17.16.01.54; Wed, 17 Oct 2018 16:02:11 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727590AbeJRG7Z (ORCPT + 99 others); Thu, 18 Oct 2018 02:59:25 -0400 Received: from kvm5.telegraphics.com.au ([98.124.60.144]:40602 "EHLO kvm5.telegraphics.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727259AbeJRG7Y (ORCPT ); Thu, 18 Oct 2018 02:59:24 -0400 Received: from localhost (localhost.localdomain [127.0.0.1]) by kvm5.telegraphics.com.au (Postfix) with ESMTP id A389322C2D; Wed, 17 Oct 2018 19:01:25 -0400 (EDT) Date: Thu, 18 Oct 2018 10:01:22 +1100 (AEDT) From: Finn Thain To: Christoph Hellwig , Hannes Reinecke cc: "James E.J. Bottomley" , "Martin K. Petersen" , Michael Schmitz , Geert Uytterhoeven , linux-scsi@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 5/6] esp_scsi: De-duplicate PIO routines In-Reply-To: <20181017080923.GC24540@infradead.org> Message-ID: References: <35ac9f31-7068-ab93-4629-363ee0bb4c70@suse.de> <2b48c925-73f0-0ca0-2f3c-3c35d90010ba@suse.de> <20181017080923.GC24540@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 17 Oct 2018, Christoph Hellwig wrote: > > Please leave the possibly unused exports as-is. > I take that to mean "leave the conditional export as-is". Hence, I think v3 (posted on the 16th) should address all of the concerns raised by reviewers... --