Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20181005125154.19824-1-kraxel@redhat.com>
In-Reply-To: <20181005125154.19824-1-kraxel@redhat.com>
From:   Dave Airlie <airlied@gmail.com>
Date:   Thu, 18 Oct 2018 11:17:14 +1000
Message-ID: <CAPM=9twky-=a44GABrqi7prQjorzQRpLHQw8TOTc3Th83bjB1g@mail.gmail.com>
Subject: Re: [PATCH v2] virtio-gpu: add VIRTIO_GPU_F_EDID feature
To:     Gerd Hoffmann <kraxel@redhat.com>
Cc:     virtio-dev@redhat.com, KVM list <kvm@vger.kernel.org>,
        "Michael S. Tsirkin" <mst@redhat.com>,
        Dave Airlie <airlied@linux.ie>,
        Jason Wang <jasowang@redhat.com>,
        LKML <linux-kernel@vger.kernel.org>,
        dri-devel <dri-devel@lists.freedesktop.org>,
        "open list:VIRTIO CORE, NET..." 
        <virtualization@lists.linux-foundation.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Reviewed-by: Dave Airlie <airlied@redhat.com>
On Fri, 5 Oct 2018 at 22:52, Gerd Hoffmann <kraxel@redhat.com> wrote:
>
> The feature allows the guest request an EDID blob (describing monitor
> capabilities) for a given scanout (aka virtual monitor connector).
>
> It brings a new command message, which has just a scanout field (beside
> the standard virtio-gpu header) and a response message which carries the
> EDID data.
>
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
>  include/uapi/linux/virtio_gpu.h | 17 +++++++++++++++++
>  1 file changed, 17 insertions(+)
>
> diff --git a/include/uapi/linux/virtio_gpu.h b/include/uapi/linux/virtio_gpu.h
> index f43c3c6171..1cef1ff339 100644
> --- a/include/uapi/linux/virtio_gpu.h
> +++ b/include/uapi/linux/virtio_gpu.h
> @@ -41,6 +41,7 @@
>  #include <linux/types.h>
>
>  #define VIRTIO_GPU_F_VIRGL 0
> +#define VIRTIO_GPU_F_EDID  1
>
>  enum virtio_gpu_ctrl_type {
>         VIRTIO_GPU_UNDEFINED = 0,
> @@ -56,6 +57,7 @@ enum virtio_gpu_ctrl_type {
>         VIRTIO_GPU_CMD_RESOURCE_DETACH_BACKING,
>         VIRTIO_GPU_CMD_GET_CAPSET_INFO,
>         VIRTIO_GPU_CMD_GET_CAPSET,
> +       VIRTIO_GPU_CMD_GET_EDID,
>
>         /* 3d commands */
>         VIRTIO_GPU_CMD_CTX_CREATE = 0x0200,
> @@ -76,6 +78,7 @@ enum virtio_gpu_ctrl_type {
>         VIRTIO_GPU_RESP_OK_DISPLAY_INFO,
>         VIRTIO_GPU_RESP_OK_CAPSET_INFO,
>         VIRTIO_GPU_RESP_OK_CAPSET,
> +       VIRTIO_GPU_RESP_OK_EDID,
>
>         /* error responses */
>         VIRTIO_GPU_RESP_ERR_UNSPEC = 0x1200,
> @@ -291,6 +294,20 @@ struct virtio_gpu_resp_capset {
>         __u8 capset_data[];
>  };
>
> +/* VIRTIO_GPU_CMD_GET_EDID */
> +struct virtio_gpu_get_edid {
> +       struct virtio_gpu_ctrl_hdr hdr;
> +       __le32 scanout;
> +};
> +
> +/* VIRTIO_GPU_RESP_OK_EDID */
> +struct virtio_gpu_resp_edid {
> +       struct virtio_gpu_ctrl_hdr hdr;
> +       __le32 scanout;
> +       __le32 size;
> +       __u8 edid[1024];
> +};
> +
>  #define VIRTIO_GPU_EVENT_DISPLAY (1 << 0)
>
>  struct virtio_gpu_config {
> --
> 2.9.3
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel