Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To:     Icenowy Zheng <icenowy@aosc.io>
Cc:     devicetree@vger.kernel.org, Archit Taneja <architt@codeaurora.org>,
        Andrzej Hajda <a.hajda@samsung.com>,
        David Airlie <airlied@linux.ie>, linux-sunxi@googlegroups.com,
        linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
        Maxime Ripard <maxime.ripard@bootlin.com>,
        Chen-Yu Tsai <wens@csie.org>, Rob Herring <robh+dt@kernel.org>,
        linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 4/9] dt-bindings: Add ANX6345 DP/eDP transmitter binding
Date:   Thu, 18 Oct 2018 14:23:50 +0300
Message-ID: <2778638.na8ndVNUfi@avalon>
Organization: Ideas on Board Oy
In-Reply-To: <c68f0da9607805e1f6673a9a16a7dcfff4d8fe91.camel@aosc.io>
References: <20181018073327.64942-1-icenowy@aosc.io> <1886367.eljNk7jKYl@avalon> <c68f0da9607805e1f6673a9a16a7dcfff4d8fe91.camel@aosc.io>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Icenowy,

On Thursday, 18 October 2018 13:00:05 EEST Icenowy Zheng wrote:
> =E5=9C=A8 2018-10-18=E5=9B=9B=E7=9A=84 11:53 +0300=EF=BC=8CLaurent Pincha=
rt=E5=86=99=E9=81=93=EF=BC=9A
> > On Thursday, 18 October 2018 10:33:22 EEST Icenowy Zheng wrote:
> >> The ANX6345 is an ultra-low power DisplayPort/eDP transmitter
> >> designed
> >> for portable devices.
> >>=20
> >> Add a binding document for it.
> >>=20
> >> Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
> >> ---
> >>=20
> >>  .../bindings/display/bridge/anx6345.txt       | 39 +++++++++++++++++++
> >>=20
> >>  1 file changed, 39 insertions(+)
> >>  create mode 100644
> >>=20
> >> Documentation/devicetree/bindings/display/bridge/anx6345.txt
> >>=20
> >> diff --git
> >> a/Documentation/devicetree/bindings/display/bridge/anx6345.txt
> >> b/Documentation/devicetree/bindings/display/bridge/anx6345.txt new
> >> file
> >> mode 100644
> >> index 000000000000..0689d4eb5f65
> >> --- /dev/null
> >> +++ b/Documentation/devicetree/bindings/display/bridge/anx6345.txt
> >> @@ -0,0 +1,39 @@
> >> +Analogix ANX6345 eDP Transmitter
> >> +--------------------------------
> >> +
> >> +The ANX6345 is an ultra-low power Full-HD eDP transmitter designed
> >> for
> >> +portable devices.
> >> +
> >> +Required properties:
> >> +
> >> + - compatible		: "analogix,anx6345"
> >> + - reg			: I2C address of the device
> >> + - reset-gpios		: Which GPIO to use for reset
> >> +
> >> +Optional properties:
> >> +
> >> + - dvdd12-supply	: Regulator for 1.2V digital core power.
> >> + - dvdd25-supply	: Regulator for 2.5V digital core power.
> >=20
> > Shouldn't these to supplies be mandatory ?
>=20
> Yes they should.
>=20
> >> + - panel-supply		: Regulator for the power of the panel.
> >=20
> > Shouldn't the panel supply for specified in the DT node of the panel
> > ?
>=20
> However, eDP panel can be probed, may vary on the same device, and we
> don't have a generic binding for it...

Shouldn't we fix that ? :-)

> >> + - edid			: verbatim EDID data block describing
> >> attached
> >> +			  panel, only used when the panel has no EDID
> >> info.
> >=20
> > This should also be specified in the panel DT node.
> >=20
> > > + - Video port for RGB input, using the DT bindings defined in [1].
> >=20
> > I think you should also add a port for the output.
>=20
> What will it point to?

The panel DT node ?

> >> +[1]: Documentation/devicetree/bindings/media/video-interfaces.txt
> >> +
> >> +Example:
> >> +
> >> +anx6345: anx6345@38 {
> >> +	compatible =3D "analogix,anx6345";
> >> +	reg =3D <0x38>;
> >> +	reset-gpios =3D <&pio 3 24 GPIO_ACTIVE_HIGH>; /* PD24 */
> >> +	panel-supply =3D <&reg_dc1sw>;
> >> +	dvdd25-supply =3D <&reg_dldo2>;
> >> +	dvdd12-supply =3D <&reg_fldo1>;
> >> +
> >> +	port {
> >> +		anx6345_in: endpoint {
> >> +			remote-endpoint =3D <&tcon0_out_anx6345>;
> >> +		};
> >> +	};
> >> +};

=2D-=20
Regards,

Laurent Pinchart