Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 18 Oct 2018 08:00:55 -0500
From:   Josh Poimboeuf <jpoimboe@redhat.com>
To:     Petr Mladek <pmladek@suse.com>
Cc:     Jiri Kosina <jikos@kernel.org>, Miroslav Benes <mbenes@suse.cz>,
        Jason Baron <jbaron@akamai.com>,
        Joe Lawrence <joe.lawrence@redhat.com>,
        Evgenii Shatokhin <eshatokhin@virtuozzo.com>,
        live-patching@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v13 05/12] livepatch: Refuse to unload only livepatches
 available during a forced transition
Message-ID: <20181018130055.jopab5lxhej7ig4j@treble>
References: <20181015123713.25868-1-pmladek@suse.com>
 <20181015123713.25868-6-pmladek@suse.com>
 <20181017183519.wfc2n54ga6cyjhfi@treble>
 <20181018120947.py36o462zdqjknsm@pathway.suse.cz>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20181018120947.py36o462zdqjknsm@pathway.suse.cz>
User-Agent: NeoMutt/20180716
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Oct 18, 2018 at 02:09:47PM +0200, Petr Mladek wrote:
> On Wed 2018-10-17 13:35:19, Josh Poimboeuf wrote:
> > I'm having trouble parsing the subject.  How about:
> > 
> >   Allow unloading of patches added after using 'force'
> 
> ok
> 
> > > --- a/kernel/livepatch/core.c
> > > +++ b/kernel/livepatch/core.c
> > > @@ -45,7 +45,8 @@
> > >   */
> > >  DEFINE_MUTEX(klp_mutex);
> > >  
> > > -static LIST_HEAD(klp_patches);
> > > +/* Registered patches */
> > > +LIST_HEAD(klp_patches);
> > 
> > Instead of making this non-static, can we just move
> > klp_force_transition() to core.c?  It's nice to have all the list
> > management code encapsulated in the same file.
> 
> Come on! We need it just to iterate over a list of available
> livepatches. The logic used to manage this list is trivial.
> klp_force_transition() itself is more complicated and it
> logically fits into transitions.c.
> 
> I do not want to fight over this. If you resist, I'll move it.
> I just wanted to share my view.

I don't feel strongly about it.  It's just unfortunate that klp_patches
is no longer static.

-- 
Josh