Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 18 Oct 2018 08:34:25 -0500
From:   Josh Poimboeuf <jpoimboe@redhat.com>
To:     Petr Mladek <pmladek@suse.com>
Cc:     Jiri Kosina <jikos@kernel.org>, Miroslav Benes <mbenes@suse.cz>,
        Jason Baron <jbaron@akamai.com>,
        Joe Lawrence <joe.lawrence@redhat.com>,
        Evgenii Shatokhin <eshatokhin@virtuozzo.com>,
        live-patching@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v13 00/12] livepatch: Atomic replace feature
Message-ID: <20181018133425.o3ykjjuqede3mmht@treble>
References: <20181015123713.25868-1-pmladek@suse.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20181015123713.25868-1-pmladek@suse.com>
User-Agent: NeoMutt/20180716
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Oct 15, 2018 at 02:37:01PM +0200, Petr Mladek wrote:
> The atomic replace allows to create cumulative patches. They
> are useful when you maintain many livepatches and want to remove
> one that is lower on the stack. In addition it is very useful when
> more patches touch the same function and there are dependencies
> between them.
> 
> Now, the question is if 13 is a lucky number. I hope so
> and that this version might get merged. Any feedback?
>
> Not only from Mirek, please ;-)
> 
> 
> Changes against v12:
> 
>   + Finish freeing the patch using workqueues to prevent
>     deadlock against kobject code.
> 
>   + Check for valid pointers when initializing the dynamic
>     lists objects and functions.
> 
>   + Mark klp_free_objects_dynamic() static.
> 
>   + Improved documentation and fixed typos

Other than the few comments I made, this is looking good to me.  I'm
optimistic about v14.  It's probably best to not merge a v13 anyway. ;-)
Thanks a lot for sticking with it.

-- 
Josh