Received: by 2002:ac0:a582:0:0:0:0:0 with SMTP id m2-v6csp1999608imm; Thu, 18 Oct 2018 07:35:12 -0700 (PDT) X-Google-Smtp-Source: ACcGV63eFTOHRbdAupQ/BB7Co/QrgOTGd+sIKADJqdltE6IObNpzkSmcQUnYilXTPO7QYVAlsbJ7 X-Received: by 2002:a17:902:720b:: with SMTP id ba11-v6mr29824763plb.199.1539873312839; Thu, 18 Oct 2018 07:35:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1539873312; cv=none; d=google.com; s=arc-20160816; b=XPg8UMo9cZg1oqLFv5zzKXm5LFtKR28BAaTxv8JwIwTP84sg7akcgOJPNL7zV5PA5G z9xFVHRxle/1Sqnh9IE0/CbzflAEHOH2DUAnldJVIOByaswNXX6ZE7dFNld+UPBaLN1h 69WiIpgQeJExE1kmqiKLh47DRuU7gOkW6OLgd/CYAsXeO9aqowE3ti/2SfrKGD7u0LyB +nuELwKqOZGRut0A9Yf0W2FZ7KcBPkBg1zB1iJ6BXWMHvg7rsZk6tlvRQa2+kPNUWMAE mRbXFZ2NbcrTyl+tUF8FJbWoLk+3FBaGB7nBJXwsajR6Eztn1aMwlXiWj40MHShJ6nwd JeCQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :references:in-reply-to:mime-version:dkim-signature; bh=bQRHlQoLTxwmrkimcY08YV//USDmQx/epjTInfxcZiw=; b=KZu4/PyVKYOMRBE4ocHPtNDAmvKv805l6yO5FRTGNfyfrTXstudaELdB6EkTuVx+Rd iLUHx2vxvMdqWHkvVySezSMnn4qqtji7+7GYwHY6NbR7MbkwutFF92eIZcDkd04oflNn QZDM0AIgicMzbQpmhC+O0xCNXL6mpsJt936lwhvU+TiUQH2RIN58E8tf2T1qtc38HjLy 8PxCz9wnSTF8hbQDFtTPhvlMnUpRf6FZ7FkiUk8Vw1LFG21hcs23iKGbS70eDR3wvmnq mf/PVyJkcKtAkkAyNU7mbslV4sjlz/M+A5+JWvCzqZY9z3mzxmT9YvjnNRwszhLaZiCe ccgA== ARC-Authentication-Results: i=1; mx.google.com; dkim=temperror (no key for signature) header.i=@szeredi.hu header.s=google header.b="p6/TP1vz"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e13-v6si21037262pff.272.2018.10.18.07.34.56; Thu, 18 Oct 2018 07:35:12 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=temperror (no key for signature) header.i=@szeredi.hu header.s=google header.b="p6/TP1vz"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728303AbeJRWfs (ORCPT + 99 others); Thu, 18 Oct 2018 18:35:48 -0400 Received: from mail-it1-f195.google.com ([209.85.166.195]:36396 "EHLO mail-it1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728253AbeJRWfs (ORCPT ); Thu, 18 Oct 2018 18:35:48 -0400 Received: by mail-it1-f195.google.com with SMTP id c85-v6so604996itd.1 for ; Thu, 18 Oct 2018 07:34:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=szeredi.hu; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=bQRHlQoLTxwmrkimcY08YV//USDmQx/epjTInfxcZiw=; b=p6/TP1vz33iC/nYMOFCnAQtrhl60PXbapHNlDhPTpp0gQEPGeQ2ekw85X3A9D5ZNvY JjFJocOpOpQZMQBcwUBoOGZdG+3BA1/LGpEbc0SMS/IjnZt1cfTUsra+XA9IgMDLRUOQ IoT2BYAVHPa0FZ+3UB62nbrYZQnadk45WBIyQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=bQRHlQoLTxwmrkimcY08YV//USDmQx/epjTInfxcZiw=; b=Ig6sKqHG9xfep2pqzWra48mTgyAMJI6OERsgJPtkC38IsswStyUF2BDBcfVadAM1sO 75jKjMwKAgMNL07PpQ03MmBLX3bDsWYK4t7+dTdr61SL2QqE3WX6unk5V00ShbqkC1lh I7RMfpF8cZyNf0L6DabSMdyTQjMqJEkpK2Q/60hFYgTN2GvVZaR7fQbqcOaLAkjO2r8a 8ZQ2/MpnB3axJ4oSUUZ3HDvOsbEVQPp1Djp36jv+iT0V2FeoxfoOI8NeeZ3OPEnGaF/t VnFiFB51wL+D3PLlayWhXmCUh4FRbujZomf/OyKx7nDPUd5kt2zboYVyAzR1Afgy52I0 DkVg== X-Gm-Message-State: ABuFfohHKLEnqzkDTROpAoQDK3g9EI/5S/b6xXqPJNkSXUi0U/tnKxRl CDlEAPxNijGdtOy4PbvmQaSfEwAv+5piglR+vQPbVg== X-Received: by 2002:a02:1818:: with SMTP id k24-v6mr23122273jad.77.1539873270756; Thu, 18 Oct 2018 07:34:30 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a6b:bf41:0:0:0:0:0 with HTTP; Thu, 18 Oct 2018 07:34:30 -0700 (PDT) X-Originating-IP: [212.96.48.140] In-Reply-To: References: <20181018131125.6303-1-mszeredi@redhat.com> <20181018131125.6303-2-mszeredi@redhat.com> <875zxzxuo9.fsf@mid.deneb.enyo.de> From: Miklos Szeredi Date: Thu, 18 Oct 2018 16:34:30 +0200 Message-ID: Subject: Re: [PATCH 2/3] uapi: get rid of STATX_ALL To: Florian Weimer Cc: Miklos Szeredi , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Linux API , David Howells , Michael Kerrisk , Andreas Dilger , Amir Goldstein Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 18, 2018 at 4:32 PM, Miklos Szeredi wrote: > On Thu, Oct 18, 2018 at 3:15 PM, Florian Weimer wrote: >> * Miklos Szeredi: >> >>> #define STATX__RESERVED 0x80000000U /* Reserved for future struct statx expansion */ >> >> What about this? Isn't it similar to STATX_ALL in the sense that we >> don't know yet what it will mean? > > Kernel will return -EINVAL if request_mask contains STATX__RESERVED, > so it's definitely different from other flag values. > > Specifying this in the UAPI sort of implies that other flag values > will *not* need a struct statx expansion, so it's safe to pass in any > random value not containing STATX__RESERVED on any past or future > kernel and it will not write beyond the current struct statx boundary. > Not sure if that's a useful thing or not, but it's not actively > harmful, like the STATX_ALL flag. In other words, if STATX_ALL was defined as 0x7fffffff, then that would mean the same thing, and I wouldn't complain about it. Thanks, Miklos