Received: by 2002:ac0:a582:0:0:0:0:0 with SMTP id m2-v6csp2027213imm; Thu, 18 Oct 2018 08:00:52 -0700 (PDT) X-Google-Smtp-Source: ACcGV63yGJG5o/1OXMSPrYvKdMU/mChfvTMQ2VrK2Fm9DKD/H0Phqg6Fn4S974/InFgXW1VDnADF X-Received: by 2002:a17:902:7798:: with SMTP id o24-v6mr29590005pll.299.1539874852117; Thu, 18 Oct 2018 08:00:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1539874852; cv=none; d=google.com; s=arc-20160816; b=n9/m+dKshS3ffPhCb5g+hupnJ17kqZHAO7CDqicAaBJ+SzAIjxE6s2p0ka4iGHz057 XvZfjIm9OABV+A5bIf4NviuBa6La8tKWQGgEk5qa3xKGtY8dlMT4TFRPirg0i4fKlmr/ SL3SPEQJT+K4wl5cgz8TKXS6jCTLCVrfISA59jCtlU8JMabJ04PlEr11KvRzDDZDAlCL WDehWuMRGPtJYFQaLhC4fefmqx7o6l+NatRu/qoT5Hl2jrm96y8tdTscAQyMzvM3BBKp ErLIfJi1V17rIP6sdtJdHzC7J/SBsUMC+XZ0o0PyOsry1w0RvqYH1RDb4r5A1GcSDd8W A+Dg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:mail-followup-to :message-id:subject:cc:to:from:date; bh=U4x07+X78151IvyYEU7AXY4TYTvflz2EftySqtM5m98=; b=wNPw9Yd24clmqTHK7f9CoaKPhb1mL99AjSKOJPJseCrHFrD5u0tQEV6HFvudlwJSI/ wi3Dcte00DsEnzr1qpH8Hs0UwzAPFs3STb2CHCDnt3feTe/lj3pvjrwd2KFFBgfCAn2s sui3CvIEiXzGORXrf7lJLUH+FvVElkqhvsmUXNN2IVMYwdB1IDAkXkZ5NUpZ8wedOB50 sK2GTXVjvSr3xl02ir7qJG9cJnPOaD9F3FLbMpwr8yudEGGP1ygEVKNi2B4kxXEYoJDw 6ftGrr4wk/GxqQ7OpV5rB3n66jcpVzCCP950Zvb3rBZXoRGtPuj3OiWyzbuausqRU+MD lnoQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f2-v6si20649260plr.153.2018.10.18.08.00.35; Thu, 18 Oct 2018 08:00:52 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728747AbeJRXAu (ORCPT + 99 others); Thu, 18 Oct 2018 19:00:50 -0400 Received: from scorn.kernelslacker.org ([45.56.101.199]:49624 "EHLO scorn.kernelslacker.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727370AbeJRXAt (ORCPT ); Thu, 18 Oct 2018 19:00:49 -0400 Received: from [2601:196:4600:5b90:ae9e:17ff:feb7:72ca] (helo=wopr.kernelslacker.org) by scorn.kernelslacker.org with esmtp (Exim 4.89) (envelope-from ) id 1gD9lj-0000PK-7g; Thu, 18 Oct 2018 10:59:23 -0400 Received: by wopr.kernelslacker.org (Postfix, from userid 1026) id DF910560296; Thu, 18 Oct 2018 10:59:22 -0400 (EDT) Date: Thu, 18 Oct 2018 10:59:22 -0400 From: Dave Jones To: Meelis Roos Cc: Cong Wang , LKML , Linux Kernel Network Developers Subject: Re: netconsole warning in 4.19.0-rc7 Message-ID: <20181018145922.ytqxvdihp3iqounl@codemonkey.org.uk> Mail-Followup-To: Dave Jones , Meelis Roos , Cong Wang , LKML , Linux Kernel Network Developers References: <20181017034047.nrhstc3b4wzevnri@codemonkey.org.uk> <20181017035038.czaqown24rnjn2pw@codemonkey.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) X-Spam-Note: SpamAssassin invocation failed Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 17, 2018 at 09:22:13AM +0300, Meelis Roos wrote: > > I took another look at that error path. Turns out this is all we need I > > think.. > > With this patch applied on top of 4.19-rc8, I stll get the warning: > > [ 13.722919] WARNING: CPU: 0 PID: 0 at kernel/softirq.c:168 __local_bh_enable_ip+0x2e/0x44 It's going to be a couple days before I get chance to get back to this. Did the previous patch in this thread (without the _bh) fare any better? Dave