Received: by 2002:ac0:a582:0:0:0:0:0 with SMTP id m2-v6csp2036867imm; Thu, 18 Oct 2018 08:07:39 -0700 (PDT) X-Google-Smtp-Source: ACcGV60DeF3Gwvth9bMZOB1vrQEzVs2vgjvze5NPuARy0LkoEob9HME7GRU0/q+UxUB/NXPBs+Qx X-Received: by 2002:a62:438c:: with SMTP id l12-v6mr30910803pfi.175.1539875259629; Thu, 18 Oct 2018 08:07:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1539875259; cv=none; d=google.com; s=arc-20160816; b=dkj+Ry9Ri1wWDgB0kqINrDZalBI3fW7Z7aM3fSETzHWhsh1nlKMIIrQYyRRj1M/Twa Tf1meRPjiwvzm0j2RMF2l4R5s46AiLCiem+poca2RK+gX7tO/8cYpeONkIU3DBHPcGIv +6l2r1Q6uA+KU663q0RYUduE3k4vQ7phFODCV2WTzpmSzGgoLNIIIz1JcE9LgDvGFJPG /wKN2u98zDyEHM0mu1mbbGZkk0tTw72CyybTPy5c3ijrKcQV3HBi/TFzrmgK4b/aYxOu JvN0DTRD4bQHranehIzb3fm6OQ7S0qtplT/hGMI3N3nw4sL4AOCCQ4RxTXHxbgIUR3DE wvEQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature; bh=hfIEmy/L0yThNprHRfv0ehO65sgCJvSFBVK5lgm1vLk=; b=g715Qb/NodW+unrzHlJeOqpVQE/OmHMKPt2pxvLk2NutW8AIwRab7vzJeZIi2DFv8I sUlUS34IjLEo0uvcELHCvPGSwN/0fTP8nMLlS/eUBliUGU0DDIGx4Oou5M4UJkXXNppd UR9qr2s/iV98IMz43BfDbKE7zJGoZneMyrniD2G7KTDxnaDB0hi537ruo3R4Kzr4q2RN l8PvlVWnsE2MDhYZhHaZ7TcGf86VIkjsCgweUT9R5HjgnubdCGpI8gyFuv2p32bzr1jX UH8ovD7bCgZhd9r0VN4yYYfLCCI2WuwnJDNbSqeXmtgxqj6jkvO3H4iEPZl2cUye2oAy dWLw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@baylibre-com.20150623.gappssmtp.com header.s=20150623 header.b=iJdlXUvt; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z127-v6si15773978pgb.118.2018.10.18.08.07.23; Thu, 18 Oct 2018 08:07:39 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@baylibre-com.20150623.gappssmtp.com header.s=20150623 header.b=iJdlXUvt; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727601AbeJRXGm (ORCPT + 99 others); Thu, 18 Oct 2018 19:06:42 -0400 Received: from mail-wr1-f67.google.com ([209.85.221.67]:37318 "EHLO mail-wr1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727008AbeJRXGm (ORCPT ); Thu, 18 Oct 2018 19:06:42 -0400 Received: by mail-wr1-f67.google.com with SMTP id q1-v6so1181132wrs.4 for ; Thu, 18 Oct 2018 08:05:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id; bh=hfIEmy/L0yThNprHRfv0ehO65sgCJvSFBVK5lgm1vLk=; b=iJdlXUvtS4BoJ0dkUwWZ9nBCRZfl71dYK8wzKt4F8c6qU/1JXWIjV6gY35GkWBlXXM gdesF002/RzcKx+lrIrkITgvQ6mEOyNA5TkjzP5G+Z2rww6c/eojy4ESuAYY+RUplLuL iOigWQhM5/U8wTCpjuK1rQEwDO7mrBFtpyTXey3eFRsI3zdUy4aoyBfwa1bk3ec7tNIy D5XfJOF1Jjh5QYUbImJZliwkpQxIdOOY6FzDvH0PrfbYlI2vTh7rYmDvlp6DWK5CpR62 PMWq9sY1ilUylhDWyQI7bQLw1BC0hbojg0navv5VQVeE+jtGGVmuNpLoxIHvVgLf7Y2I rr1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=hfIEmy/L0yThNprHRfv0ehO65sgCJvSFBVK5lgm1vLk=; b=VTubbZRNVT7tGxU+dKMwWiMqgRtDoKaao7QvDdmw+rG/eOCiMDnSqRHmuEJ4Tue0S7 ljNj0AU9c8mslZt94JqYJjjEYeT9Q+hX6WDfHDnjm6AofV1WE+rPnl6YJI67y4hRItMt CgdL3QpQY8n5ppSF5g6EN9vrN/LoQ5upwIxoqew53N1Z7rImUEDJSfTX4nYtAnd8Q10i YCoZ3c30a91vzy0SMAnBkKSzfz0lpgqorGQw+xyFgROItkG/dIg8YNUFDVsX95RzwZaV l7oE51rlXz90ewdJpMwjaQPJiQLiT2Jxx8/JXEuanvRfe6BbBz82uXNW3/RXBgHWW6L4 +DVA== X-Gm-Message-State: ABuFfohkZdCUHN1QFIQnfcYt5PU1XsA9HIqHN+yop7dcmLIV81uNNsQb aZUdu4RVzVKQKwET7/p2ZZp1v55kjOQ= X-Received: by 2002:a05:6000:1105:: with SMTP id z5mr28272690wrw.136.1539875116159; Thu, 18 Oct 2018 08:05:16 -0700 (PDT) Received: from localhost.localdomain ([51.15.160.169]) by smtp.googlemail.com with ESMTPSA id b71-v6sm685272wma.13.2018.10.18.08.05.14 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 18 Oct 2018 08:05:15 -0700 (PDT) From: Corentin Labbe To: andrew@lunn.ch, davem@davemloft.net, f.fainelli@gmail.com, fugang.duan@nxp.com Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Corentin Labbe Subject: [PATCH] net: ethernet: fec: Add missing SPEED_ Date: Thu, 18 Oct 2018 15:05:00 +0000 Message-Id: <1539875100-11121-1-git-send-email-clabbe@baylibre.com> X-Mailer: git-send-email 2.7.4 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Since commit 58056c1e1b0e ("net: ethernet: Use phy_set_max_speed() to limit advertised speed"), the fec driver is unable to get any link. This is due to missing SPEED_. Fixes: 58056c1e1b0e ("net: ethernet: Use phy_set_max_speed() to limit advertised speed") Signed-off-by: Corentin Labbe --- drivers/net/ethernet/freescale/fec_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c index a17cc97..75fd7c9 100644 --- a/drivers/net/ethernet/freescale/fec_main.c +++ b/drivers/net/ethernet/freescale/fec_main.c @@ -1946,7 +1946,7 @@ static int fec_enet_mii_probe(struct net_device *ndev) /* mask with MAC supported features */ if (fep->quirks & FEC_QUIRK_HAS_GBIT) { - phy_set_max_speed(phy_dev, 1000); + phy_set_max_speed(phy_dev, SPEED_1000); phy_remove_link_mode(phy_dev, ETHTOOL_LINK_MODE_1000baseT_Half_BIT); #if !defined(CONFIG_M5272) @@ -1954,7 +1954,7 @@ static int fec_enet_mii_probe(struct net_device *ndev) #endif } else - phy_set_max_speed(phy_dev, 100); + phy_set_max_speed(phy_dev, SPEED_100); fep->link = 0; fep->full_duplex = 0; -- 2.7.4