Received: by 2002:ac0:a582:0:0:0:0:0 with SMTP id m2-v6csp2055978imm;
        Thu, 18 Oct 2018 08:23:16 -0700 (PDT)
X-Google-Smtp-Source: ACcGV60jxCmOsaM7SMrIK4VXwcecAVvRAcMyW0bYeqEpVZlxG9hNdFzk2nJ9hgvCljBC/MNO8MBg
X-Received: by 2002:a62:6414:: with SMTP id y20-v6mr30990246pfb.213.1539876195950;
        Thu, 18 Oct 2018 08:23:15 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1539876195; cv=none;
        d=google.com; s=arc-20160816;
        b=vqS2Jo0nWVE7ddoxOjKldpifkj0R4Wu0rc8BwWhPSvsNPS/6NQ+0pAc/qyXzCZ5+g0
         C4ujCPgtiYGh7WkL3Ih+3LdxXuqnMtxdUmPxNfTAf7uBaEdyBLwutG9n4XWweTPe8gq1
         i0PHYDBHHyykxGoHox9ir8RdixH/HNGoMQSLdwhteVowoqmeDLA00L/2Lkt5G1qgwtKu
         s32bmsEsRCVxt4sBgclpoPbuLg+stBxHUU3U1iuUStaVAz73DUzyqwy6RvZnpwITi+fk
         L0d7pcxaCem9ZUDE7W77ttSmic+sqFo8Ex9bERDZz1Z4pImVzN2PJnSQygvuA/wldssg
         66ag==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:message-id:date:content-id:mime-version
         :subject:cc:to:references:in-reply-to:from:organization;
        bh=jNFkTrTntkg11NQs7v+O7VFCwm2rx+P/XKSUzK2bpkM=;
        b=vTKiGNwDZIMtKw3k6Nf5/0DMMQzPKUIzBpzaZJkHF1ZBcrkLFyjosPoplijX4G68gA
         maujCVJQ6dTU6rgeRZ7ojVeWhr38QCp4V892DoglCfIREVa36RQz9iOKSSPYUERaMn4g
         xYH6eSgvrUH9xzNcUNtVLNiQ7B2n3iZBbA1tsvlh0+vnhVCjjPh+dyGIGO/JXWJ36w9/
         3YwCm1XCkLGCgWcM7QpEOtfQ71ioxaucblbpZRMdiacLNX1jyZPHeCbaJ2wvZ854dJQU
         uvvJ7xrZfVb7jBHnrL5mDSltWHJ7KdzabSU+cLvZ4FyKouce8ZV4bc3JM6JfyiXMGt45
         mRSw==
ARC-Authentication-Results: i=1; mx.google.com;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67])
        by mx.google.com with ESMTP id z70-v6si20663162pfi.214.2018.10.18.08.22.59;
        Thu, 18 Oct 2018 08:23:15 -0700 (PDT)
Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Authentication-Results: mx.google.com;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1728194AbeJRXYI (ORCPT <rfc822;zjuysxie86@gmail.com>
        + 99 others); Thu, 18 Oct 2018 19:24:08 -0400
Received: from mx1.redhat.com ([209.132.183.28]:56753 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1727105AbeJRXYI (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 18 Oct 2018 19:24:08 -0400
Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16])
        (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
        (No client certificate requested)
        by mx1.redhat.com (Postfix) with ESMTPS id A31323DBEA;
        Thu, 18 Oct 2018 15:22:38 +0000 (UTC)
Received: from warthog.procyon.org.uk (ovpn-120-250.rdu2.redhat.com [10.10.120.250])
        by smtp.corp.redhat.com (Postfix) with ESMTP id 8608161D3B;
        Thu, 18 Oct 2018 15:22:36 +0000 (UTC)
Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley
        Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United
        Kingdom.
        Registered in England and Wales under Company Registration No. 3798903
From:   David Howells <dhowells@redhat.com>
In-Reply-To: <20181018131125.6303-3-mszeredi@redhat.com>
References: <20181018131125.6303-3-mszeredi@redhat.com> <20181018131125.6303-1-mszeredi@redhat.com>
To:     Miklos Szeredi <mszeredi@redhat.com>
Cc:     dhowells@redhat.com, linux-fsdevel@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-api@vger.kernel.org,
        Michael Kerrisk <mtk.manpages@gmail.com>,
        Andreas Dilger <adilger@dilger.ca>,
        Florian Weimer <fw@deneb.enyo.de>,
        Amir Goldstein <amir73il@gmail.com>
Subject: Re: [PATCH 3/3] statx: add STATX_ATTRIBUTES flag
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1683.1539876155.1@warthog.procyon.org.uk>
Date:   Thu, 18 Oct 2018 16:22:35 +0100
Message-ID: <1684.1539876155@warthog.procyon.org.uk>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Thu, 18 Oct 2018 15:22:38 +0000 (UTC)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Miklos Szeredi <mszeredi@redhat.com> wrote:

> +	/* Having anything in attributes_mask means attributes are valid. */
> +	if (tmp.stx_attributes_mask)
> +		tmp.stx_mask |= STATX_ATTRIBUTES;

That would be superfluous, since userspace can make this check too.

Note that fsinfo() might inform you better - if and when it arrives.

David