Received: by 2002:ac0:a582:0:0:0:0:0 with SMTP id m2-v6csp2173447imm; Thu, 18 Oct 2018 10:09:15 -0700 (PDT) X-Google-Smtp-Source: ACcGV60hKxqtaZIJ3YXJfaXrT6aukkUUp3SIlkuDQxXo/Qh0sd+abnhjW/hxlUAdhyAKHY2fBQq8 X-Received: by 2002:a62:5c03:: with SMTP id q3-v6mr31903584pfb.182.1539882555454; Thu, 18 Oct 2018 10:09:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1539882555; cv=none; d=google.com; s=arc-20160816; b=MODeAOepzXeCtu31fjhBgqAZw8yWxprOhJyJpf7Gx4+NFUDLubE7j82PJX0nFjMAcr hbOmD6XZY1x6EFvXdW+w24ykwuQX2X4GWTCOwWQ4WUjzfEuVo8wpIK2LOmEe4/LHDJLe 4n+080ayAtnAvNc4oj2arlJbqy2cBwOB/h8aJxuQCHfFFldPIeOlCXrhuKiQX4AClfe3 AismxLGcqNdEkx9HenEl6gLLK3PF6fgCHGSm3d5yJnS7CojTF2sNbXgYjb9TgAT+nPdS Nu9KRYOzKz+0j4oRcIuqPTYEH1lu3atWuRoy+F5CZkeYsApG0tmCedwmMT7dqOVhjjq/ JXJA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:subject:user-agent:message-id :references:cc:in-reply-to:from:to:content-transfer-encoding :mime-version:dkim-signature; bh=Xji15WCvkz8jtexVIrZ89ecdv7xzzT4QS6dACpUATXA=; b=Oiy+eks+XaBp2cma6beXWwEMAwgGtaKl8I1Uyv77V60nUwT3dGVCboL6i0PIrzMXaJ TCWkLVa+0/vHNaZaujBoJS5CIRTpWLJRHBWDm6btzfoV+hVt7uxNyngrYUSCKRMqlZqB sroDSRBMaPuNvPQVMmc9ctv28hQVkpXCrisTMBKvTjPVBkt/CX15p8u13IV8K4EXaMBt XShWXe1M0wszG/zrONy5hUKUij8BIxIfjMp/jJzBJsMdkbhWhBmVk0XOJzMiiT2Y34g/ WoOhDkLOgX4uVx9xA3m9RXSW5iHXbbbHf71UX90n0vg/iGU1skrd28+ZgpX9AwzgTWJA EX5g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=XNKoju1R; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z1-v6si20768447plo.59.2018.10.18.10.08.58; Thu, 18 Oct 2018 10:09:15 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=XNKoju1R; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728356AbeJSBKA (ORCPT + 99 others); Thu, 18 Oct 2018 21:10:00 -0400 Received: from mail.kernel.org ([198.145.29.99]:38104 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727391AbeJSBKA (ORCPT ); Thu, 18 Oct 2018 21:10:00 -0400 Received: from localhost (unknown [104.132.0.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 880FC2064A; Thu, 18 Oct 2018 17:08:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1539882486; bh=kMVnnAObjEjuj+QeITgrePTDMcP+VY4qnWj8KwAP45g=; h=To:From:In-Reply-To:Cc:References:Subject:Date:From; b=XNKoju1R21Mv/AQVA4jdH+QGymTnvsznQq+DcUdCUuZho52zWO7QuyTH9+OSOx9T2 hGtWz+BBbIk+qLZmnccxsfxJ4CqqLaOXNGtOMxOsGu+LZeWdhAFeN114S+8TZYfQO7 X1OajeUgtpIlSW+YJvjW4O7udHqvhUH5tqU42ek0= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable To: Jerome Brunet , Jianxin Pan , Neil Armstrong From: Stephen Boyd In-Reply-To: <1539839245-13793-3-git-send-email-jianxin.pan@amlogic.com> Cc: Yixun Lan , Jianxin Pan , Kevin Hilman , Carlo Caione , Michael Turquette , Rob Herring , Miquel Raynal , Boris Brezillon , Martin Blumenstingl , Liang Yang , Jian Hu , Qiufang Dai , Hanjie Lin , Victor Wan , linux-clk@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <1539839245-13793-1-git-send-email-jianxin.pan@amlogic.com> <1539839245-13793-3-git-send-email-jianxin.pan@amlogic.com> Message-ID: <153988248599.5275.8444799485095155762@swboyd.mtv.corp.google.com> User-Agent: alot/0.7 Subject: Re: [PATCH v5 2/3] clk: meson: add DT documentation for emmc clock controller Date: Thu, 18 Oct 2018 10:08:05 -0700 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Jianxin Pan (2018-10-17 22:07:24) > diff --git a/Documentation/devicetree/bindings/clock/amlogic,mmc-clkc.txt= b/Documentation/devicetree/bindings/clock/amlogic,mmc-clkc.txt > new file mode 100644 > index 0000000..9e6d343 > --- /dev/null > +++ b/Documentation/devicetree/bindings/clock/amlogic,mmc-clkc.txt > @@ -0,0 +1,31 @@ > +* Amlogic MMC Sub Clock Controller Driver > + > +The Amlogic MMC clock controller generates and supplies clock to support > +MMC and NAND controller > + > +Required Properties: > + > +- compatible: should be: > + "amlogic,gx-mmc-clkc" > + "amlogic,axg-mmc-clkc" > + > +- #clock-cells: should be 1. > +- clocks: phandles to clocks corresponding to the clock-names property > +- clock-names: list of parent clock names > + - "clkin0", "clkin1" > + > +Parent node should have the following properties : The example only has one node. Can you add two nodes? > +- compatible: "amlogic,axg-mmc-clkc", "syscon". > +- reg: base address and size of the MMC control register space. > + > +Example: Clock controller node: > + > +sd_mmc_c_clkc: clock-controller@7000 { > + compatible =3D "amlogic,axg-mmc-clkc", "syscon"; > + reg =3D <0x0 0x7000 0x0 0x4>; > + #clock-cells =3D <1>; > + > + clock-names =3D "clkin0", "clkin1"; > + clocks =3D <&clkc CLKID_SD_MMC_C_CLK0>, > + <&clkc CLKID_FCLK_DIV2>; > +};