Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
To:     Chen-Yu Tsai <wens@csie.org>, Icenowy Zheng <icenowy@aosc.io>,
        Maxime Ripard <maxime.ripard@bootlin.com>
From:   Stephen Boyd <sboyd@kernel.org>
In-Reply-To: <20181018070729.52943-1-icenowy@aosc.io>
Cc:     linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com,
        Icenowy Zheng <icenowy@aosc.io>
References: <20181018070729.52943-1-icenowy@aosc.io>
Message-ID: <153988319489.5275.13596491306786109572@swboyd.mtv.corp.google.com>
User-Agent: alot/0.7
Subject: Re: [PATCH v2] clk: sunxi-ng: enable so-said LDOs for A64 SoC's pll-mipi
 clock
Date:   Thu, 18 Oct 2018 10:19:54 -0700
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Quoting Icenowy Zheng (2018-10-18 00:07:29)
> In the user manual of A64 SoC, the bit 22 and 23 of pll-mipi control
> register is called "LDO{1,2}_EN", and according to the BSP source code
> from Allwinner , the LDOs are enabled during the clock's enabling
> process.
> =

> The clock failed to generate output if the two LDOs are not enabled.
> =

> Add the two bits to the clock's gate bits, so that the LDOs are enabled
> when the PLL is enabled.
> =

> Fixes: c6a0637460c2 ("clk: sunxi-ng: Add A64 clocks")
> Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
> ---

Looks OK to me from not knowing anything about this driver. Shall I pick
directly into clk-next for next release?