Received: by 2002:ac0:a582:0:0:0:0:0 with SMTP id m2-v6csp2353241imm; Thu, 18 Oct 2018 13:11:57 -0700 (PDT) X-Google-Smtp-Source: ACcGV631+oodPJquE+Ecf/ht+H2v6VDz7nQsLSFW56yQwfyb2GN94IWB7Hb+FVJk2ZIdGZg67Ej5 X-Received: by 2002:a63:1806:: with SMTP id y6-v6mr30250362pgl.187.1539893517518; Thu, 18 Oct 2018 13:11:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1539893517; cv=none; d=google.com; s=arc-20160816; b=p8kp+AsaTF+adgzbi6qA7X3Z5jzRqmZY4gFc8sG1z7R1HotO3jhpP1/wAOf1EjaPh2 sW+fKCk9L/O6swk3C9Vmdgrax/ewYWwrSeR2CQBQuxbSM9/WBtttlp9zFky/KdUVwU6o JiKV3vEl1rZPkVBn+U2tYA1fTrQ9wBR9isaUW3Dpr/pVaWpAYf5+jiiouMoD31RbtkrS Za9pgQ1ZGsJ9/gOnW4juevU6DhMs9woIsUaPo1+nsOCB9zgEMkR5fjPmTFrvT90ecKaD vqJ6yVJsZqwyUqLm48gPFmpQ6D+3A1o6psiT4UwK8LsCtou26YEM7dT422J8zSksz+kN g+ZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:content-transfer-encoding :mime-version:subject:cc:to:references:in-reply-to:from:organization; bh=bOxOtEB6mUuXUBBiUqPfweuhX4qpquUFjQP9BjR5asM=; b=lzdsoS8BraBRs1GYGB86OVK9hPfhH0R19IgYqb5u47VToYKuNg+sw/X+AFM7wcTurt IAzeK7gurf3A/tpho8YCKI6vf4KEBUxPjkT6KrLWM7pp6A9yD/D6mRMdjLDAvJJYWsHE STV0sgqMn0mHhrICory9IasnlODzCnE3iKtRMgESSZ+KwG6mxv4Q/85LgdmmHDxeUqO1 LD2lU1lwN5vzsms5t8Qv7O66RciwQx7qxGrfOiyvcWlXHUjwaaZDihBOKBdfyDBvJub0 I0e3nJFeFs0AIzYNz025WKVU8Rdds1dECPmVh6alZaeCgQ/xBTbBc5JJ69W0DePCi+V/ ukOA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k28-v6si13216205pgl.221.2018.10.18.13.11.42; Thu, 18 Oct 2018 13:11:57 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727435AbeJSELr convert rfc822-to-8bit (ORCPT + 99 others); Fri, 19 Oct 2018 00:11:47 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39284 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725139AbeJSELr (ORCPT ); Fri, 19 Oct 2018 00:11:47 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 326C6309EAB7; Thu, 18 Oct 2018 20:09:10 +0000 (UTC) Received: from warthog.procyon.org.uk (ovpn-120-250.rdu2.redhat.com [10.10.120.250]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1C7FB60160; Thu, 18 Oct 2018 20:09:07 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <862e36a2-2a6f-4e26-3228-8cab4b4cf230@gmail.com> References: <862e36a2-2a6f-4e26-3228-8cab4b4cf230@gmail.com> <153754740781.17872.7869536526927736855.stgit@warthog.procyon.org.uk> <153754743491.17872.12115848333103740766.stgit@warthog.procyon.org.uk> To: Alan Jenkins Cc: dhowells@redhat.com, viro@zeniv.linux.org.uk, torvalds@linux-foundation.org, ebiederm@xmission.com, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, mszeredi@redhat.com Subject: Re: [PATCH 03/34] teach move_mount(2) to work with OPEN_TREE_CLONE [ver #12] MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Date: Thu, 18 Oct 2018 21:09:07 +0100 Message-ID: <7833.1539893347@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.49]); Thu, 18 Oct 2018 20:09:10 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Alan Jenkins wrote: > If I instead do the mount+unmount first, and close the FD as a second step, I > think there's a lockup in the close().  The lockup happens in the same place > as the unmount lockup from before. (Except there's a line "Code: Bad RIP > value", I don't know why that happens). Sorry, which FD are we talking about? I presume you're talking about a command sequence like this: # unshare --mount # test-fsmount # mount --move . /mnt # mount --move /mnt /mnt # cd # umount /mnt # exit but this fails on your modified test-fsmount with: shell-init: error retrieving current directory: getcwd: cannot access parent directories: No such file or directory David