Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
To:     Alan Tull <atull@kernel.org>,
        Michael Turquette <mturquette@baylibre.com>
From:   Stephen Boyd <sboyd@kernel.org>
In-Reply-To: <20181018195411.3449-1-atull@kernel.org>
Cc:     Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>,
        Alan Tull <atull@kernel.org>, linux-clk@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20181018195411.3449-1-atull@kernel.org>
Message-ID: <153989416422.53599.5865157270835783532@swboyd.mtv.corp.google.com>
User-Agent: alot/0.7
Subject: Re: [PATCH] clk: fixed-rate: fix of_node_get-put imbalance
Date:   Thu, 18 Oct 2018 13:22:44 -0700
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Quoting Alan Tull (2018-10-18 12:54:11)
> When the fixed rate clock is created by devicetree,
> of_clk_add_provider is called.  Add a call to
> of_clk_del_provider in the remove function to balance
> it out.
> =

> Signed-off-by: Alan Tull <atull@kernel.org>
> ---

Fixes tag? I'll tack one on.

>  drivers/clk/clk-fixed-rate.c | 1 +
>  1 file changed, 1 insertion(+)
> =

> diff --git a/drivers/clk/clk-fixed-rate.c b/drivers/clk/clk-fixed-rate.c
> index b5c46b3f8764..6d6475c32ee5 100644
> --- a/drivers/clk/clk-fixed-rate.c
> +++ b/drivers/clk/clk-fixed-rate.c
> @@ -200,6 +200,7 @@ static int of_fixed_clk_remove(struct platform_device=
 *pdev)
>  {
>         struct clk *clk =3D platform_get_drvdata(pdev);
>  =

> +       of_clk_del_provider(pdev->dev.of_node);
>         clk_unregister_fixed_rate(clk);
>  =

>         return 0;