Received: by 2002:ac0:a582:0:0:0:0:0 with SMTP id m2-v6csp2443975imm; Thu, 18 Oct 2018 14:56:36 -0700 (PDT) X-Google-Smtp-Source: ACcGV61YchJeSTOfXD/cblwp17FOSQNir89trUcnSI5sRnI8Mqy8bFyd/LnlIcFgc61RecItnBRU X-Received: by 2002:a62:ff09:: with SMTP id b9-v6mr31906543pfn.46.1539899796159; Thu, 18 Oct 2018 14:56:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1539899796; cv=none; d=google.com; s=arc-20160816; b=YPm3mVARS95+V3ku6dJ15yWZViN8fq9iJ40g1ofFBgl1C5WQeSS0lAP45OmwstsE18 qPRRFKWrZVHXQ7E3uqQsOxShNl6C6CckVzJOMiaqJqq02eSc8FLLnKmxv1zfSTsQQw1O nO9j1JijVf4GtqsqkqNZScTSIKDOYDA0esgK6KRI6GkY4T5cZ9A4yEgSsYS2X7buOd+X kuVNXavt9r9wACvugtA8DcehIrLY850+UaAD/fVugp4v8NLYGtckxJsdrP36DTRc7BuV 0sHtp9tSRoJ1maZSqsATdhm6eXqVm08zveq2iyLmo+DGLWdr8Zse2AbeErp/FU2aSGDY LRrw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=cedI6L2HxLnFCqRXETI1zk9gDFuUv7bXrQNvp4RiQ2k=; b=qqOreqEUahPxvzVwnVpf1iUEDim1cfRZf+DwJV5Y6IluumMKIjDCerfFBjhy8b/0+v u+7OGmYl5YyyiycNDVDKhQPGDaL9djZ2HLZQ+q8wTx2kpK1j85kUurKo6IGRRFBu4jCo TMbf11WT2d2WQHsAZrf5OQp9rFfo7g9L0OP7tmQZLvv6rxhypChTnjSxoxMF7SCT8zdx B28MML+FZVVt4kE9G199PGfdtdRBkrNddAs9OqbLjr/R1GaOGAaTk3S6pppm3Mcf5gQ2 rLBd3tUJ12qth3C3HW/5aL7ThDFxamB1r5WN6dNbtUcMLvUy+DXP0GhLzLKP0X4156tW wjTg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=iIhdb1wb; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b1-v6si22566300pgb.553.2018.10.18.14.56.19; Thu, 18 Oct 2018 14:56:36 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=iIhdb1wb; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726902AbeJSF64 (ORCPT + 99 others); Fri, 19 Oct 2018 01:58:56 -0400 Received: from mail-wr1-f66.google.com ([209.85.221.66]:34822 "EHLO mail-wr1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725751AbeJSF64 (ORCPT ); Fri, 19 Oct 2018 01:58:56 -0400 Received: by mail-wr1-f66.google.com with SMTP id w5-v6so35285705wrt.2; Thu, 18 Oct 2018 14:55:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=cedI6L2HxLnFCqRXETI1zk9gDFuUv7bXrQNvp4RiQ2k=; b=iIhdb1wbNUESeJRJ5i9wPxodlXitd8E0C6XCpRxA0qJsipyNbtIX5ajGZAQr/xjZbm RvaUxXNgj/WWIG2zkKsGHPuJ7J+uEDONEj/pHAQVGrjuMjsgG3enVJ056rhZD9XDYL7s ewDjKuL9TUpWrah5ajjTUqW0ZE0xp5nFDHDcC/g7IveRR7XCfDmPWJDijQKEmQ/LZC5b O4wzdOa6useRagCHMZXUB8vj8b6svtJUAjBzckDC06tyMGPHTs/PST7LOuGhOT9Yssl2 c8/Wf/X839pWXbppm0XvF66f3Kn6DHb98y1jvGSzCdnqkcFJ/QrU2+gjUiapDwbZRPZD ugBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=cedI6L2HxLnFCqRXETI1zk9gDFuUv7bXrQNvp4RiQ2k=; b=CqExqeLTiGVlctNvvq2ga63QVG/iRfna9fjPMfkrBfAYSy83xRd1mTXNb0Uv/CwCA2 CywBF+OnyDYF2onSen2pjLTIBCbjUCAXe5guxSSuyyzjxYfRlOyrMciSXKTHNJpZzKQ6 0Qjy3Wv8NvaO1t6jl9ez3+rDfaYKxO28xCc8TKj8aOI0zoOMbNC5hUABWvWExeSlKh0K 2tr518MTAE95L3pMLR5m3pqRwo+10c45XHWdTE31e6P8ukFesJrtjzufVInIvolkOAwK NPE5jcmg1eUrK7eD7hhGtcz6LxmncQR8arxikgaQ2Mg+rF1Cs88G8Un6WJg2m79PMuq3 P6Qg== X-Gm-Message-State: ABuFfoiWLmkkQT9JkVd6USzYpd+hY9ZOSqHDIXFluoX3PbxavgarAOcf jIQkQgKaEkUmYioYGXKphkQCEXw9J8suPg== X-Received: by 2002:adf:eb03:: with SMTP id s3-v6mr31954811wrn.281.1539899753948; Thu, 18 Oct 2018 14:55:53 -0700 (PDT) Received: from localhost.localdomain ([2a01:4f8:10b:24a5::2]) by smtp.gmail.com with ESMTPSA id c24-v6sm34468140wre.44.2018.10.18.14.55.53 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 18 Oct 2018 14:55:53 -0700 (PDT) From: Nathan Chancellor To: Adam Radford , "James E.J. Bottomley" , "Martin K. Petersen" Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, Nathan Chancellor Subject: [PATCH] scsi: 3w-{sas,9xxx}: Use unsigned char for cdb Date: Thu, 18 Oct 2018 14:55:41 -0700 Message-Id: <20181018215541.4768-1-natechancellor@gmail.com> X-Mailer: git-send-email 2.19.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Clang warns a few times: drivers/scsi/3w-sas.c:386:11: warning: implicit conversion from 'int' to 'char' changes value from 128 to -128 [-Wconstant-conversion] cdb[4] = TW_ALLOCATION_LENGTH; /* allocation length */ ~ ^~~~~~~~~~~~~~~~~~~~ Update cdb's type to unsigned char, which matches the type of the cdb member in struct TW_Command_Apache. Link: https://github.com/ClangBuiltLinux/linux/issues/158 Signed-off-by: Nathan Chancellor --- drivers/scsi/3w-9xxx.c | 12 ++++++++---- drivers/scsi/3w-sas.c | 8 +++++--- 2 files changed, 13 insertions(+), 7 deletions(-) diff --git a/drivers/scsi/3w-9xxx.c b/drivers/scsi/3w-9xxx.c index 05293babb031..2d655a97b959 100644 --- a/drivers/scsi/3w-9xxx.c +++ b/drivers/scsi/3w-9xxx.c @@ -143,7 +143,9 @@ static int twa_poll_status_gone(TW_Device_Extension *tw_dev, u32 flag, int secon static int twa_post_command_packet(TW_Device_Extension *tw_dev, int request_id, char internal); static int twa_reset_device_extension(TW_Device_Extension *tw_dev); static int twa_reset_sequence(TW_Device_Extension *tw_dev, int soft_reset); -static int twa_scsiop_execute_scsi(TW_Device_Extension *tw_dev, int request_id, char *cdb, int use_sg, TW_SG_Entry *sglistarg); +static int twa_scsiop_execute_scsi(TW_Device_Extension *tw_dev, int request_id, + unsigned char *cdb, int use_sg, + TW_SG_Entry *sglistarg); static void twa_scsiop_execute_scsi_complete(TW_Device_Extension *tw_dev, int request_id); static char *twa_string_lookup(twa_message_type *table, unsigned int aen_code); @@ -278,7 +280,7 @@ static int twa_aen_complete(TW_Device_Extension *tw_dev, int request_id) static int twa_aen_drain_queue(TW_Device_Extension *tw_dev, int no_check_reset) { int request_id = 0; - char cdb[TW_MAX_CDB_LEN]; + unsigned char cdb[TW_MAX_CDB_LEN]; TW_SG_Entry sglist[1]; int finished = 0, count = 0; TW_Command_Full *full_command_packet; @@ -423,7 +425,7 @@ static void twa_aen_queue_event(TW_Device_Extension *tw_dev, TW_Command_Apache_H /* This function will read the aen queue from the isr */ static int twa_aen_read_queue(TW_Device_Extension *tw_dev, int request_id) { - char cdb[TW_MAX_CDB_LEN]; + unsigned char cdb[TW_MAX_CDB_LEN]; TW_SG_Entry sglist[1]; TW_Command_Full *full_command_packet; int retval = 1; @@ -1798,7 +1800,9 @@ static int twa_scsi_queue_lck(struct scsi_cmnd *SCpnt, void (*done)(struct scsi_ static DEF_SCSI_QCMD(twa_scsi_queue) /* This function hands scsi cdb's to the firmware */ -static int twa_scsiop_execute_scsi(TW_Device_Extension *tw_dev, int request_id, char *cdb, int use_sg, TW_SG_Entry *sglistarg) +static int twa_scsiop_execute_scsi(TW_Device_Extension *tw_dev, int request_id, + unsigned char *cdb, int use_sg, + TW_SG_Entry *sglistarg) { TW_Command_Full *full_command_packet; TW_Command_Apache *command_packet; diff --git a/drivers/scsi/3w-sas.c b/drivers/scsi/3w-sas.c index 266bdac75304..480cf82700e9 100644 --- a/drivers/scsi/3w-sas.c +++ b/drivers/scsi/3w-sas.c @@ -287,7 +287,9 @@ static int twl_post_command_packet(TW_Device_Extension *tw_dev, int request_id) } /* End twl_post_command_packet() */ /* This function hands scsi cdb's to the firmware */ -static int twl_scsiop_execute_scsi(TW_Device_Extension *tw_dev, int request_id, char *cdb, int use_sg, TW_SG_Entry_ISO *sglistarg) +static int twl_scsiop_execute_scsi(TW_Device_Extension *tw_dev, int request_id, + unsigned char *cdb, int use_sg, + TW_SG_Entry_ISO *sglistarg) { TW_Command_Full *full_command_packet; TW_Command_Apache *command_packet; @@ -372,7 +374,7 @@ static int twl_scsiop_execute_scsi(TW_Device_Extension *tw_dev, int request_id, /* This function will read the aen queue from the isr */ static int twl_aen_read_queue(TW_Device_Extension *tw_dev, int request_id) { - char cdb[TW_MAX_CDB_LEN]; + unsigned char cdb[TW_MAX_CDB_LEN]; TW_SG_Entry_ISO sglist[1]; TW_Command_Full *full_command_packet; int retval = 1; @@ -554,7 +556,7 @@ static int twl_poll_response(TW_Device_Extension *tw_dev, int request_id, int se static int twl_aen_drain_queue(TW_Device_Extension *tw_dev, int no_check_reset) { int request_id = 0; - char cdb[TW_MAX_CDB_LEN]; + unsigned char cdb[TW_MAX_CDB_LEN]; TW_SG_Entry_ISO sglist[1]; int finished = 0, count = 0; TW_Command_Full *full_command_packet; -- 2.19.1