Received: by 2002:ac0:a582:0:0:0:0:0 with SMTP id m2-v6csp2749715imm; Thu, 18 Oct 2018 22:02:36 -0700 (PDT) X-Google-Smtp-Source: ACcGV60QyqXYZy5elG8XJGtFd+0jCp7qCPTAHzWw2jnkww0aHFa217BvZqGuep4etEKgrVhTxwgk X-Received: by 2002:a17:902:286b:: with SMTP id e98-v6mr32458668plb.110.1539925356416; Thu, 18 Oct 2018 22:02:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1539925356; cv=none; d=google.com; s=arc-20160816; b=BA/s7RjMSIlYUmKvFrr9hZI8UbP3aCROK6ud+e99RjkI6HrtSG+dAOu2e8din24vA5 4bqT9yDNt8SEqoxq4P3EUNQIfxgX6+qe5t+Yue3QfejgYgqZRaRJgEeMOuGUA04Hzvzl b8/Msb5egy2UquE4EytnT1dqnlmp9NloaBuZSZRTmyXOkjKVuKijZZatuGWU3gUNvRvX hMZKi4yN9PavN6o1kUXCXeLD1VvCHm0nDsgQ8xtpoWD0YQG5M1SUTw8P8KO1XbvQPUeb UYUJZkobxpYJube6rQs4Z+UdJ0viJgmB0un5kP406WA3qEiPStlOh/RhgQDfoKjJ0HmP 6S8Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:references:cc:to:from:subject:dkim-signature; bh=sLS02Ys+OMIWhw+yNf5/06qzYeiO5cQY5DdT8X34mjU=; b=pk4+iKZXJA5C+EgeZoaqAn+/Q3FHdj/a4soVOpmGKmNr7C/S9vpw0yKiI3s6VSUxfS U1iLZrf5npfE0zS9JKOxKcuAwV2HGgI2fZDNdwZaXJUoxtvZoyVD/w9CYWvg/VAhF9jH tNNH4IONDdEerUtxHx6BN/z7oTOPev29wPy4RAGrHUVzF43rDGEIL+9UAKBgPUEkPLQn jpMhm4p4DgzfpeQ+ynQDNeJUR2M0iwTWMwg005D8M4RDGVUMXEA8WK0jmrXtDj585Poa oc1/B6/Yjw8FbE9iXDSZGrb/3L8DVTqDf5mgXmfsMWC3D+++pZy5QSmwpM8Rm/gTmni8 MzGg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=s45Wc0k0; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a23-v6si23249492pgg.372.2018.10.18.22.02.21; Thu, 18 Oct 2018 22:02:36 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=s45Wc0k0; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727220AbeJSNEd (ORCPT + 99 others); Fri, 19 Oct 2018 09:04:33 -0400 Received: from mail-pg1-f195.google.com ([209.85.215.195]:33903 "EHLO mail-pg1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726478AbeJSNEd (ORCPT ); Fri, 19 Oct 2018 09:04:33 -0400 Received: by mail-pg1-f195.google.com with SMTP id g12-v6so15242798pgs.1; Thu, 18 Oct 2018 22:00:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:from:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=sLS02Ys+OMIWhw+yNf5/06qzYeiO5cQY5DdT8X34mjU=; b=s45Wc0k0Byoj2VVd+itXhQaAdS3xZwW8qY/k1ZDe6vyOX/GVyITR+P/1um4jMHzIx7 ZD7XgV4FBRkcelP4ABKxfzU3JsbZQ/kZuFOYW8hwmPrryZ/GiO1HkTG6F2xQCO9ACe89 r/xXsuY6BdeHqvfOhqjulMhvQRiib88P2vyT1iL2Krbd9e9Tv85z/ATHjHiutA4gbx3X zgS0eeLBpbQl3eoZSui0nUSvE1o1cfyAz8kMV+x1RzM9/mQUc6HLBd0XSJuskw7AwJlE nAjmIwUrJlpSV4d+tQj6X07fR/MohCPAHp2d4qcj+ggiCFZwJVLol4KSEN9c+o1yrayH Ot4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=sLS02Ys+OMIWhw+yNf5/06qzYeiO5cQY5DdT8X34mjU=; b=bS5PXt3gUzbQhKTu8Xwe4KGlKUCCEnsQiKhncTfB6PqJj5m6gHZgVF4eXsK2tnavj2 ZuKXRBipcPn8YF7jx3YfUjnkoZsF0JZ33a3BfN2TBqs0s78zDhg3Tc4FeIrJ6FIZYOKz FRjtMegSm0zangG654L6d+FCccV3fwo/ju3NT7sbiFLfaqadlrJR0k4K79e+dhONiPZK 6Lnxvg8eMV0gbTZXzmQ6EU7mGkndQaRSxpiU0+v8n1x7FXP8cAVgHFBQ+kIZaLh4zldV mUBIOVs5v4rmqIjGlaWM0Oi7BT45LqiE/RsN+4X3/G/eHHJ806fpLVpgBcKC8ogidYMe nG/A== X-Gm-Message-State: ABuFfoj8sAXjegRqCec8leQfz29yvYNcADX6KMSlZ9CCb4/neTovTZSx DC3+LBs4vzenuo0qUSh+EWl1Iv6w X-Received: by 2002:a65:4882:: with SMTP id n2-v6mr29726099pgs.225.1539925209479; Thu, 18 Oct 2018 22:00:09 -0700 (PDT) Received: from [192.168.1.70] (c-24-6-192-50.hsd1.ca.comcast.net. [24.6.192.50]) by smtp.gmail.com with ESMTPSA id b81-v6sm40921622pfm.96.2018.10.18.22.00.07 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 18 Oct 2018 22:00:08 -0700 (PDT) Subject: Re: [PATCH v5 00/18] of: overlay: validation checks, subsequent fixes From: Frank Rowand To: Rob Herring , Pantelis Antoniou , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Alan Tull , Moritz Fischer Cc: linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, devicetree@vger.kernel.org, linux-fpga@vger.kernel.org References: <1539902796-8382-1-git-send-email-frowand.list@gmail.com> Message-ID: <5d8a5e46-b186-9c15-890a-ae6481652eaa@gmail.com> Date: Thu, 18 Oct 2018 22:00:07 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <1539902796-8382-1-git-send-email-frowand.list@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/18/18 15:46, frowand.list@gmail.com wrote: > From: Frank Rowand > > Add checks to (1) overlay apply process and (2) memory freeing > triggered by overlay release. The checks are intended to detect > possible memory leaks and invalid overlays. > > The checks revealed bugs in existing code. Fixed the bugs. > > While fixing bugs, noted other issues, which are fixed in > separate patches. git version of the series: git://git.kernel.org/pub/scm/linux/kernel/git/frowand/linux.git $ git checkout v4.19-rc1--kfree_validate--v5 $ git log --oneline v4.19-rc1.. 62e8f28bb14b of: unittest: initialize args before calling of_*parse_*() cc8b630f0c7f of: unittest: find overlays[] entry by name instead of index b80a8e974e0f of: unittest: allow base devicetree to have symbol metadata bbcd6ead8e36 of: overlay: set node fields from properties when add new overlay node e02d06f99646 of: unittest: remove unused of_unittest_apply_overlay() argument 484ba7f7eb4a of: overlay: check prevents multiple fragments touching same property 4640b81a605b of: overlay: check prevents multiple fragments add or delete same node 698f942ee230 of: overlay: test case of two fragments adding same node 5fe758e00f1f of: overlay: make all pr_debug() and pr_err() messages unique 868c6f70eed5 of: overlay: validate overlay properties #address-cells and #size-cells 06bc44ce477f of: overlay: reorder fields in struct fragment 584f4537377c of: dynamic: change type of of_{at,de}tach_node() to void 54f30ea3bf65 of: overlay: do not duplicate properties from overlay for new nodes ad4180c300fc of: overlay: use prop add changeset entry for property in new nodes b1bdca739700 powerpc/pseries: add of_node_put() in dlpar_detach_node() 8e0290d5cb62 of: overlay: add missing of_node_get() in __of_attach_node_sysfs 93e221495a9f of: overlay: add missing of_node_put() after add new node to changeset 86043f08e539 of: overlay: add tests to validate kfrees from overlay removal