Received: by 2002:ac0:a582:0:0:0:0:0 with SMTP id m2-v6csp2902924imm; Fri, 19 Oct 2018 01:29:14 -0700 (PDT) X-Google-Smtp-Source: ACcGV62XQ3uob/n2uPJlEV2/pVgMEW0RWD2u59cvCGnGpXfjj+jIq/ruYPqVjscZbpzGNgiKdkE9 X-Received: by 2002:a17:902:bcc3:: with SMTP id o3-v6mr33401732pls.66.1539937754804; Fri, 19 Oct 2018 01:29:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1539937754; cv=none; d=google.com; s=arc-20160816; b=ZEXsiazJ3mTsaqO6r1Dw89lBR6w3DVx+DaOyXbhcdbatqgTcdB4k29ef0I1SDp9kCu H6xaqeMWIIaLTrN+ej3xa7EF7CMDZhiLyyGxCisdCi3OAHvLQuCAzSDsf20vrPU6tc0N tWKXL9D0FLns1QwxSorsukb1EFEAnRPgs23DKrK3XPO7/g5uPbg1NyDdos+153gdjHfB UFmUiwvT0q7weh3AzNk4OZBr7DGjCIBQMcQGAdfdoBx5EsnzTHtNaIWu3OxUMYkKO6bU o5+xKwek9+ExLcrv3T9ECZ1LRqjwwsxQ+nxkZ1ql1d+yAue9ghgpqT2mWLa0PN+jkHfI fIpA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:reply-to:message-id :subject:cc:to:from:date:dkim-signature; bh=pxm8OxNPhDlCMIXjR236o8IyUth6vkB7eMrUlqg5uso=; b=fdYAh2+dS9lIMsToTpPt7CH4NamdFDUQFBs39mw1az9KHFtG6Ct3u239AlIMcF7iwi dFEoFSWdWzKEd2MqFx6U6/UbAcW4gdvNQYhmBgCWN8wZc0kwFObjQAa5LaUmvTIyZXF0 a1HnfmPHDyunXnKG0kFqxH3R+B+030Ecwcjh+ysFJazsKMJFcfUflBCBuqToNY173NUV H3BhP1761zKtk3yO58CeVzJEAnuvSb1s8piBgExqP4BEAlD/i7K7moM3834Hi8VQGv5w PNifyFiX1sQatT3iim+5zh2432hhTwIzot0c7yLXHkwBRvDHJgPuc+Z1cBOoZeFn69A7 TQWw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=gv1hr69M; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y9-v6si23471950plk.407.2018.10.19.01.28.59; Fri, 19 Oct 2018 01:29:14 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=gv1hr69M; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726964AbeJSQdH (ORCPT + 99 others); Fri, 19 Oct 2018 12:33:07 -0400 Received: from mail-ed1-f68.google.com ([209.85.208.68]:36749 "EHLO mail-ed1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726609AbeJSQdH (ORCPT ); Fri, 19 Oct 2018 12:33:07 -0400 Received: by mail-ed1-f68.google.com with SMTP id c26-v6so30669959edt.3 for ; Fri, 19 Oct 2018 01:28:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:reply-to:references:mime-version :content-disposition:in-reply-to:user-agent; bh=pxm8OxNPhDlCMIXjR236o8IyUth6vkB7eMrUlqg5uso=; b=gv1hr69MFKcSm74CqGvswaxTLKy88OJdvvVtYUML/T9kffLmcTwN2EJunEzYjFHQS/ jKNXSd/Zx9qry5WusBXpKNiWnycUwwT1sRk0Xno4ec5I6Mv093GcGi1Hlh3bxzEj7tAt ruDxzdbGg3WvMgTk3Ms0c8JUgU2c6mau8yeAR2GhuvAogAU75qhsCHrL70r4e0T9nlcO X267SJ8I7cGVkL+vbguaSjIIfDlobJWzgiu093xgeQl/Lo6rwYvVnyl0cnQgg51++L1w mH36z5MvRWK92Se9d9rVSKllWaLQllLN7IUawBY8jkAsA8xFmTdI0cv9hSYVEUP7Wnaf Iu3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:reply-to :references:mime-version:content-disposition:in-reply-to:user-agent; bh=pxm8OxNPhDlCMIXjR236o8IyUth6vkB7eMrUlqg5uso=; b=ueO+DfOQ+ABvmTEtpW1ryJjLNcM1t01Ck/1YrDt/GW649PxFrUfAq1LITwno854tTm O+7iLShKc/wJvso+p102X4nAOCAPvFSok/TVxxrpCI7ZP7IXgb9J2K5q4Plr0wjD16t+ HrcmFC2taw8GLniN+770aOidxh9aboX5bqXM1EZQhc4KMxsAERSEpLaIIcamtQ3tgMTP LDWnh/y/82H2FoWLZVwj/I7eUhSBSbSvynQXVs47vUMCWyDpiAzsu62cqSuvKOlVirwI SHGvCN0i+R7jsOl9VPphm1K6NEsxbWbYhfEaAuRFyipZSfVn+GwWGr8KeV9sjs9oxv2k lhJA== X-Gm-Message-State: ABuFfojql46I++nUIWGkDOQ8RkTT3VzGcEs8BWw8kkNCOhsuBOUvf+jZ yiPLK0S5mjywON1P3KrHKiA= X-Received: by 2002:a50:8465:: with SMTP id 92-v6mr5410298edp.97.1539937682760; Fri, 19 Oct 2018 01:28:02 -0700 (PDT) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id z7-v6sm8135011edd.71.2018.10.19.01.28.01 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 19 Oct 2018 01:28:02 -0700 (PDT) Date: Fri, 19 Oct 2018 08:28:01 +0000 From: Wei Yang To: Pavel Tatashin Cc: penghao122@sina.com.cn, Linux Memory Management List , Andrew Morton , pasha.tatashin@oracle.com, osalvador@suse.de, LKML , peng.hao2@zte.com.cn Subject: Re: [PATCH] mm/sparse: remove a check that compare if unsigned variable is negative Message-ID: <20181019082801.kbnqxx5ozghy3p3b@master> Reply-To: Wei Yang References: <1539447319-5383-1-git-send-email-penghao122@sina.com.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Oct 13, 2018 at 01:04:45PM -0400, Pavel Tatashin wrote: >This is incorrect: next_present_section_nr() returns "int" and -1 no >next section, this change would lead to infinite loop. Yes, the -1 is a very special value. -- Wei Yang Help you, Help me