Received: by 2002:ac0:a582:0:0:0:0:0 with SMTP id m2-v6csp2943769imm; Fri, 19 Oct 2018 02:20:00 -0700 (PDT) X-Google-Smtp-Source: ACcGV617dQk1wU7d33OSlBi4BUBZxh/24jnwnikuL4JkmZ9RoLgwv4njznN3vwUYv5NdC9+F0N30 X-Received: by 2002:a17:902:15a8:: with SMTP id m37-v6mr4393921pla.256.1539940800187; Fri, 19 Oct 2018 02:20:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1539940800; cv=none; d=google.com; s=arc-20160816; b=iDIAbhMimhZ0GHS5d9vx3OoeeVDx+3MCN/BeXX2LZ7MgsYCdMvtdBcDdXAphKSXbn+ f5OrxsFijKkA+3DEmZNYLfIXCtYeeClZhBqPN4nXVFh47Alyzx/R46FKlEv9sfDYusAZ eY8x66QK/jQOk3hQfa6Ln+zWyAk/doQQfHhT5nRt8UJSMOwKuJgP9w77dh4ZIJw8G4E2 vxVOqvGjvRAdEjagEjHoOZBv+DUpoQ9C4P8BdhnA++3bDBsfaAjABoXpptkiHIoYJ6QQ qTBi4oume0i6PXC5st9kB+xyipNO9ahxX6dUdZfvh6uNJQ4LLwzGciucc6Fc73l2lgzs VPOg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=dVXfNgr2LpyQAhg+AvQqhNOBiz6vDL3KiCmz1dpCSmQ=; b=UBeIjFzW2cJXRO9WYCNwP70MJV0ppVVHZL1Z976iHICzrGb2o4uiSHvFBjb7PYYMjW WRQ4IHiDpZjL5c4lIEKWvDP1dL/4Ph5WINIXxY1Blv15mZMoJKg8pQa5k/MNksCJWtCL iWLh69V7bnkUaSfUK6pGSvah3aZ9PPWvyEsSVbfY1dBwwrn4VIJ0QZLTk2m7gg4yqnE+ 0P3Now20occ9o0ljhBXzOTwnRFDorKltyMgwCQlfof7lArUdaxQH3TnCBNN/dqdS0rVO 7oOeXJ/Kw6USQ2O81MBF/daPw5dAgQMXnayDrNz/4RiRQJ6Tsc41ZhGpr3R+65JxTNV+ Dyrg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 8-v6si23379388pgv.137.2018.10.19.02.19.44; Fri, 19 Oct 2018 02:20:00 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727297AbeJSRYW (ORCPT + 99 others); Fri, 19 Oct 2018 13:24:22 -0400 Received: from foss.arm.com ([217.140.101.70]:49384 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726970AbeJSRYW (ORCPT ); Fri, 19 Oct 2018 13:24:22 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 3FFA480D; Fri, 19 Oct 2018 02:19:08 -0700 (PDT) Received: from e107155-lin (e107155-lin.cambridge.arm.com [10.1.196.42]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id DF85E3F5D3; Fri, 19 Oct 2018 02:19:06 -0700 (PDT) Date: Fri, 19 Oct 2018 10:18:59 +0100 From: Sudeep Holla To: =?utf-8?B?6ZmI5Y2O5omN?= Cc: Greg Kroah-Hartman , "Rafael J . Wysocki" , LKML , zhangfx , wuzhangjin , Sudeep Holla Subject: Re: [PATCH] cacheinfo: Keep the old value if of_property_read_u32fails Message-ID: <20181019091859.GA17312@e107155-lin> References: <1539739563-1886-1-git-send-email-chenhc@lemote.com> <20181017093540.GB16320@e107155-lin> <20181018091146.GA22021@e107155-lin> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Fri, Oct 19, 2018 at 02:23:27PM +0800, 陈华才 wrote: > Hi, Sudeep, > > I use MIPS, and there is no "size" in > /sys/devices/system/cpu/cpuX/cache/indexX/ file after your patch. Because > the DT node only has "next-level-cache = <&L2>;" but has no "size" > information. > Thanks for the confirmation and your time. I was worried if this was ARM64 with local patches. You can add: Reviewed-by: Sudeep Holla Also please add: Fixes: 448a5a552f33 ("drivers: base: cacheinfo: use OF property_read_u32 instead of get_property,read_number") -- Regards, Sudeep