Received: by 2002:ac0:a582:0:0:0:0:0 with SMTP id m2-v6csp2992363imm; Fri, 19 Oct 2018 03:19:23 -0700 (PDT) X-Google-Smtp-Source: ACcGV627lTPNorIiChzjI4ot/lgeKEZqEcyWOJxv06G6RppHBAqNkVq1zG1VVNUADswZZB5JMBty X-Received: by 2002:a17:902:a50e:: with SMTP id s14-v6mr33495840plq.78.1539944363157; Fri, 19 Oct 2018 03:19:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1539944363; cv=none; d=google.com; s=arc-20160816; b=Riw34rinzXDHvoU+HGjd5O2yRj3Q0E3Y8Pe/YIRVtDJPITT2dH4h7Ub9I1HyeMtkbU KE32YCxjodpvmlMMLSZ9iT6DYO8Nl7EwRvxMjL/bd6fJoFMTaIoce5FOBXaAVIjWfZW5 tmlGgl2w8qB6f6YN4AUaqA/vP3e2AEmReOgX2KaM6ZbcsyTdMW0T0zkBE1o8FSW7nG6N aSI3feRJEg1HPUIbwsog6vBK/5R5A6GSasNK6NEExlER9yN/TuuNseg80yO78mJkxBGn 2PXrSHTQPzseEEolG1L4R557cCKCWY7gQpxgojaKF1Op0cdpbbXUy/BLys7cE2RqlgqM IEsQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=DZ9voYAqqlPJ+5AKIO7SwdWd0HYM3ZsiHlHRiZAgycM=; b=xzWXxot2/pFUeRWcRUThomrM4mMdgq/Mdg+6dWIjXHCx79ng3mwnTzGNeo+AKH6HqP DLwTej74bIsml4Gda4evhSgIqLGgRbnZtTzLLjJXrrC6/M9OucuTa+WAYgkDRzH6z478 tzwusaEZ2BfWSlFZV7EIVvTaN/8WstLlEPhwoBOCFQGa2Lpg7tWcQPBfJ7yquqqExy0K Oh6D1nuGHpZSmu0h/n0/IyIl9YXCMtg2tuQSVtFRglCP2+v0+MbfAh27W9VIzofgqA/X 662FnYHUc2BVOKsK9bLk8I+fjNmIhIGYYXUp4gB4mUCEFtfIRUqBd+GEHHQAYHb7/tq4 h9/A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i5-v6si23908016pgg.559.2018.10.19.03.19.07; Fri, 19 Oct 2018 03:19:23 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727289AbeJSSYE convert rfc822-to-8bit (ORCPT + 99 others); Fri, 19 Oct 2018 14:24:04 -0400 Received: from mail.bootlin.com ([62.4.15.54]:59213 "EHLO mail.bootlin.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726690AbeJSSYD (ORCPT ); Fri, 19 Oct 2018 14:24:03 -0400 Received: by mail.bootlin.com (Postfix, from userid 110) id BB44720DFF; Fri, 19 Oct 2018 12:18:35 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mail.bootlin.com X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT, URIBL_BLOCKED shortcircuit=ham autolearn=disabled version=3.4.0 Received: from localhost (aaubervilliers-681-1-25-52.w90-88.abo.wanadoo.fr [90.88.145.52]) by mail.bootlin.com (Postfix) with ESMTPSA id 8C6C0209DA; Fri, 19 Oct 2018 12:18:25 +0200 (CEST) Date: Thu, 18 Oct 2018 18:58:08 +0200 From: Maxime Ripard To: Icenowy Zheng Cc: Chen-Yu Tsai , linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com Subject: Re: [PATCH v2] clk: sunxi-ng: enable so-said LDOs for A64 SoC's pll-mipi clock Message-ID: <20181018165808.f23gfkwlgskzdbfy@flea> References: <20181018070729.52943-1-icenowy@aosc.io> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: 8BIT In-Reply-To: <20181018070729.52943-1-icenowy@aosc.io> User-Agent: NeoMutt/20180716 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 18, 2018 at 03:07:29PM +0800, Icenowy Zheng wrote: > In the user manual of A64 SoC, the bit 22 and 23 of pll-mipi control > register is called "LDO{1,2}_EN", and according to the BSP source code > from Allwinner , the LDOs are enabled during the clock's enabling > process. > > The clock failed to generate output if the two LDOs are not enabled. > > Add the two bits to the clock's gate bits, so that the LDOs are enabled > when the PLL is enabled. > > Fixes: c6a0637460c2 ("clk: sunxi-ng: Add A64 clocks") > Signed-off-by: Icenowy Zheng Queued for 4.21, thanks! Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com