Received: by 2002:ac0:a582:0:0:0:0:0 with SMTP id m2-v6csp3051259imm; Fri, 19 Oct 2018 04:23:24 -0700 (PDT) X-Google-Smtp-Source: ACcGV60Ye3fFHfmSAZNnzLldBEqCyzbwXLE0Q7JPEa3dbzxBwauei17PQscQ+9ZnQEywnUetMF3v X-Received: by 2002:a63:5747:: with SMTP id h7-v6mr32313488pgm.423.1539948203942; Fri, 19 Oct 2018 04:23:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1539948203; cv=none; d=google.com; s=arc-20160816; b=mk3QnFS+h2cEDwG9di7cH1gDTHbMTi0I5RbkzQap2BnefwsUAkAryQors9rkz8gVxC JH9paf6wlHINitDvuAeZGCvVbAkx70L0RXIzMLCcRUEuAHYCgcUpbJ2i0faHccwU+XTe 0mygN9nBbu5NnAXv/UrVDZpFaYhppnC4F7vEzGo9Bv77Gjk28jqWaq4YVYmbaoQ4JNoF 8EtkH6Nudj2fin7V9JdoExVpOTctUlSxrkezDpgoyw78el+xRW40Zx2w6VByPuX+mFTN 74/rju/WlNHlLNZyAeSskh8kOh65NJzhaBSRsssZsGFkRni6UGX/PmDvy6BGo023knu4 XjOA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:message-id:in-reply-to:date:references:organization :subject:cc:to:from:dkim-signature; bh=ba9Ze441Gqo/3BJd79qbxGobbmk9MtCOxZSfTAYDuMM=; b=L83dqmhZEyFR72cEE8c9lvkvb/CCkiYqDK/QkvAUv22R2vunZZqSoiltZVFBtd8WHj xZ6B5FAvgIW3IWxY8I28XysnSGU+9KZsNGBcfR4OsFe7oP0tBAKTLxSiih9pzB2QuZQF eQIaI2MY+IoqYDfcIZqz6BoMdwIx82feF+m17jFCl678s34Ul0DZu8QJaCfeP0Ph+Znm CJRm9k9l4fQY1t7raBVV1v66ng1bB/RMJBtJKa9swleTAxeQRvoIh0ua7m8ca7iW9Z6P R+fNKMDfEEizxfBk7H/lEyuhe7enIBrIFxBdgEMkLLl5hFQTiOIidammeZwSApel9Xyx eL3w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@mork.no header.s=b header.b=EpMs4Ot5; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f6-v6si277655plt.346.2018.10.19.04.23.07; Fri, 19 Oct 2018 04:23:23 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@mork.no header.s=b header.b=EpMs4Ot5; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727292AbeJST2V (ORCPT + 99 others); Fri, 19 Oct 2018 15:28:21 -0400 Received: from canardo.mork.no ([148.122.252.1]:44691 "EHLO canardo.mork.no" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726609AbeJST2V (ORCPT ); Fri, 19 Oct 2018 15:28:21 -0400 Received: from miraculix.mork.no ([IPv6:2a02:2121:34c:118b:c8fa:53ff:fe7c:53d8]) (authenticated bits=0) by canardo.mork.no (8.15.2/8.15.2) with ESMTPSA id w9JBMPOD011397 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Fri, 19 Oct 2018 13:22:26 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mork.no; s=b; t=1539948147; bh=ba9Ze441Gqo/3BJd79qbxGobbmk9MtCOxZSfTAYDuMM=; h=From:To:Cc:Subject:References:Date:Message-ID:From; b=EpMs4Ot5aJUSPWh0Es0qUYD7YioqXjevKc3q6UGCBZMEJwJU5Fh5dAExfucP+T+G5 rw23VgNitt9yD1q3tzKmKegnmizhJk17pbV8lSeiq0/S9dZctGefYO4V6ee+BjodCy 2Lz8Ie7V+GBCxqzqm16N/NOf1/nX+a/RMAciWgHo= Received: from bjorn by miraculix.mork.no with local (Exim 4.89) (envelope-from ) id 1gDSrE-0002YT-DA; Fri, 19 Oct 2018 13:22:20 +0200 From: =?utf-8?Q?Bj=C3=B8rn_Mork?= To: Ivan Khoronzhuk Cc: grygorii.strashko@ti.com, davem@davemloft.net, linux-omap@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, alexander.h.duyck@intel.com Subject: Re: [RFC PATCH net-next 2/4] net: 8021q: vlan_core: allow use list of vlans for real device Organization: m References: <20181016182035.18234-1-ivan.khoronzhuk@linaro.org> <20181016182035.18234-3-ivan.khoronzhuk@linaro.org> Date: Fri, 19 Oct 2018 13:22:20 +0200 In-Reply-To: <20181016182035.18234-3-ivan.khoronzhuk@linaro.org> (Ivan Khoronzhuk's message of "Tue, 16 Oct 2018 21:20:33 +0300") Message-ID: <878t2up4er.fsf@miraculix.mork.no> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Virus-Scanned: clamav-milter 0.100.1 at canardo X-Virus-Status: Clean Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Ivan Khoronzhuk writes: > @@ -236,6 +239,13 @@ __vlan_find_dev_deep_rcu(struct net_device *real_dev, > return NULL; > } >=20=20 > +static inline int > +vlan_for_each(struct net_device *dev, > + int (*action)(struct net_device *dev, int vid, void *arg), > + void *arg) > +{ > +} > + This stub should return 0, shouldn't it? Bj=C3=B8rn