Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 19 Oct 2018 09:47:04 -0400
From:   Dave Jones <davej@codemonkey.org.uk>
To:     Meelis Roos <mroos@linux.ee>
Cc:     Cong Wang <xiyou.wangcong@gmail.com>,
        LKML <linux-kernel@vger.kernel.org>,
        Linux Kernel Network Developers <netdev@vger.kernel.org>,
        davem@davemloft.net
Subject: Re: netconsole warning in 4.19.0-rc7
Message-ID: <20181019134704.ky2vqeij6m77qrpg@codemonkey.org.uk>
Mail-Followup-To: Dave Jones <davej@codemonkey.org.uk>,
        Meelis Roos <mroos@linux.ee>, Cong Wang <xiyou.wangcong@gmail.com>,
        LKML <linux-kernel@vger.kernel.org>,
        Linux Kernel Network Developers <netdev@vger.kernel.org>,
        davem@davemloft.net
References: <e0611057-1b5b-9990-b9fa-060a9b5eba40@linux.ee>
 <CAM_iQpU0+LVwgMea32KQWf8z6Bp1VTmWOGnWNwNSmV0PZzf_ew@mail.gmail.com>
 <20181017034047.nrhstc3b4wzevnri@codemonkey.org.uk>
 <20181017035038.czaqown24rnjn2pw@codemonkey.org.uk>
 <fc91f629-8b91-c8c6-3c62-ffb400588597@linux.ee>
 <20181018145922.ytqxvdihp3iqounl@codemonkey.org.uk>
 <ddc5fea8-6c66-d096-57bb-c86a3771fec4@linux.ee>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ddc5fea8-6c66-d096-57bb-c86a3771fec4@linux.ee>
User-Agent: NeoMutt/20170113 (1.7.2)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, Oct 19, 2018 at 12:51:38PM +0300, Meelis Roos wrote:
 > >   > > I took another look at that error path. Turns out this is all we need I
 > >   > > think..
 > >   >
 > >   > With this patch applied on top of 4.19-rc8, I stll get the warning:
 > >   >
 > >   > [   13.722919] WARNING: CPU: 0 PID: 0 at kernel/softirq.c:168 __local_bh_enable_ip+0x2e/0x44
 > > 
 > > It's going to be a couple days before I get chance to get back to this.
 > > Did the previous patch in this thread (without the _bh) fare any better?
 > 
 > Tried it with rcu_read_unlock() instead, still the same.

Ok, this is going to take more time than I have.  DaveM, do you want
to revert 6fe9487892b32cb1c8b8b0d552ed7222a527fe30, or do you want a
patch doing the same ?

That'll bring back the rcu warning, but fewer people were complaining
about that than this new issue..

	Dave