Received: by 2002:ac0:a582:0:0:0:0:0 with SMTP id m2-v6csp3212917imm; Fri, 19 Oct 2018 07:03:28 -0700 (PDT) X-Google-Smtp-Source: ACcGV61ojlomqp8IjzSoC2M5J7vpUu5Sq9aXpblrkrxJYrdCOSAHiMGuC8P59R0zOM44izt98Khg X-Received: by 2002:a62:4803:: with SMTP id v3-v6mr35847177pfa.89.1539957808428; Fri, 19 Oct 2018 07:03:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1539957808; cv=none; d=google.com; s=arc-20160816; b=bthlrJCBOzUMSwjb8sKseQ904aAFfO+UNPaTp2zRRjp1hJRAz0bcdo7fG6TjYfWd5h b5RWL8+rNp/iwHI3nJHx6lHQUTkGe0lJpQCBZbw880/JmPa7gqBvzW0/fPWUWmujmO6L qalHDSI76D2ZXOGA3Js6Y0MWNGMI/gUQo24EsSJrwvHKEMYs19jJdlyeE3qp+Ly/CcP3 R1dDrJ6Q9M1ATc1C5FqzyIlUn9l2yke+4xLgsMe71z9X73phnMt5lZzAx9a4Y8RUNTCc 9Tk713p5V01bnWcNNH/26oJgox5xecgN7ncsZgSkuHlglJL/U9YCmid3HUcgX5l6sQsJ CQnw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:mail-followup-to:message-id:subject:cc:to:from:date :dkim-signature; bh=pEaq2WADQ8QhQo85ktbko2SRiMC6j426PMsstb1Vrso=; b=ekOjunrNYHp87XP32aeJr8a6KmhIeODjGfJV+6fQr3B9UE2eN+Dz6W9iX4C3deytVs McATRhORcBKLkcwmNay2w5EfQaj9xiAUhA4wnBvGb3dy8SzjIhXHLb8BNrpkJVKEZM/D HokLg7+Pd9elKZqBGt8kTmiqKD3rV2YY/6O1s2zPVTuGMncyDtVtiBpVCwKWpKI3QGAc QQALgmc1AVx5nir8UUYaFWzqfRh57Gq16B/FhXo8XJgJrHIUq08s0fowqa1db9luFpjd sWkTMhnFVeBgMSIbWgoe9VSW0uqFpNGmhbq+RsLULAoY20L1l4O3V4s0jfXtgXyt+nww mGWg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=e8F2k2bx; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z3-v6si2683905pgh.250.2018.10.19.07.03.12; Fri, 19 Oct 2018 07:03:28 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=e8F2k2bx; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727634AbeJSWI5 (ORCPT + 99 others); Fri, 19 Oct 2018 18:08:57 -0400 Received: from mail-lf1-f68.google.com ([209.85.167.68]:40012 "EHLO mail-lf1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727426AbeJSWI5 (ORCPT ); Fri, 19 Oct 2018 18:08:57 -0400 Received: by mail-lf1-f68.google.com with SMTP id t22-v6so25325295lfb.7 for ; Fri, 19 Oct 2018 07:02:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=pEaq2WADQ8QhQo85ktbko2SRiMC6j426PMsstb1Vrso=; b=e8F2k2bxtyT/9qqMi6YX7WTno+Dnjlqle4KnJ7WLDJChLYDqKUFf/5rJ1F3G/Zv/dz 2wNnwCMQzyYvsKRSGibhoqJ5PxhWk4IhcZQMh5yEpvPnixzhXYWPoJhE8a/mHS7V6pWp hV0NGjz/iZisx05SDvWmpn3UPBe1VsQ/OMJYw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=pEaq2WADQ8QhQo85ktbko2SRiMC6j426PMsstb1Vrso=; b=HTcAnyEFtc96CCL+BNSUvP9KDb6b3QX2Ojv4WkQH8YMQX7lSIe0X1HB+T9/XeBwMr7 vC/BjFqLDGzZKySOUHtjXmTmA0nDA5GkH4Em4cYUGKX/sL4V9O6SMpa9XWp2LjTbQLsy HQOpGNIw8boTmqd2ve+yAGAXf1LhemIDj1hU9mHiUqP8sATc9jelkTRGQjq+3SDGiuU1 St/5kQ43XmqlHnuG4piqt27SYj6ovsWgX/AItlAoejqfltiJ/4ydsI2E5s4TqItabajC RgEmCnp7LiLMSjGu8DOkNCnkk1aRxxZf1mAmc/KgYY8XQQwMW7WbzdJ1YlhEjHoP0oR4 yh6g== X-Gm-Message-State: ABuFfohqXYmo3ZNSMTLCa7yBj/DbVQqJqBK28LH3xfvfzUUEEM+OA2gT 1JovW4UPs+qThcoUTkd0z4ynQw== X-Received: by 2002:a19:f115:: with SMTP id p21mr2352014lfh.20.1539957759579; Fri, 19 Oct 2018 07:02:39 -0700 (PDT) Received: from khorivan (59-201-94-178.pool.ukrtel.net. [178.94.201.59]) by smtp.gmail.com with ESMTPSA id w1-v6sm5016812lfe.93.2018.10.19.07.02.38 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 19 Oct 2018 07:02:38 -0700 (PDT) Date: Fri, 19 Oct 2018 17:02:36 +0300 From: Ivan Khoronzhuk To: =?iso-8859-1?Q?Bj=F8rn?= Mork Cc: grygorii.strashko@ti.com, davem@davemloft.net, linux-omap@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, alexander.h.duyck@intel.com Subject: Re: [RFC PATCH net-next 2/4] net: 8021q: vlan_core: allow use list of vlans for real device Message-ID: <20181019140235.GB3909@khorivan> Mail-Followup-To: =?iso-8859-1?Q?Bj=F8rn?= Mork , grygorii.strashko@ti.com, davem@davemloft.net, linux-omap@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, alexander.h.duyck@intel.com References: <20181016182035.18234-1-ivan.khoronzhuk@linaro.org> <20181016182035.18234-3-ivan.khoronzhuk@linaro.org> <878t2up4er.fsf@miraculix.mork.no> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1; format=flowed Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <878t2up4er.fsf@miraculix.mork.no> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 19, 2018 at 01:22:20PM +0200, Bj?rn Mork wrote: >Ivan Khoronzhuk writes: > >> @@ -236,6 +239,13 @@ __vlan_find_dev_deep_rcu(struct net_device *real_dev, >> return NULL; >> } >> >> +static inline int >> +vlan_for_each(struct net_device *dev, >> + int (*action)(struct net_device *dev, int vid, void *arg), >> + void *arg) >> +{ >> +} >> + > > >This stub should return 0, shouldn't it? yes, it has. > > >Bj?rn -- Regards, Ivan Khoronzhuk