Received: by 2002:ac0:a582:0:0:0:0:0 with SMTP id m2-v6csp3314601imm; Fri, 19 Oct 2018 08:36:09 -0700 (PDT) X-Google-Smtp-Source: ACcGV61mzp+LQOW2njKuWGVLS3/6FXlNMaKN3mM6HxYtOEOsFxfVXUBIli2l31UKokRp33X+7LXN X-Received: by 2002:aa7:8305:: with SMTP id t5-v6mr34774162pfm.81.1539963369839; Fri, 19 Oct 2018 08:36:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1539963369; cv=none; d=google.com; s=arc-20160816; b=imxLhNFxQxev1k3g21pjxWWgJhFE1NXGDWNW8Zex3+T2msEpwneJ/bQ/FSInrNES9z 4EqmlkKAXSzYJdIdPcPX7VhiIpVAJmfJmVs3aJjLdlJ0YqNTFhZPzPNHzfUeEAdIOKcC 5UqeLqN1qvsAXig2tk3zSeRf7cYDwBiEJ98YLT8Qpso63hpEHK6PxQgeFUKS3WoXUx9n AXEjhcSPSMgPE0qv+EzT0RPfyut8bHLUJHE9MfX+dea4ptvSFOLNADm/lP30u26VGAVX SmX9qsw2J9z4S0/wHE5obMHMIyNTSYuPpMzTWOVqsrGS4KRbgKp1+o2yQtUp/Ua9E3tx oACw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:content-transfer-encoding :content-id:mime-version:subject:cc:to:references:in-reply-to:from :organization; bh=rjn9KUKOMaJD7YGVF5bBOWub9Cv+YQYGbIaitB2+YJU=; b=XQhJP4v1XMUaZfWC/tmjtvTnEJVDlwtWRfTK9auw4zJMieFDczyaKW4P1TYSTRd1fk 5hW9xhZi29tC2BZa1VCDffGYvskBzGp9yoXtxAXRltMA+iNwtpS1tbXYbsjqFo0Bol3u Vw7/hgTeFX/ctBNxLzceJBbYtNfO40HdFAFl/9F3KroasU982kAo09BqIU5I8ahNskRW Wae8VeNcalAg5pztVOJ3YPw9WBLOCfbj2PGlsCVWMQ0s05Cx5WhONfQ7p18fThPCTyqg vO3bprjdsd1h+nFhwcV20ZPfQR3t/wATl4yV+yP8b+vx7Bf/QvSY/aEoKSVQXxfZ6rZG /wwQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c21-v6si24133098pgg.407.2018.10.19.08.35.54; Fri, 19 Oct 2018 08:36:09 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727532AbeJSXmC convert rfc822-to-8bit (ORCPT + 99 others); Fri, 19 Oct 2018 19:42:02 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33278 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726465AbeJSXmC (ORCPT ); Fri, 19 Oct 2018 19:42:02 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B0727300DA38; Fri, 19 Oct 2018 15:35:25 +0000 (UTC) Received: from warthog.procyon.org.uk (ovpn-120-250.rdu2.redhat.com [10.10.120.250]) by smtp.corp.redhat.com (Postfix) with ESMTP id 380FB6AE94; Fri, 19 Oct 2018 15:35:22 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20181019122049.27121-2-mszeredi@redhat.com> References: <20181019122049.27121-2-mszeredi@redhat.com> <20181019122049.27121-1-mszeredi@redhat.com> To: Miklos Szeredi Cc: dhowells@redhat.com, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-api@vger.kernel.org, Michael Kerrisk , Andreas Dilger , Florian Weimer , Amir Goldstein Subject: Re: [PATCH v2 2/5] uapi: deprecate STATX_ALL MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <16381.1539963322.1@warthog.procyon.org.uk> Content-Transfer-Encoding: 8BIT Date: Fri, 19 Oct 2018 16:35:22 +0100 Message-ID: <16382.1539963322@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.47]); Fri, 19 Oct 2018 15:35:26 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Miklos Szeredi wrote: > +/* > + * This is deprecated, and shall remain the same value in the future. To avoid > + * confusion please use the equivalent (STATX_BASIC_STATS | STATX_BTIME) > + * instead. > + */ > +#define STATX_ALL 0x00000fffU The comment is misleading. STATX_ALL is *not* equivalent to STATX_BASIC_STATS | STATX_BTIME, even though it might be numerically the same. You would need to update the comment when you add STATX_ATTRIBUTES to mention that also. Apart from that, I'm okay with this. Further, please provide a manpage update also. David