Date: Fri, 2 Jan 2004 13:03:27 +0100
From: Jens Axboe <axboe@suse.de>
To: Hugang <hugang@soulinfo.com>
Cc: Bart Samwel <bart@samwel.tk>, Andrew Morton <akpm@osdl.org>,
       smackinlay@mail.com, Bartek Kania <mrbk@gnarf.org>,
       linux-kernel@vger.kernel.org
Subject: Re: [PATCH] laptop-mode-2.6.0 version 5
Message-ID: <20040102120327.GA19822@suse.de>
References: <20031231210756.315.qmail@mail.com> <3FF3887C.90404@samwel.tk> <20031231184830.1168b8ff.akpm@osdl.org> <3FF43BAF.7040704@samwel.tk> <3FF457C0.2040303@samwel.tk> <20040101183545.GD5523@suse.de> <20040102170234.66d6811d@localhost> <20040102112733.GA19526@suse.de> <20040102193849.6ff090da@localhost>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20040102193849.6ff090da@localhost>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1303
Lines: 36

On Fri, Jan 02 2004, Hugang wrote:
> On Fri, 2 Jan 2004 12:27:33 +0100
> Jens Axboe <axboe@suse.de> wrote:
> 
> > I dunno, I can't possibly tell since you haven't given any info about
> > this crash. Where does it crash, do you have an oops? All I could say
> > from your report + patch is that it wasn't valid. There's just no way
> > for current->comm to be NULL, so your patch couldn't possibly have made
> > a difference.
> 
> Attached file is the crashed dmesg, When I disable CONFIG_LBD, the
> problem not found any more.

Ah there you go, then it's just the missing cast to u64. It has nothing
to do with current->comm at all. The compiler should have warned you
about this error, did it not?

The dump printk() needs to be changed anyways, the rw deciphering is not
correct. Something like this is more appropriate:

	if (unlikely(block_dump)) {
		char b[BDEVNAME_SIZE];

		printk("%s(%d): %s block %Lu on %s\n", current->comm,
			current->pid, (rw & WRITE) ? "WRITE" : "READ",
			(u64) bio->bi_sector, bdevname(bio->bi_bdev, b));
	}

-- 
Jens Axboe

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/